jmx-dev Review: JDK-7158614, JMXStartStopTest.sh failing intermittently

[Dmitry Samersoff]

Shanliang,

Changes looks good for me.

Did you test shell changes under Solaris - if my memory is not bogus,
solaris /bin/sh doesn't support ((x++))?

-Dmitry


On 2012-12-03 23:34, shanliang wrote:
> Webrev:
>    http://cr.openjdk.java.net/~sjiang/JDK-7158614/webrev.00/
> 
> shanliang wrote:
>> Hi,
>>
>> The test failed because 2 problems happened on a slow machine:
>>
>> 1) the function _get_pid() did not get right pid because the pid was
>> showed too late
>> or
>> 2) the file JMXStartStop.lck was showed too late too
>>
>> The fix is to add a waiting (max 20 seconds) in the function
>> _app_start() to make sure that the pid and JMXStartStop.lck are both
>> well created. This waiting is not entered in a normal and not too
>> charged machine.
>>
>> I modified too the class JMXStartStopDoSomething, it will wake up
>> every 500ms to check running timeout, instead of 1ms, 1ms is not
>> reasonable short.
>>
>> I tested 1) by not running JMXStartStopDoSomething in the function
>> _app_start()
>> I tested 2) by add one second sleep before creating JMXStartStop.lck
>> file in the class JMXStartStopDoSomething.
>>
>> best regards,
>>
>> Shanliang
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer