jmx-dev 8001048: Allow IIOP transport to be optional

[Alan Bateman]

On 15/12/2012 12:35, Daniel Fuchs wrote:
> Hi Alan,
>
> I have just two small suggestions concerning your changes in the tests:
>
> AddressableTest.java:
> ==============
>
> The test used to print a trace:
> System.out.println(">>>  Test successed for "+protocols[i]);
> and
> System.out.println(">>>  Test failed for "+protocols[i]);
> These traces seem to have been lost in the translation - maybe they 
> should be restored?
I can do, they just seem surplus to requirements as there is already a 
lot of output when there is test failure.

>
> IIOPURLTest.java:
> ===========
>
> Line 56 - maybe it would be worth double checking that the reason why
> MalformedUrlException was fired is because the IIOP classes are indeed
> absent. Trying to load the iiop tie class could confirm it.
>
> Same remark for ProviderTest.java line 79.
Good idea, it serves as an addition check in the event that 
MalformedURLException is thrown for some other reason.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/jmx-dev/attachments/20121215/32c458e6/attachment-0001.html