jmx-dev RFR: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently

[Staffan Larsen]

Looks good!

Thanks,
/Staffan

On 5 nov 2013, at 12:15, Erik Gahlin <erik.gahlin at oracle.com> wrote:

> Thanks for the review, here is an updated webrev.
> 
> http://cr.openjdk.java.net/~egahlin/8027209_4/
> 
> Erik
> 
> Jaroslav Bachorik skrev 2013-11-05 17:30:
>> L49-51 The test declaration should go to the original block @ L25-32
>> L135 You could better use PrivilegedAction<Void> since the return value is effectively discarded
>> 
>> The rest looks fine.
>> 
>> -JB-
>> 
>> On 5.11.2013 16:57, Erik Gahlin wrote:
>>> Could I have a review of this intermittently failing test.
>>> 
>>> Instead of doing Thread.sleep(2000) and assume principal is visible/set
>>> the test now spins until principal is available. I also cleaned up code
>>> to avoid warnings.
>>> 
>>> Thanks
>>> Erik
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~egahlin/8027209_3/
>>> 
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8027209
>> 
>