jmx-dev RFR: 8004179: test/java/lang/management/ThreadMXBean/SynchronizerLockingThread.java doesn't clean up

[Jaroslav Bachorik]

On 09/03/2013 01:54 PM, Alan Bateman wrote:
> On 03/09/2013 12:26, Jaroslav Bachorik wrote:
>> :
>> Hm, actually there are 6 other tests using the LockingThread class which
>> leaves the threads running. So all those tests should be made running in
>> "othervm" mode.
>>
>> Does increasing the number of tests running in "othervm" mode have any
>> negative consequences?
> The big advantage of agentvm mode is that it doesn't need to start a new
> VM for each test so you save on the startup. The advantage is very
> apparent with short running tests, barely noticeable with long running
> tests. It's okay to have tests running in othervm mode (reliability
> trumps performance), we just need to be careful not to use it to fix
> every issue, otherwise the overall test execution time will creep up.

Ok, I've rounded up all the tests in java/lang/management/ThreadMXBean
not cleaning up the threads and not running in "othervm" mode and made
them running in "othervm" mode. There are 5 such tests.

IMO, for 5 tests it is worth to go for the simple solution and just run
them in "othervm" mode. If the number goes significantly higher, though,
we should consider putting more effort into fixing the cleanup logic in
those tests.

The updated patch is at
http://cr.openjdk.java.net/~jbachorik/8004179/webrev.02

-JB-

> 
> -Alan.