jmx-dev Codereview request: 8023529 MBean*Info.equals: throw NPE

Daniel Fuchs daniel.fuchs at oracle.com
Fri Sep 6 05:44:55 PDT 2013


On 9/6/13 1:24 PM, shanliang wrote:
> Hi,
>
> Thanks to review the following fix:
>
> webrev: http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8023954
>
> Shanliang
>

Hi Shanliang,

Looks good - but it looks as if some hashCode() will suffer from the
same issue (for instance MBeanOperationInfo.hashCode)

Do you have an other defect to track that?

I have to wonder why we allow to create an MBeanOperationInfo
with a null name though... I wished the first implementation
had thrown NPE at construction time.

-- daniel


More information about the jmx-dev mailing list