jmx-dev [ping] Re: RFR: 8002307 javax.management.modelmbean.ModelMBeanInfoSupport may expose internal representation by storing an externally mutable object

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Mon Sep 23 02:40:36 PDT 2013


May I have a reviewer take a look at this, please?

-JB-

On 18.7.2013 14:11, Daniel Fuchs wrote:
> Hi Jaroslav,
>
> Looks good overall.
>
> Small nit:
>
> You should remove the comment lines 322-327
> in ModelMBeanInfoSupport.java since your changes make it obsolete.
>
> Also the copyright year in ImmutableDataTest should be 2013 (not 2005).
>
> No need for another round of review.
>
> -- daniel
>
> On 7/18/13 11:54 AM, Jaroslav Bachorik wrote:
>> Hi,
>>
>> thanks for the comments.
>>
>> Here (http://cr.openjdk.java.net/~jbachorik/8002307/webrev.03/) is the
>> updated webrev implementing suggestions from Daniel and Shanliang.
>>
>> -JB-
>>
>>
>



More information about the jmx-dev mailing list