jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

[Daniel Fuchs]

Looks good!

-- daniel

On 9/30/13 11:47 AM, shanliang wrote:
> Daniel Fuchs wrote:
>> Hi Shanliang,
>>
>> Shouldn't 'messageReceived' be at least declared as volatile?
>> It looks as if this test is a multi-thread test which
>> is not MT-safe.
> OK I am convinced:
>      http://cr.openjdk.java.net/~sjiang/JDK-8025206/02/
>
> Thanks,
> Shanliang
>
>>
>> cheers,
>>
>> -- daniel
>>
>> On 9/30/13 8:55 AM, shanliang wrote:
>>> Hi,
>>>
>>> Please review this test fix, I set a much long waiting time to receive a
>>> notification, but not simply wait the test timeout, in order to have
>>> less modification.
>>>
>>> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025206/00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8025206
>>>
>>> Thanks,
>>> Shanliang
>>
>