From Alan.Bateman at oracle.com  Tue Apr  1 12:57:03 2014
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Tue, 01 Apr 2014 13:57:03 +0100
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AB640.4010608@oracle.com>
References: <533AB640.4010608@oracle.com>
Message-ID: <533AB79F.9060303@oracle.com>


I think you are looking for jmx-dev so forwarding to that list.

On 01/04/2014 13:51, alexander stepanov wrote:
> Hello,
>
> Could you please review the fix for the following bug:
> https://bugs.openjdk.java.net/browse/JDK-8038795
>
> Webrev corresponding:
> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>
> Just a minor cleanup of javadoc to avoid tidy warnings; no other code 
> affected.
>
> Thanks.
>
> Regards,
> Alexander


From Alan.Bateman at oracle.com  Tue Apr  1 13:35:20 2014
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Tue, 01 Apr 2014 14:35:20 +0100
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533ABFAC.2020302@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
	<533ABFAC.2020302@oracle.com>
Message-ID: <533AC098.3010305@oracle.com>

On 01/04/2014 14:31, alexander stepanov wrote:
> Thanks!
I should have said that the changes look okay to me. I just assume the 
removal of the </p> isn't really necessary.

-Alan.

From shanliang.jiang at oracle.com  Tue Apr  1 13:43:53 2014
From: shanliang.jiang at oracle.com (shanliang)
Date: Tue, 01 Apr 2014 15:43:53 +0200
Subject: jmx-dev RFR: 8038940 c.s.j.r.i.ClientNotifForwarder$LinearExecutor
 prone to data races
Message-ID: <533AC299.6000209@oracle.com>

Hi,

When ClientNotifForwarder starts, its first communication with 
ServerNotifForwarder is to get clientSequenceNumber, then starts 
LinearExecutor to execute the fetching job. If reconnection happens 
during this communication, a new thread will be started by the 
reconnection to do fetching job too, that's why the test got 
"java.lang.IllegalArgumentException: More than one command "

I have verified the class ClientNotifForwarder to make sure no other 
place would start a new job.

It is difficult to have a regression test to reproduce this bug, it is 
all related to an internal function. I had to add code temporally into 
the implementation to make the reconnection happen during this first 
communication, in order to reproduce the bug and to verify the fix.

webrev: http://cr.openjdk.java.net/~sjiang/JDK-8038940/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8038940

Thanks,
Shanliang

From daniel.fuchs at oracle.com  Tue Apr  1 13:44:20 2014
From: daniel.fuchs at oracle.com (Daniel Fuchs)
Date: Tue, 01 Apr 2014 15:44:20 +0200
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AB79F.9060303@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
Message-ID: <533AC2B4.8070205@oracle.com>

Hi Alexander,

Looks good.

I think I would remove the leading <p> in
http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html
as well. If you don't please check that the generated javadoc for
JMXPrincipal.java still looks good.

While you're at it maybe you should remove the strange <br>&nbsp;
between the @param tags in
<http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/openmbean/CompositeType.java.frames.html>

such as:

   86      * <br>&nbsp;

best regards,

-- daniel


On 4/1/14 2:57 PM, Alan Bateman wrote:
>
> I think you are looking for jmx-dev so forwarding to that list.
>
> On 01/04/2014 13:51, alexander stepanov wrote:
>> Hello,
>>
>> Could you please review the fix for the following bug:
>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>
>> Webrev corresponding:
>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>
>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>> affected.
>>
>> Thanks.
>>
>> Regards,
>> Alexander
>


From alexander.v.stepanov at oracle.com  Tue Apr  1 13:31:24 2014
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Tue, 01 Apr 2014 17:31:24 +0400
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AB79F.9060303@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
Message-ID: <533ABFAC.2020302@oracle.com>

Thanks!

On 01.04.2014 16:57, Alan Bateman wrote:
>
> I think you are looking for jmx-dev so forwarding to that list.
>
> On 01/04/2014 13:51, alexander stepanov wrote:
>> Hello,
>>
>> Could you please review the fix for the following bug:
>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>
>> Webrev corresponding:
>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>
>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code 
>> affected.
>>
>> Thanks.
>>
>> Regards,
>> Alexander
>


From jaroslav.bachorik at oracle.com  Tue Apr  1 13:49:24 2014
From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik)
Date: Tue, 01 Apr 2014 15:49:24 +0200
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AC2B4.8070205@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
	<533AC2B4.8070205@oracle.com>
Message-ID: <533AC3E4.20903@oracle.com>

Hi Alexander,

On 1.4.2014 15:44, Daniel Fuchs wrote:
> Hi Alexander,
>
> Looks good.
>
> I think I would remove the leading <p> in
> http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html

src/share/classes/javax/management/remote/rmi/package.html; line 248 - 
</p> tag could be removed too to make the changes consistent.

-JB-

>
> as well. If you don't please check that the generated javadoc for
> JMXPrincipal.java still looks good.
>
> While you're at it maybe you should remove the strange <br>&nbsp;
> between the @param tags in
> <http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/openmbean/CompositeType.java.frames.html>
>
>
> such as:
>
>    86      * <br>&nbsp;
>
> best regards,
>
> -- daniel
>
>
> On 4/1/14 2:57 PM, Alan Bateman wrote:
>>
>> I think you are looking for jmx-dev so forwarding to that list.
>>
>> On 01/04/2014 13:51, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>>
>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>>> affected.
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander
>>
>


From jaroslav.bachorik at oracle.com  Tue Apr  1 13:54:18 2014
From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik)
Date: Tue, 01 Apr 2014 15:54:18 +0200
Subject: jmx-dev RFR: 8038940
 c.s.j.r.i.ClientNotifForwarder$LinearExecutor prone to data races
In-Reply-To: <533AC299.6000209@oracle.com>
References: <533AC299.6000209@oracle.com>
Message-ID: <533AC50A.2010803@oracle.com>

The patch looks good.

The notification processing is really a convoluted piece of code :/

-JB-

On 1.4.2014 15:43, shanliang wrote:
> Hi,
>
> When ClientNotifForwarder starts, its first communication with
> ServerNotifForwarder is to get clientSequenceNumber, then starts
> LinearExecutor to execute the fetching job. If reconnection happens
> during this communication, a new thread will be started by the
> reconnection to do fetching job too, that's why the test got
> "java.lang.IllegalArgumentException: More than one command "
>
> I have verified the class ClientNotifForwarder to make sure no other
> place would start a new job.
>
> It is difficult to have a regression test to reproduce this bug, it is
> all related to an internal function. I had to add code temporally into
> the implementation to make the reconnection happen during this first
> communication, in order to reproduce the bug and to verify the fix.
>
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8038940/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8038940
>
> Thanks,
> Shanliang


From daniel.fuchs at oracle.com  Tue Apr  1 14:15:19 2014
From: daniel.fuchs at oracle.com (Daniel Fuchs)
Date: Tue, 01 Apr 2014 16:15:19 +0200
Subject: jmx-dev RFR: 8038940
 c.s.j.r.i.ClientNotifForwarder$LinearExecutor prone to data races
In-Reply-To: <533AC299.6000209@oracle.com>
References: <533AC299.6000209@oracle.com>
Message-ID: <533AC9F7.1040605@oracle.com>

Hi Shanliang,

Looks good!

-- daniel

On 4/1/14 3:43 PM, shanliang wrote:
> Hi,
>
> When ClientNotifForwarder starts, its first communication with
> ServerNotifForwarder is to get clientSequenceNumber, then starts
> LinearExecutor to execute the fetching job. If reconnection happens
> during this communication, a new thread will be started by the
> reconnection to do fetching job too, that's why the test got
> "java.lang.IllegalArgumentException: More than one command "
>
> I have verified the class ClientNotifForwarder to make sure no other
> place would start a new job.
>
> It is difficult to have a regression test to reproduce this bug, it is
> all related to an internal function. I had to add code temporally into
> the implementation to make the reconnection happen during this first
> communication, in order to reproduce the bug and to verify the fix.
>
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8038940/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8038940
>
> Thanks,
> Shanliang


From alexander.v.stepanov at oracle.com  Tue Apr  1 14:41:32 2014
From: alexander.v.stepanov at oracle.com (alexander stepanov)
Date: Tue, 01 Apr 2014 18:41:32 +0400
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AC2B4.8070205@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
	<533AC2B4.8070205@oracle.com>
Message-ID: <533AD01C.2050209@oracle.com>

Hello,

Please see the updated webrev here: 
http://cr.openjdk.java.net/~yan/8038795/webrev.01/

 > I just assume the removal of the </p> isn't really necessary.
Yes, probably. That was done just to make tidy happy.

Thanks,
Alexander

On 01.04.2014 17:44, Daniel Fuchs wrote:
> Hi Alexander,
>
> Looks good.
>
> I think I would remove the leading <p> in
> http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html 
>
> as well. If you don't please check that the generated javadoc for
> JMXPrincipal.java still looks good.
>
> While you're at it maybe you should remove the strange <br>&nbsp;
> between the @param tags in
> <http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/openmbean/CompositeType.java.frames.html> 
>
>
> such as:
>
>   86      * <br>&nbsp;
>
> best regards,
>
> -- daniel
>
>
> On 4/1/14 2:57 PM, Alan Bateman wrote:
>>
>> I think you are looking for jmx-dev so forwarding to that list.
>>
>> On 01/04/2014 13:51, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>>
>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>>> affected.
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander
>>
>


From daniel.fuchs at oracle.com  Tue Apr  1 14:53:47 2014
From: daniel.fuchs at oracle.com (Daniel Fuchs)
Date: Tue, 01 Apr 2014 16:53:47 +0200
Subject: jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy
 warnings cleanup for javax.management
In-Reply-To: <533AD01C.2050209@oracle.com>
References: <533AB640.4010608@oracle.com> <533AB79F.9060303@oracle.com>
	<533AC2B4.8070205@oracle.com> <533AD01C.2050209@oracle.com>
Message-ID: <533AD2FB.1020600@oracle.com>

On 4/1/14 4:41 PM, alexander stepanov wrote:
> Hello,
>
> Please see the updated webrev here:
> http://cr.openjdk.java.net/~yan/8038795/webrev.01/

Thanks Alexander,

It looks good!

-- daniel

>
>  > I just assume the removal of the </p> isn't really necessary.
> Yes, probably. That was done just to make tidy happy.
>
> Thanks,
> Alexander
>
> On 01.04.2014 17:44, Daniel Fuchs wrote:
>> Hi Alexander,
>>
>> Looks good.
>>
>> I think I would remove the leading <p> in
>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html
>>
>> as well. If you don't please check that the generated javadoc for
>> JMXPrincipal.java still looks good.
>>
>> While you're at it maybe you should remove the strange <br>&nbsp;
>> between the @param tags in
>> <http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/openmbean/CompositeType.java.frames.html>
>>
>>
>> such as:
>>
>>   86      * <br>&nbsp;
>>
>> best regards,
>>
>> -- daniel
>>
>>
>> On 4/1/14 2:57 PM, Alan Bateman wrote:
>>>
>>> I think you are looking for jmx-dev so forwarding to that list.
>>>
>>> On 01/04/2014 13:51, alexander stepanov wrote:
>>>> Hello,
>>>>
>>>> Could you please review the fix for the following bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>>>
>>>> Webrev corresponding:
>>>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>>>
>>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>>>> affected.
>>>>
>>>> Thanks.
>>>>
>>>> Regards,
>>>> Alexander
>>>
>>
>