jmx-dev RFR 8031559: javax/management/monitor/StartStopTest.java fails intermittently

[Staffan Larsen]

On 21 jan 2014, at 08:52, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:

> On 21.1.2014 08:48, Staffan Larsen wrote:
>> You added:
>> 
>>   30  * @library /lib/testlibrary
>>   31  * @run build jdk.testlibrary.Utils
>>   ...
>>   57 import jdk.testlibrary.Utils;
>> 
>> But I don’t see any actual usage of Utils.
> 
> Correct. I have updated the Utils to give easy access to the timeout factor but the patch hasn't been approved yet :(

My fault. I forgot that review - done now.

> I will remove the Utils reference before pushing.

Or you can use the new Utils now :-)

/Staffan

> 
> -JB-
> 
>> 
>> Otherwise it looks good.
>> 
>> /Staffan
>> 
>> On 20 jan 2014, at 16:41, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:
>> 
>>> Please, review the following test change.
>>> 
>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8031559
>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8031559/webrev.00
>>> 
>>> The test fails intermittently - the "called" flag it is using to indicate that a workload was successfully processed is not volatile or synchronized and is set from a different thread than the one which checks it. This can lead to race conditions making the test fail. The other test improvement is to honor the "test.timeout.factor" property to properly scale any timeouts used in the test.
>>> 
>>> Thanks,
>>> 
>>> -JB-
>> 
>