From shanliang.jiang at oracle.com Thu Jun 12 06:21:41 2014 From: shanliang.jiang at oracle.com (shanliang) Date: Thu, 12 Jun 2014 08:21:41 +0200 Subject: jmx-dev Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code Message-ID: <539946F5.6030801@oracle.com> Hi, Please review the following fix: webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044865 Thanks, Shanliang From staffan.larsen at oracle.com Thu Jun 12 06:29:05 2014 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 12 Jun 2014 08:29:05 +0200 Subject: jmx-dev Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code In-Reply-To: <539946F5.6030801@oracle.com> References: <539946F5.6030801@oracle.com> Message-ID: Looks good! Thanks, /Staffan On 12 jun 2014, at 08:21, shanliang wrote: > Hi, > > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ > bug: https://bugs.openjdk.java.net/browse/JDK-8044865 > > Thanks, > Shanliang From daniel.fuchs at oracle.com Thu Jun 12 06:36:00 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Thu, 12 Jun 2014 08:36:00 +0200 Subject: jmx-dev Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code In-Reply-To: <539946F5.6030801@oracle.com> References: <539946F5.6030801@oracle.com> Message-ID: <53994A50.1040702@oracle.com> looks good Shanliang! -- daniel On 6/12/14 8:21 AM, shanliang wrote: > Hi, > > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ > > bug: https://bugs.openjdk.java.net/browse/JDK-8044865 > > Thanks, > Shanliang From erik.gahlin at oracle.com Thu Jun 12 07:36:38 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 12 Jun 2014 09:36:38 +0200 Subject: jmx-dev Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code In-Reply-To: <539946F5.6030801@oracle.com> References: <539946F5.6030801@oracle.com> Message-ID: <53995886.5090104@oracle.com> Looks good Erik shanliang skrev 12/06/14 08:21: > Hi, > > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ > > bug: https://bugs.openjdk.java.net/browse/JDK-8044865 > > Thanks, > Shanliang From jaroslav.bachorik at oracle.com Tue Jun 24 15:15:59 2014 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 24 Jun 2014 17:15:59 +0200 Subject: jmx-dev RFR 8048005: Add test timing information to JMXStartStopTest Message-ID: <53A9962F.1070902@oracle.com> Please, review this simple change to add more debug information to the intermittently timing out test. Issue: https://bugs.openjdk.java.net/browse/JDK-8048005 Webrev: http://cr.openjdk.java.net/~jbachorik/8048005/webrev.00 Might be useful to see which particular test case gets stuck and takes the biggest amount of time. Thanks, -JB- From jaroslav.bachorik at oracle.com Tue Jun 24 15:47:44 2014 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 24 Jun 2014 17:47:44 +0200 Subject: jmx-dev RFR 8047073: Some javax/management/ fails with JFR Message-ID: <53A99DA0.7070605@oracle.com> Please, review this test change. Issue : https://bugs.openjdk.java.net/browse/JDK-8047073 Webrev: http://cr.openjdk.java.net/~jbachorik/8047073/webrev.00 When the test is run with JFR the MBean platform server is initialized before the main method is executed. Therefore, setting the system properties in the code to influence JMX behaviour is ineffective. The system properties need to be set in the @run clause of the JTreg test. Thanks, -JB- From erik.gahlin at oracle.com Tue Jun 24 16:10:25 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 24 Jun 2014 18:10:25 +0200 Subject: jmx-dev RFR 8047073: Some javax/management/ fails with JFR In-Reply-To: <53A99DA0.7070605@oracle.com> References: <53A99DA0.7070605@oracle.com> Message-ID: <53A9A2F1.9020305@oracle.com> Looks good! (Not Reviewer) Erik Jaroslav Bachorik skrev 2014-06-24 17:47: > Please, review this test change. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8047073 > Webrev: http://cr.openjdk.java.net/~jbachorik/8047073/webrev.00 > > When the test is run with JFR the MBean platform server is initialized > before the main method is executed. Therefore, setting the system > properties in the code to influence JMX behaviour is ineffective. The > system properties need to be set in the @run clause of the JTreg test. > > Thanks, > > -JB- From erik.gahlin at oracle.com Tue Jun 24 16:23:29 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 24 Jun 2014 18:23:29 +0200 Subject: jmx-dev RFR 8048005: Add test timing information to JMXStartStopTest In-Reply-To: <53A9962F.1070902@oracle.com> References: <53A9962F.1070902@oracle.com> Message-ID: <53A9A601.7030004@oracle.com> Looks good! (Not a Reviewer) Erik Jaroslav Bachorik skrev 2014-06-24 17:15: > Please, review this simple change to add more debug information to the > intermittently timing out test. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8048005 > Webrev: http://cr.openjdk.java.net/~jbachorik/8048005/webrev.00 > > Might be useful to see which particular test case gets stuck and takes > the biggest amount of time. > > Thanks, > > -JB- From daniel.fuchs at oracle.com Tue Jun 24 16:44:36 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 24 Jun 2014 18:44:36 +0200 Subject: jmx-dev RFR 8047073: Some javax/management/ fails with JFR In-Reply-To: <53A99DA0.7070605@oracle.com> References: <53A99DA0.7070605@oracle.com> Message-ID: <53A9AAF4.40906@oracle.com> Hi Jaroslav, In SerialCompatTest you should probably remove line 226. Otherwise looks good! -- daniel On 6/24/14 5:47 PM, Jaroslav Bachorik wrote: > Please, review this test change. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8047073 > Webrev: http://cr.openjdk.java.net/~jbachorik/8047073/webrev.00 > > When the test is run with JFR the MBean platform server is initialized > before the main method is executed. Therefore, setting the system > properties in the code to influence JMX behaviour is ineffective. The > system properties need to be set in the @run clause of the JTreg test. > > Thanks, > > -JB- From daniel.fuchs at oracle.com Tue Jun 24 16:46:25 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 24 Jun 2014 18:46:25 +0200 Subject: jmx-dev RFR 8048005: Add test timing information to JMXStartStopTest In-Reply-To: <53A9A601.7030004@oracle.com> References: <53A9962F.1070902@oracle.com> <53A9A601.7030004@oracle.com> Message-ID: <53A9AB61.7070107@oracle.com> Looks good. -- daniel On 6/24/14 6:23 PM, Erik Gahlin wrote: > Looks good! (Not a Reviewer) > > Erik > > Jaroslav Bachorik skrev 2014-06-24 17:15: >> Please, review this simple change to add more debug information to the >> intermittently timing out test. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8048005 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8048005/webrev.00 >> >> Might be useful to see which particular test case gets stuck and takes >> the biggest amount of time. >> >> Thanks, >> >> -JB- > From jaroslav.bachorik at oracle.com Tue Jun 24 18:08:47 2014 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 24 Jun 2014 20:08:47 +0200 Subject: jmx-dev RFR 8038826: sun/management/jmxremote/startstop/JMXStartStopTest.java fails with "should report port in use" Message-ID: <53A9BEAF.1020405@oracle.com> Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8038826 Webrev: http://cr.openjdk.java.net/~jbachorik/8038826/webrev.00 The test used to use a final array to pass flags between threads. Obviously not a great choice from the point of visibility. Therefore it was failing intermittently when it should have passed, according to logs. The fix is to use an atomic int value to indicate a mode of failure. Thanks, -JB- From staffan.larsen at oracle.com Wed Jun 25 06:58:26 2014 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 25 Jun 2014 08:58:26 +0200 Subject: jmx-dev RFR 8038826: sun/management/jmxremote/startstop/JMXStartStopTest.java fails with "should report port in use" In-Reply-To: <53A9BEAF.1020405@oracle.com> References: <53A9BEAF.1020405@oracle.com> Message-ID: Looks good! Thanks, /Staffan On 24 jun 2014, at 20:08, Jaroslav Bachorik wrote: > Please, review the following test fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8038826 > Webrev: http://cr.openjdk.java.net/~jbachorik/8038826/webrev.00 > > The test used to use a final array to pass flags between threads. Obviously not a great choice from the point of visibility. Therefore it was failing intermittently when it should have passed, according to logs. > > The fix is to use an atomic int value to indicate a mode of failure. > > Thanks, > > -JB- From jaroslav.bachorik at oracle.com Mon Jun 30 16:35:48 2014 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 30 Jun 2014 18:35:48 +0200 Subject: jmx-dev RFR 8038794: java/lang/management/ThreadMXBean/SynchronizationStatistics.java fails intermittently Message-ID: <53B191E4.9030304@oracle.com> Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8038794 Webrev: http://cr.openjdk.java.net/~jbachorik/8038794/webrev.00 The problem described in this issue is that while a thread was blocked the blocked count reported by the MBean does not reflect it in very rare cases. However, it should be enough to wait a few moments to let the VM counter propagate the value to the MBean. The attempted fix will cause the test to wait for the expected values instead of doing a one-time check. In the worst case the test will be timed out by the harness. The rest of the changes just add more info to debug outputs. Thanks, -JB-