From shanliang.jiang at oracle.com  Mon Nov  3 13:33:53 2014
From: shanliang.jiang at oracle.com (shanliang)
Date: Mon, 03 Nov 2014 14:33:53 +0100
Subject: jmx-dev Code review: 8046192 Eliminate SNMP dependencies to the
 internal APIs from open jdk modules
In-Reply-To: <5453BC5C.6000804@oracle.com>
References: <5453BC5C.6000804@oracle.com>
Message-ID: <54578441.6010304@oracle.com>

Hi, Here is version 2:
    http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/

The modification in ./jdk/src was missed in the first version.

The webreviews show only modification in the public part.

Thanks,
Shanliang

shanliang wrote:
> Hi,
>
> The fix is to remove unnecessary exports for jdk.snmp module.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8046192
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8046192/00/
>
> Thanks,
> Shanliang


From Alan.Bateman at oracle.com  Mon Nov  3 16:20:22 2014
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Mon, 03 Nov 2014 16:20:22 +0000
Subject: jmx-dev Code review: 8046192 Eliminate SNMP dependencies to the
 internal APIs from open jdk modules
In-Reply-To: <54578441.6010304@oracle.com>
References: <5453BC5C.6000804@oracle.com> <54578441.6010304@oracle.com>
Message-ID: <5457AB46.5040300@oracle.com>

On 03/11/2014 13:33, shanliang wrote:
> Hi, Here is version 2:
>    http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/
>
> The modification in ./jdk/src was missed in the first version.
>
This looks okay to me now.

-Alan

From mandy.chung at oracle.com  Mon Nov  3 18:25:30 2014
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 03 Nov 2014 10:25:30 -0800
Subject: jmx-dev Code review: 8046192 Eliminate SNMP dependencies to the
 internal APIs from open jdk modules
In-Reply-To: <54578441.6010304@oracle.com>
References: <5453BC5C.6000804@oracle.com> <54578441.6010304@oracle.com>
Message-ID: <5457C89A.2080208@oracle.com>

On 11/3/14 5:33 AM, shanliang wrote:
> Hi, Here is version 2:
>    http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/
>

Looks okay to me.

Thanks
Mandy