From jaroslav.bachorik at oracle.com Tue Aug 18 14:35:24 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 18 Aug 2015 16:35:24 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector Message-ID: <55D342AC.8000005@oracle.com> Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 For Java SE 8, JSR 160 was updated to downgrade the support for the JXM RMI-IIOP transport from required to optional. This was the first step in a multi-release effort to remove support for the IIOP transport from the JMX Remote API. Early in JDK 9, the build was changed to not include the JMX RMI-IIOP connector by default. This is the last step in removing the JMX RMI-IIOP connector from the JMX specification. This changeset will remove the implementation classes as well as related tests. All jdk_jmx and jdk_management tests are passing after this change. JCK tests will need to be updated (tracked in a related issue). Thanks, -JB- From Alan.Bateman at oracle.com Wed Aug 19 06:19:20 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Aug 2015 07:19:20 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D342AC.8000005@oracle.com> References: <55D342AC.8000005@oracle.com> Message-ID: <55D41FE8.9000600@oracle.com> On 18/08/2015 15:35, Jaroslav Bachorik wrote: > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 > Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 > > For Java SE 8, JSR 160 was updated to downgrade the support for the > JXM RMI-IIOP transport from required to optional. This was the first > step in a multi-release effort to remove support for the IIOP > transport from the JMX Remote API. > > Early in JDK 9, the build was changed to not include the JMX RMI-IIOP > connector by default. > > This is the last step in removing the JMX RMI-IIOP connector from the > JMX specification. This changeset will remove the implementation > classes as well as related tests. > > All jdk_jmx and jdk_management tests are passing after this change. > JCK tests will need to be updated (tracked in a related issue). Do you have a webrev for the changes to the top-level repo? I ask because part of the removal has to be the removal of the --enable-rmiconnector-iiop configure option, essentially removing the changes introduced by: http://hg.openjdk.java.net/jdk9/dev/rev/e9e5bd372a4e -Alan From jaroslav.bachorik at oracle.com Wed Aug 19 08:59:01 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 19 Aug 2015 10:59:01 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D41FE8.9000600@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> Message-ID: <55D44555.7090601@oracle.com> On 19.8.2015 08:19, Alan Bateman wrote: > On 18/08/2015 15:35, Jaroslav Bachorik wrote: >> Please, review the following change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 >> >> For Java SE 8, JSR 160 was updated to downgrade the support for the >> JXM RMI-IIOP transport from required to optional. This was the first >> step in a multi-release effort to remove support for the IIOP >> transport from the JMX Remote API. >> >> Early in JDK 9, the build was changed to not include the JMX RMI-IIOP >> connector by default. >> >> This is the last step in removing the JMX RMI-IIOP connector from the >> JMX specification. This changeset will remove the implementation >> classes as well as related tests. >> >> All jdk_jmx and jdk_management tests are passing after this change. >> JCK tests will need to be updated (tracked in a related issue). > Do you have a webrev for the changes to the top-level repo? I ask > because part of the removal has to be the removal of the > --enable-rmiconnector-iiop configure option, essentially removing the > changes introduced by: > > http://hg.openjdk.java.net/jdk9/dev/rev/e9e5bd372a4e I missed this. However, I have my doubts about 'common/autoconf/generated-configure.sh' - the comment says this file should not be edited but it was changed in the aforementioned commit. Should I change it back? -JB- > > -Alan From Alan.Bateman at oracle.com Wed Aug 19 09:02:53 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Aug 2015 10:02:53 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D44555.7090601@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> Message-ID: <55D4463D.2010109@oracle.com> On 19/08/2015 09:59, Jaroslav Bachorik wrote: > > I missed this. However, I have my doubts about > 'common/autoconf/generated-configure.sh' - the comment says this file > should not be edited but it was changed in the aforementioned commit. > Should I change it back? You will need to edit spec.gmk.in and jdk-options.m4, then re-run autogen to regenerate generated-configure.sh. -Alan From jaroslav.bachorik at oracle.com Wed Aug 19 10:47:34 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 19 Aug 2015 12:47:34 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D4463D.2010109@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> Message-ID: <55D45EC6.30606@oracle.com> On 19.8.2015 11:02, Alan Bateman wrote: > > > On 19/08/2015 09:59, Jaroslav Bachorik wrote: >> >> I missed this. However, I have my doubts about >> 'common/autoconf/generated-configure.sh' - the comment says this file >> should not be edited but it was changed in the aforementioned commit. >> Should I change it back? > You will need to edit spec.gmk.in and jdk-options.m4, then re-run > autogen to regenerate generated-configure.sh. Top level changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk -JB- > > -Alan From Alan.Bateman at oracle.com Wed Aug 19 11:20:58 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Aug 2015 12:20:58 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D45EC6.30606@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> Message-ID: <55D4669A.5080307@oracle.com> On 19/08/2015 11:47, Jaroslav Bachorik wrote: > Top level changes: > http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ > JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk I think you also need to look at jake/make/rmic/Rmic-java.management.gmk which is where RMICONNECTOR_IIOP is used. This is the original change to the jdk repo but the make files have since been refactored: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c952b81ad038 -Alan From david.holmes at oracle.com Wed Aug 19 12:39:35 2015 From: david.holmes at oracle.com (David Holmes) Date: Wed, 19 Aug 2015 22:39:35 +1000 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D45EC6.30606@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> Message-ID: <55D47907.6000806@oracle.com> Hi Jaroslav, Note you will also have to push the closed generated-configure.sh file. David On 19/08/2015 8:47 PM, Jaroslav Bachorik wrote: > On 19.8.2015 11:02, Alan Bateman wrote: >> >> >> On 19/08/2015 09:59, Jaroslav Bachorik wrote: >>> >>> I missed this. However, I have my doubts about >>> 'common/autoconf/generated-configure.sh' - the comment says this file >>> should not be edited but it was changed in the aforementioned commit. >>> Should I change it back? >> You will need to edit spec.gmk.in and jdk-options.m4, then re-run >> autogen to regenerate generated-configure.sh. > > Top level changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ > JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk > > -JB- > >> >> -Alan > From jaroslav.bachorik at oracle.com Wed Aug 19 12:51:36 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 19 Aug 2015 14:51:36 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D4669A.5080307@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> Message-ID: <55D47BD8.4000409@oracle.com> On 19.8.2015 13:20, Alan Bateman wrote: > On 19/08/2015 11:47, Jaroslav Bachorik wrote: >> Top level changes: >> http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/ >> JDK changes: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.01/jdk > I think you also need to look at jake/make/rmic/Rmic-java.management.gmk > which is where RMICONNECTOR_IIOP is used. This is the original change to > the jdk repo but the make files have since been refactored: > > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c952b81ad038 I hope I got it all this time. Used brute force search for any mention of 'iiop' and removed anything that had anything to do with JMX. Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02 JDK: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02/jdk -JB- > > -Alan From Alan.Bateman at oracle.com Wed Aug 19 13:05:19 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Aug 2015 14:05:19 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D47BD8.4000409@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> <55D47BD8.4000409@oracle.com> Message-ID: <55D47F0F.4050903@oracle.com> On 19/08/2015 13:51, Jaroslav Bachorik wrote: > > I hope I got it all this time. Used brute force search for any mention > of 'iiop' and removed anything that had anything to do with JMX. > > Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02 > JDK: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02/jdk I think you are close :-) The @deprecated in class RMIIIOPServerImpl says "This method was ..." when it should be "This class". It might be simpler to just drop that sentence and say "The IIOP transport is no longer supported". I see the methods in this class throw UOE but I assume that can't happen because the constructor always throws an exception (except of course if someone does something sneaky, say with finalizers). So I think what you have is okay. There are several tests in jdk/test/javax/management that exercise IIOP if available, shouldn't they be updated too? -Alan. From jaroslav.bachorik at oracle.com Wed Aug 19 14:01:07 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 19 Aug 2015 16:01:07 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D47F0F.4050903@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> <55D47BD8.4000409@oracle.com> <55D47F0F.4050903@oracle.com> Message-ID: <55D48C23.5040301@oracle.com> On 19.8.2015 15:05, Alan Bateman wrote: > On 19/08/2015 13:51, Jaroslav Bachorik wrote: >> >> I hope I got it all this time. Used brute force search for any mention >> of 'iiop' and removed anything that had anything to do with JMX. >> >> Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02 >> JDK: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02/jdk > > I think you are close :-) > > The @deprecated in class RMIIIOPServerImpl says "This method was ..." > when it should be "This class". It might be simpler to just drop that > sentence and say "The IIOP transport is no longer supported". Ok. > > I see the methods in this class throw UOE but I assume that can't happen > because the constructor always throws an exception (except of course if > someone does something sneaky, say with finalizers). So I think what you > have is okay. Yes, under normal circumstances you should never be able to obtain an instance of this class. > > There are several tests in jdk/test/javax/management that exercise IIOP > if available, shouldn't they be updated too? Not sure about this. These tests are also exercising JMXMP if available - but that has never been a part of JDK. -JB- > > -Alan. > > From Alan.Bateman at oracle.com Wed Aug 19 14:32:29 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Aug 2015 15:32:29 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D48C23.5040301@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> <55D47BD8.4000409@oracle.com> <55D47F0F.4050903@oracle.com> <55D48C23.5040301@oracle.com> Message-ID: <55D4937D.2050802@oracle.com> On 19/08/2015 15:01, Jaroslav Bachorik wrote: > : > >> >> There are several tests in jdk/test/javax/management that exercise IIOP >> if available, shouldn't they be updated too? > > Not sure about this. These tests are also exercising JMXMP if > available - but that has never been a part of JDK. I think the tests date back to when JMX was a standalone JSR and RI. In any case, with IIOP support removed then it seems like these tests should be updated but it's not critical to do it now. -Alan From jaroslav.bachorik at oracle.com Wed Aug 19 14:40:48 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 19 Aug 2015 16:40:48 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D4937D.2050802@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> <55D47BD8.4000409@oracle.com> <55D47F0F.4050903@oracle.com> <55D48C23.5040301@oracle.com> <55D4937D.2050802@oracle.com> Message-ID: <55D49570.9020602@oracle.com> On 19.8.2015 16:32, Alan Bateman wrote: > > > On 19/08/2015 15:01, Jaroslav Bachorik wrote: >> : >> >>> >>> There are several tests in jdk/test/javax/management that exercise IIOP >>> if available, shouldn't they be updated too? >> >> Not sure about this. These tests are also exercising JMXMP if >> available - but that has never been a part of JDK. > I think the tests date back to when JMX was a standalone JSR and RI. In > any case, with IIOP support removed then it seems like these tests > should be updated but it's not critical to do it now. What we could do is to update the tests to accept the required protocol as a test parameter. That way they still can serve as a test harness for any potential new JMX connectors (eg. JMXMP etc.) -JB- > > -Alan From jaroslav.bachorik at oracle.com Fri Aug 21 11:49:12 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 21 Aug 2015 13:49:12 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D41FE8.9000600@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> Message-ID: <55D71038.3010203@oracle.com> On 19.8.2015 08:19, Alan Bateman wrote: > On 18/08/2015 15:35, Jaroslav Bachorik wrote: >> Please, review the following change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8043937 >> Webrev: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.00 >> >> For Java SE 8, JSR 160 was updated to downgrade the support for the >> JXM RMI-IIOP transport from required to optional. This was the first >> step in a multi-release effort to remove support for the IIOP >> transport from the JMX Remote API. >> >> Early in JDK 9, the build was changed to not include the JMX RMI-IIOP >> connector by default. >> >> This is the last step in removing the JMX RMI-IIOP connector from the >> JMX specification. This changeset will remove the implementation >> classes as well as related tests. >> >> All jdk_jmx and jdk_management tests are passing after this change. >> JCK tests will need to be updated (tracked in a related issue). > Do you have a webrev for the changes to the top-level repo? I ask > because part of the removal has to be the removal of the > --enable-rmiconnector-iiop configure option, essentially removing the > changes introduced by: > > http://hg.openjdk.java.net/jdk9/dev/rev/e9e5bd372a4e Updated webrev top-level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03 Updated webrev jdk: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03/jdk Contains changes to the top level repo as well as a correct version of jdk/make/rmic/Rmic-java.management.gmk (thanks to Erik Joelsson) -JB- > > -Alan From Alan.Bateman at oracle.com Mon Aug 24 06:52:58 2015 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 24 Aug 2015 07:52:58 +0100 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D71038.3010203@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D71038.3010203@oracle.com> Message-ID: <55DABF4A.4090805@oracle.com> On 21/08/2015 12:49, Jaroslav Bachorik wrote: > > Updated webrev top-level: > http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03 > Updated webrev jdk: > http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03/jdk > > Contains changes to the top level repo as well as a correct version of > jdk/make/rmic/Rmic-java.management.gmk (thanks to Erik Joelsson) The updated webrev and the updated @deprecated in RMIIIOPServerImpl looks good. Can you make sure to test out boot cycle builds before pushing this? That would help with the confidence that the updates to the RMI stub generation are good. -Alan. From jaroslav.bachorik at oracle.com Mon Aug 24 10:18:08 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 24 Aug 2015 12:18:08 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55DABF4A.4090805@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D71038.3010203@oracle.com> <55DABF4A.4090805@oracle.com> Message-ID: <55DAEF60.3080401@oracle.com> On 24.8.2015 08:52, Alan Bateman wrote: > > On 21/08/2015 12:49, Jaroslav Bachorik wrote: >> >> Updated webrev top-level: >> http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03 >> Updated webrev jdk: >> http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03/jdk >> >> Contains changes to the top level repo as well as a correct version of >> jdk/make/rmic/Rmic-java.management.gmk (thanks to Erik Joelsson) > The updated webrev and the updated @deprecated in RMIIIOPServerImpl > looks good. Can you make sure to test out boot cycle builds before > pushing this? That would help with the confidence that the updates to > the RMI stub generation are good. Bootcycle build is ok. -JB- > > -Alan. From erik.joelsson at oracle.com Mon Aug 24 10:34:38 2015 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 24 Aug 2015 12:34:38 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55DABF4A.4090805@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D71038.3010203@oracle.com> <55DABF4A.4090805@oracle.com> Message-ID: <55DAF33E.3050405@oracle.com> This version looks good to me. /Erik On 2015-08-24 08:52, Alan Bateman wrote: > > On 21/08/2015 12:49, Jaroslav Bachorik wrote: >> >> Updated webrev top-level: >> http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03 >> Updated webrev jdk: >> http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03/jdk >> >> Contains changes to the top level repo as well as a correct version >> of jdk/make/rmic/Rmic-java.management.gmk (thanks to Erik Joelsson) > The updated webrev and the updated @deprecated in RMIIIOPServerImpl > looks good. Can you make sure to test out boot cycle builds before > pushing this? That would help with the confidence that the updates to > the RMI stub generation are good. > > -Alan. From jaroslav.bachorik at oracle.com Tue Aug 25 16:29:20 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 25 Aug 2015 18:29:20 +0200 Subject: jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector In-Reply-To: <55D4937D.2050802@oracle.com> References: <55D342AC.8000005@oracle.com> <55D41FE8.9000600@oracle.com> <55D44555.7090601@oracle.com> <55D4463D.2010109@oracle.com> <55D45EC6.30606@oracle.com> <55D4669A.5080307@oracle.com> <55D47BD8.4000409@oracle.com> <55D47F0F.4050903@oracle.com> <55D48C23.5040301@oracle.com> <55D4937D.2050802@oracle.com> Message-ID: <55DC97E0.2000604@oracle.com> On 19.8.2015 16:32, Alan Bateman wrote: > > > On 19/08/2015 15:01, Jaroslav Bachorik wrote: >> : >> >>> >>> There are several tests in jdk/test/javax/management that exercise IIOP >>> if available, shouldn't they be updated too? >> >> Not sure about this. These tests are also exercising JMXMP if >> available - but that has never been a part of JDK. > I think the tests date back to when JMX was a standalone JSR and RI. In > any case, with IIOP support removed then it seems like these tests > should be updated but it's not critical to do it now. The test clean up is tracked as a separate task now - JDK-8134421 -JB- > > -Alan