jmx-dev RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

Alan Bateman Alan.Bateman at oracle.com
Wed Aug 19 13:05:19 UTC 2015


On 19/08/2015 13:51, Jaroslav Bachorik wrote:
>
> I hope I got it all this time. Used brute force search for any mention 
> of 'iiop' and removed anything that had anything to do with JMX.
>
> Top level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02
> JDK: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.02/jdk

I think you are close :-)

The @deprecated in class RMIIIOPServerImpl says "This method was ..." 
when it should be "This class". It might be simpler to just drop that 
sentence and say "The IIOP transport is no longer supported".

I see the methods in this class throw UOE but I assume that can't happen 
because the constructor always throws an exception (except of course if 
someone does something sneaky, say with finalizers). So I think what you 
have is okay.

There are several tests in jdk/test/javax/management that exercise IIOP 
if available, shouldn't they be updated too?

-Alan.




More information about the jmx-dev mailing list