From shanliang.jiang at oracle.com  Tue Feb  3 13:16:28 2015
From: shanliang.jiang at oracle.com (shanliang)
Date: Tue, 03 Feb 2015 14:16:28 +0100
Subject: jmx-dev RFR: 8065213 Specify and implement
 PlatformMBeanProvider for looking for all platform MBeans
In-Reply-To: <54CBC1A6.8090302@oracle.com>
References: <54C7CE2A.1090700@oracle.com> <54C885DB.50304@oracle.com>
	<54CBC1A6.8090302@oracle.com>
Message-ID: <54D0CA2C.4070201@oracle.com>

Hi,

Hope this is last time :)
    http://cr.openjdk.java.net/~sjiang/JDK-8065213/02/

1)
Mandy Chung wrote:
> You may want to consider using limited doPrivileged (that can be done 
> in the second phase).
Done as in ManagementFactory:
 878             // get all providers
 879             List<PlatformMBeanProvider> providers
 880                 = 
AccessController.doPrivileged((PrivilegedAction<List<PlatformMBeanProvider>>) 
() -> {
 881                     List<PlatformMBeanProvider> all = new 
ArrayList<>();
 882                     for (PlatformMBeanProvider provider : 
ServiceLoader.loadInstalled(PlatformMBeanProvider.class)) {
 883                         all.add(provider);
 884                     }
 885                     all.add(new DefaultPlatformMBeanProvider());
 886                     return all;
 887                 },
 888                 null,
 889                 new FilePermission("<<ALL FILES>>", "read"),
 890                 new 
RuntimePermission("sun.management.spi.PlatformMBeanProvider"));

2)
The modification to Flag is removed, we get another solution to know 
whether commercial feature is enabled.

3) some mis minors modifications.

Thanks,
Shanliang

   


From daniel.fuchs at oracle.com  Tue Feb  3 13:26:55 2015
From: daniel.fuchs at oracle.com (Daniel Fuchs)
Date: Tue, 03 Feb 2015 14:26:55 +0100
Subject: jmx-dev RFR: 8065213 Specify and implement
 PlatformMBeanProvider for looking for all platform MBeans
In-Reply-To: <54D0CA2C.4070201@oracle.com>
References: <54C7CE2A.1090700@oracle.com>
	<54C885DB.50304@oracle.com>	<54CBC1A6.8090302@oracle.com>
	<54D0CA2C.4070201@oracle.com>
Message-ID: <54D0CC9F.5090304@oracle.com>

Looks good to me Shanliang.

-- daniel

On 03/02/15 14:16, shanliang wrote:
> Hi,
>
> Hope this is last time :)
>     http://cr.openjdk.java.net/~sjiang/JDK-8065213/02/
>
> 1)
> Mandy Chung wrote:
>> You may want to consider using limited doPrivileged (that can be done
>> in the second phase).
> Done as in ManagementFactory:
> 878             // get all providers
> 879             List<PlatformMBeanProvider> providers
> 880                 =
> AccessController.doPrivileged((PrivilegedAction<List<PlatformMBeanProvider>>)
> () -> {
> 881                     List<PlatformMBeanProvider> all = new
> ArrayList<>();
> 882                     for (PlatformMBeanProvider provider :
> ServiceLoader.loadInstalled(PlatformMBeanProvider.class)) {
> 883                         all.add(provider);
> 884                     }
> 885                     all.add(new DefaultPlatformMBeanProvider());
> 886                     return all;
> 887                 },
> 888                 null,
> 889                 new FilePermission("<<ALL FILES>>", "read"),
> 890                 new
> RuntimePermission("sun.management.spi.PlatformMBeanProvider"));
>
> 2)
> The modification to Flag is removed, we get another solution to know
> whether commercial feature is enabled.
>
> 3) some mis minors modifications.
>
> Thanks,
> Shanliang
>
>


From jaroslav.bachorik at oracle.com  Tue Feb  3 13:49:49 2015
From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik)
Date: Tue, 03 Feb 2015 14:49:49 +0100
Subject: jmx-dev RFR: 8065213 Specify and implement
 PlatformMBeanProvider for looking for all platform MBeans
In-Reply-To: <54D0CA2C.4070201@oracle.com>
References: <54C7CE2A.1090700@oracle.com>
	<54C885DB.50304@oracle.com>	<54CBC1A6.8090302@oracle.com>
	<54D0CA2C.4070201@oracle.com>
Message-ID: <54D0D1FD.4030206@oracle.com>

Looks good!

-JB-

On 3.2.2015 14:16, shanliang wrote:
> Hi,
>
> Hope this is last time :)
>     http://cr.openjdk.java.net/~sjiang/JDK-8065213/02/
>
> 1)
> Mandy Chung wrote:
>> You may want to consider using limited doPrivileged (that can be done
>> in the second phase).
> Done as in ManagementFactory:
> 878             // get all providers
> 879             List<PlatformMBeanProvider> providers
> 880                 =
> AccessController.doPrivileged((PrivilegedAction<List<PlatformMBeanProvider>>)
> () -> {
> 881                     List<PlatformMBeanProvider> all = new
> ArrayList<>();
> 882                     for (PlatformMBeanProvider provider :
> ServiceLoader.loadInstalled(PlatformMBeanProvider.class)) {
> 883                         all.add(provider);
> 884                     }
> 885                     all.add(new DefaultPlatformMBeanProvider());
> 886                     return all;
> 887                 },
> 888                 null,
> 889                 new FilePermission("<<ALL FILES>>", "read"),
> 890                 new
> RuntimePermission("sun.management.spi.PlatformMBeanProvider"));
>
> 2)
> The modification to Flag is removed, we get another solution to know
> whether commercial feature is enabled.
>
> 3) some mis minors modifications.
>
> Thanks,
> Shanliang
>
>


From mandy.chung at oracle.com  Tue Feb  3 17:50:18 2015
From: mandy.chung at oracle.com (Mandy Chung)
Date: Tue, 03 Feb 2015 09:50:18 -0800
Subject: jmx-dev RFR: 8065213 Specify and implement
 PlatformMBeanProvider for looking for all platform MBeans
In-Reply-To: <54D0CA2C.4070201@oracle.com>
References: <54C7CE2A.1090700@oracle.com>
	<54C885DB.50304@oracle.com>	<54CBC1A6.8090302@oracle.com>
	<54D0CA2C.4070201@oracle.com>
Message-ID: <54D10A5A.3030109@oracle.com>

On 2/3/15 5:16 AM, shanliang wrote:
> Hi,
>
> Hope this is last time :)
>    http://cr.openjdk.java.net/~sjiang/JDK-8065213/02/

Looks good.   Some lines are quite long that are better to reformat (no 
need to send a new webrev).

Mandy