jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

Severin Gehwolf sgehwolf at redhat.com
Thu Jan 21 10:30:09 UTC 2016


Hi,

Could somebody please review and sponsor this small 8u bugfix? This bug
has been introduced with the January 2016 CPU fixes (JDK-8130710) and
I've not seen this code in JDK 9 (yet?). Hence, posting this here.

Bug: https://bugs.openjdk.java.net/browse/JDK-8147857
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8147857/webrev.01/

The fix for non-public bug JDK-8130710 uses Collectors.joining() for
assembling the list of attribute names when they get logged. However,
the arguments are passed in to Collectors.joining() incorrectly, which
results in log messages like this:

attribute names=', FirstName[LastName]'

where it should be this:

attribute names='[FirstName, LastName]'

The fix is to swap the arg for the delimiter and the prefix args. I've
included a regression test.

Testing done: jdk_jmx tests fail without the fix and pass after.

Thoughts?

Thanks,
Severin



More information about the jmx-dev mailing list