From adam.farley at uk.ibm.com Tue May 7 16:14:01 2019 From: adam.farley at uk.ibm.com (Adam Farley8) Date: Tue, 7 May 2019 17:14:01 +0100 Subject: jmx-dev : Should this list be archived? Message-ID: Hi All, Does anyone here think this list should/shouldn't be archived? I mean that in a nice way, as I don't want to pursue archiving a list if people are still using it, or plan to. More details on this list-archiving push here: https://bugs.openjdk.java.net/browse/JDK-8220662 List owners were contacted 3 weeks ago, and this is a follow-up for lists whose owners haven't replied yet. Best Regards Adam Farley IBM Runtimes -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniel.fuchs at oracle.com Tue May 7 16:44:01 2019 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 7 May 2019 17:44:01 +0100 Subject: jmx-dev : Should this list be archived? In-Reply-To: References: Message-ID: <37b401a8-7c20-3b68-8b18-ba4f5cbf153a@oracle.com> Hi Adam, Sorry I should have replied to you earlier. Most JMX-related discussions happen in serviceability-dev these days, and people who post here are usually redirected there. I personally don't have any strong opposition in archiving this mailing list - but if it's going to cost me time I don't see any strong incentive to do it either ;-) best regards, -- daniel On 07/05/2019 17:14, Adam Farley8 wrote: > Hi All, > > Does anyone here think this list should/shouldn't be archived? > > I mean that in a nice way, as I don't want to pursue archiving a list if > people are still using it, or plan to. > > More details on this list-archiving push here: > https://bugs.openjdk.java.net/browse/JDK-8220662 > > List owners were contacted 3 weeks ago, and this is a follow-up for > lists whose owners haven't replied yet. > > Best Regards > > Adam Farley > IBM Runtimes From adam.farley at uk.ibm.com Wed May 8 13:02:26 2019 From: adam.farley at uk.ibm.com (Adam Farley8) Date: Wed, 8 May 2019 14:02:26 +0100 Subject: jmx-dev : Should this list be archived? In-Reply-To: <37b401a8-7c20-3b68-8b18-ba4f5cbf153a@oracle.com> References: <37b401a8-7c20-3b68-8b18-ba4f5cbf153a@oracle.com> Message-ID: Hehe, fair enough. :) Best Regards Adam Farley IBM Runtimes Daniel Fuchs wrote on 07/05/2019 17:44:01: > From: Daniel Fuchs > To: Adam Farley8 , jmx-dev at openjdk.java.net > Date: 07/05/2019 17:44 > Subject: Re: jmx-dev : Should this list be archived? > > Hi Adam, > > Sorry I should have replied to you earlier. > > Most JMX-related discussions happen in serviceability-dev these > days, and people who post here are usually redirected there. > > I personally don't have any strong opposition in archiving > this mailing list - but if it's going to cost me time I don't > see any strong incentive to do it either ;-) > > best regards, > > -- daniel > > On 07/05/2019 17:14, Adam Farley8 wrote: > > Hi All, > > > > Does anyone here think this list should/shouldn't be archived? > > > > I mean that in a nice way, as I don't want to pursue archiving a list if > > people are still using it, or plan to. > > > > More details on this list-archiving push here: > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8220662&d=DwIC- > g&c=jf_iaSHvJObTbx-siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=Dyaq- > g5OkbW0m3KDBZTtQhUkRNsk115Ljm9SKQJaFFo&s=zJf8U2bgH7R4zTlOFamvwEOtYq_p_EqylwDFUMixPss&e= > > > > List owners were contacted 3 weeks ago, and this is a follow-up for > > lists whose owners haven't replied yet. > > > > Best Regards > > > > Adam Farley > > IBM Runtimes > > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From adam.farley at uk.ibm.com Wed May 15 15:51:53 2019 From: adam.farley at uk.ibm.com (Adam Farley8) Date: Wed, 15 May 2019 16:51:53 +0100 Subject: jmx-dev List Proposed for Archiving Message-ID: Hi All, After discussion with the list owner, it has been determined that this list should be archived. As other lists also require archiving, an issue has been raised to coordinate this. Issue: https://bugs.openjdk.java.net/browse/JDK-8223962 Best Regards Adam Farley IBM Runtimes Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniil.x.titov at oracle.com Sun May 19 21:12:10 2019 From: daniil.x.titov at oracle.com (Daniil Titov) Date: Sun, 19 May 2019 14:12:10 -0700 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows Message-ID: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. Webrev: http://cr.openjdk.java.net/~dtitov/8214545 Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Thanks! --Daniil From david.holmes at oracle.com Mon May 20 00:43:45 2019 From: david.holmes at oracle.com (David Holmes) Date: Mon, 20 May 2019 10:43:45 +1000 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: Hi Daniil, cc: Boris and Erik J. On 20/05/2019 7:12 am, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 I knew this seemed very familiar ... Boris had a fix for this a few weeks ago under JDK-8220581. Similar but not identical to yours - see below. Though getting rid of the exe from the repo is a good idea (thanks Erik!). A few comments test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh Pre-existing: ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" if [ ! -f "$REVOKEALL" ] ; then I would expect a -x test not -f. --- test/jdk/sun/management/windows/README The first copyright year should be 2004. 25 This directory contains the source and the binary version Delete "and the binary version". --- test/jdk/sun/management/windows/exerevokeall.c Pre-existing: 31 * file - suitable for NT/2000/XP only. Please delete everything after "file". 355 i++; 356 count--; The count-- is obvious as it is the loop counter, but it is far from clear to me that i++ is correct. I don't fully understand the logic but i is only incremented under very specific conditions. If you rewrote the code to avoid the use of the continue then i would not be modified except where it currently is. Thanks, David ----- > Thanks! > --Daniil > > From Alan.Bateman at oracle.com Mon May 20 06:03:28 2019 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 20 May 2019 07:03:28 +0100 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: <0eebc323-7c82-2a7c-0d3d-ae5488394bf2@oracle.com> On 19/05/2019 22:12, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Have you looked at replacing the tool with code that uses the java.nio.file API? You can edit ACLs with that API. -Alan From daniel.fuchs at oracle.com Mon May 20 10:13:08 2019 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Mon, 20 May 2019 11:13:08 +0100 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: Hi, On 20/05/2019 01:43, David Holmes wrote: >> Webrev: http://cr.openjdk.java.net/~dtitov/8214545 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic but > i is only incremented under very specific conditions. If you rewrote the > code to avoid the use of the continue then i would not be modified > except where it currently is. > Looks like `i` tries to count the entries that were not modified - so the fact that it was not incremented before `continue` looks like an oversight. I'd say that Daniil is right. I believe Alan wrote that tool - he may be able to confirm ;-) That said - if we could do the same thing in java as Alan suggests and replace these shell scripts with java that might be a big win! best regards, -- daniel From boris.ulasevich at bell-sw.com Mon May 20 10:44:03 2019 From: boris.ulasevich at bell-sw.com (Boris Ulasevich) Date: Mon, 20 May 2019 13:44:03 +0300 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: The change is good. Thank you! regards, Boris On 20.05.2019 3:43, David Holmes wrote: > Hi Daniil, > > cc: Boris and Erik J. > > On 20/05/2019 7:12 am, Daniil Titov wrote: >> Please review the change that fixes the failure of >> sun/management/jmxremote/bootstrap JMX tests on Windows platform. >> While running, these tests invoke revokeall.exe utility and this >> utility hangs. >> >> The problem here is that invokeall.exe goes into an endless loop >> while iterating over Access Control Entries (ACE) for a given file if >> it encounters at least one ACE with the type different from >> ACCESS_ALLOWED_ACE_TYPE. >> >> The change fixes this problem.? It also removes revokeall.exe binary >> from the repository and changes the makefile? to get it built instead. >> >> Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap >> tests succeeded? in Mach5. >> >> Webrev: http://cr.openjdk.java.net/~dtitov/8214545 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > I knew this seemed very familiar ... Boris had a fix for this a few > weeks ago under JDK-8220581. Similar but not identical to yours - see > below. Though getting rid of the exe from the repo is a good idea > (thanks Erik!). > > A few comments > > test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Pre-existing: > > !???????? REVOKEALL="$TESTNATIVEPATH/revokeall.exe" > ????????? if [ ! -f "$REVOKEALL" ] ; then > > I would expect a -x test not -f. > > --- > > test/jdk/sun/management/windows/README > > The first copyright year should be 2004. > > ? 25 This directory contains the source and the binary version > > Delete "and the binary version". > > --- > > test/jdk/sun/management/windows/exerevokeall.c > > Pre-existing: > > ?31? * file - suitable for NT/2000/XP only. > > Please delete everything after "file". > > > ?355???????????? i++; > ?356???????????? count--; > > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic but > i is only incremented under very specific conditions. If you rewrote the > code to avoid the use of the continue then i would not be modified > except where it currently is. > > Thanks, > David > ----- > >> Thanks! >> --Daniil >> >> From boris.ulasevich at bell-sw.com Mon May 20 10:52:32 2019 From: boris.ulasevich at bell-sw.com (Boris Ulasevich) Date: Mon, 20 May 2019 13:52:32 +0300 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: On 20.05.2019 13:13, Daniel Fuchs wrote: > Hi, > > On 20/05/2019 01:43, David Holmes wrote: >>> Webrev: http://cr.openjdk.java.net/~dtitov/8214545 >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 >> The count-- is obvious as it is the loop counter, but it is far from >> clear to me that i++ is correct. I don't fully understand the logic >> but i is only incremented under very specific conditions. If you >> rewrote the code to avoid the use of the continue then i would not be >> modified except where it currently is. >> > > Looks like `i` tries to count the entries that were not > modified - so the fact that it was not incremented before > `continue` looks like an oversight. I'd say that Daniil is > right. There is iterating over list and changing it same time. It is common to iterate backward in such case to simplify logic. But this code is Ok for me too. > I believe Alan wrote that tool - he may be able to confirm ;-) > > That said - if we could do the same thing in java as Alan suggests > and replace these shell scripts with java that might be a big > win! > > best regards, > > -- daniel From erik.joelsson at oracle.com Mon May 20 15:24:55 2019 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 20 May 2019 08:24:55 -0700 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: Build changes look good. /Erik On 2019-05-19 17:43, David Holmes wrote: > Hi Daniil, > > cc: Boris and Erik J. > > On 20/05/2019 7:12 am, Daniil Titov wrote: >> Please review the change that fixes the failure of >> sun/management/jmxremote/bootstrap JMX tests on Windows platform.? >> While running, these tests invoke revokeall.exe utility and this >> utility hangs. >> >> The problem here is that invokeall.exe goes into an endless loop? >> while iterating over Access Control Entries (ACE) for a given file if >> it encounters at least one ACE with the type different from >> ACCESS_ALLOWED_ACE_TYPE. >> >> The change fixes this problem.? It also removes revokeall.exe binary >> from the repository and changes the makefile? to get it built instead. >> >> Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap? >> tests succeeded? in Mach5. >> >> Webrev: http://cr.openjdk.java.net/~dtitov/8214545 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > I knew this seemed very familiar ... Boris had a fix for this a few > weeks ago under JDK-8220581. Similar but not identical to yours - see > below. Though getting rid of the exe from the repo is a good idea > (thanks Erik!). > > A few comments > > test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Pre-existing: > > !???????? REVOKEALL="$TESTNATIVEPATH/revokeall.exe" > ????????? if [ ! -f "$REVOKEALL" ] ; then > > I would expect a -x test not -f. > > --- > > test/jdk/sun/management/windows/README > > The first copyright year should be 2004. > > ? 25 This directory contains the source and the binary version > > Delete "and the binary version". > > --- > > test/jdk/sun/management/windows/exerevokeall.c > > Pre-existing: > > ?31? * file - suitable for NT/2000/XP only. > > Please delete everything after "file". > > > ?355???????????? i++; > ?356???????????? count--; > > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic > but i is only incremented under very specific conditions. If you > rewrote the code to avoid the use of the continue then i would not be > modified except where it currently is. > > Thanks, > David > ----- > >> Thanks! >> --Daniil >> >> From daniil.x.titov at oracle.com Tue May 21 00:58:50 2019 From: daniil.x.titov at oracle.com (Daniil Titov) Date: Mon, 20 May 2019 17:58:50 -0700 Subject: jmx-dev 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <0eebc323-7c82-2a7c-0d3d-ae5488394bf2@oracle.com> References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> <0eebc323-7c82-2a7c-0d3d-ae5488394bf2@oracle.com> Message-ID: Hi Alan, I think it makes sense to put the work for replacing revokeall.exe utility with a Java code in a separate issue since the current issue is a quite urgent. I created a new issue for that https://bugs.openjdk.java.net/browse/JDK-8224255 Thanks! --Daniil ?On 5/19/19, 11:04 PM, "Alan Bateman" wrote: On 19/05/2019 22:12, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Have you looked at replacing the tool with code that uses the java.nio.file API? You can edit ACLs with that API. -Alan From daniil.x.titov at oracle.com Tue May 21 01:02:37 2019 From: daniil.x.titov at oracle.com (Daniil Titov) Date: Mon, 20 May 2019 18:02:37 -0700 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: <7929DFDE-28D1-4891-A8B9-D314D20E3CDD@oracle.com> Please review a new version of the fix that includes the changes David suggested. > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic We need to increment i on line 354: 353 if (((ACCESS_ALLOWED_ACE *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { 354 i++; 355 count--; 356 continue; 357 } since the code iterates over all ACE entries for a given file and deletes ones that grant non-owner access to the file. i is the index of the current ACE entry in the ACL structure. The current ACE entry is retrieved at the beginning of the loop: 349 if (!GetAce(acl, i, &ace)) { and the index is always incremented at the end of the loop unless the current entry is deleted. 382 if (!deleted) { 383 str = getSIDString(sid); 384 if (str != NULL) { 385 printf("ALLOW %s (access mask=%x)\n", str, access->Mask); 386 free(str); 387 } 388 389 /* onto the next ACE */ 390 i++; 391 } 392 count--; I also created a new issue to replace revokeall.exe with Java code as Alan suggested : https://bugs.openjdk.java.net/browse/JDK-8224255 Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Thanks! --Daniil ?On 5/19/19, 5:43 PM, "David Holmes" wrote: Hi Daniil, cc: Boris and Erik J. On 20/05/2019 7:12 am, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 I knew this seemed very familiar ... Boris had a fix for this a few weeks ago under JDK-8220581. Similar but not identical to yours - see below. Though getting rid of the exe from the repo is a good idea (thanks Erik!). A few comments test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh Pre-existing: ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" if [ ! -f "$REVOKEALL" ] ; then I would expect a -x test not -f. --- test/jdk/sun/management/windows/README The first copyright year should be 2004. 25 This directory contains the source and the binary version Delete "and the binary version". --- test/jdk/sun/management/windows/exerevokeall.c Pre-existing: 31 * file - suitable for NT/2000/XP only. Please delete everything after "file". 355 i++; 356 count--; The count-- is obvious as it is the loop counter, but it is far from clear to me that i++ is correct. I don't fully understand the logic but i is only incremented under very specific conditions. If you rewrote the code to avoid the use of the continue then i would not be modified except where it currently is. Thanks, David ----- > Thanks! > --Daniil > > From daniil.x.titov at oracle.com Tue May 21 03:25:00 2019 From: daniil.x.titov at oracle.com (Daniil Titov) Date: Mon, 20 May 2019 20:25:00 -0700 Subject: jmx-dev 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: Please review un updated version of the previous change that also removes unnecessary line chmod ug+x $REVOKEALL from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Thanks! --Daniil ?On 5/20/19, 6:02 PM, "serviceability-dev on behalf of Daniil Titov" wrote: Please review a new version of the fix that includes the changes David suggested. > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic We need to increment i on line 354: 353 if (((ACCESS_ALLOWED_ACE *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { 354 i++; 355 count--; 356 continue; 357 } since the code iterates over all ACE entries for a given file and deletes ones that grant non-owner access to the file. i is the index of the current ACE entry in the ACL structure. The current ACE entry is retrieved at the beginning of the loop: 349 if (!GetAce(acl, i, &ace)) { and the index is always incremented at the end of the loop unless the current entry is deleted. 382 if (!deleted) { 383 str = getSIDString(sid); 384 if (str != NULL) { 385 printf("ALLOW %s (access mask=%x)\n", str, access->Mask); 386 free(str); 387 } 388 389 /* onto the next ACE */ 390 i++; 391 } 392 count--; I also created a new issue to replace revokeall.exe with Java code as Alan suggested : https://bugs.openjdk.java.net/browse/JDK-8224255 Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Thanks! --Daniil ?On 5/19/19, 5:43 PM, "David Holmes" wrote: Hi Daniil, cc: Boris and Erik J. On 20/05/2019 7:12 am, Daniil Titov wrote: > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 I knew this seemed very familiar ... Boris had a fix for this a few weeks ago under JDK-8220581. Similar but not identical to yours - see below. Though getting rid of the exe from the repo is a good idea (thanks Erik!). A few comments test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh Pre-existing: ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" if [ ! -f "$REVOKEALL" ] ; then I would expect a -x test not -f. --- test/jdk/sun/management/windows/README The first copyright year should be 2004. 25 This directory contains the source and the binary version Delete "and the binary version". --- test/jdk/sun/management/windows/exerevokeall.c Pre-existing: 31 * file - suitable for NT/2000/XP only. Please delete everything after "file". 355 i++; 356 count--; The count-- is obvious as it is the loop counter, but it is far from clear to me that i++ is correct. I don't fully understand the logic but i is only incremented under very specific conditions. If you rewrote the code to avoid the use of the continue then i would not be modified except where it currently is. Thanks, David ----- > Thanks! > --Daniil > > From david.holmes at oracle.com Tue May 21 04:02:29 2019 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2019 14:02:29 +1000 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <7929DFDE-28D1-4891-A8B9-D314D20E3CDD@oracle.com> References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> <7929DFDE-28D1-4891-A8B9-D314D20E3CDD@oracle.com> Message-ID: Hi Daniil, I realize now that the test for -f rather than -x was likely because in the source bundle the exe file couldn't actually have the execute permission. So -f was correct then while -x should I hope be correct now. In which case you should be able to get rid of: chmod ug+x $REVOKEALL as well. But we'd need to be sure the execute bit is kept on the binary after its built and shipped around to other test machines. If in doubt restore the -f. Otherwise the updates look good. Thanks, David On 21/05/2019 11:02 am, Daniil Titov wrote: > Please review a new version of the fix that includes the changes David suggested. > > > The count-- is obvious as it is the loop counter, but it is far from > > clear to me that i++ is correct. I don't fully understand the logic > > We need to increment i on line 354: > > 353 if (((ACCESS_ALLOWED_ACE *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { > 354 i++; > 355 count--; > 356 continue; > 357 } > > since the code iterates over all ACE entries for a given file and deletes ones that grant non-owner access to the file. i is the index of the current ACE entry > in the ACL structure. The current ACE entry is retrieved at the beginning of the loop: > > 349 if (!GetAce(acl, i, &ace)) { > > > and the index is always incremented at the end of the loop unless the current entry is deleted. > > 382 if (!deleted) { > 383 str = getSIDString(sid); > 384 if (str != NULL) { > 385 printf("ALLOW %s (access mask=%x)\n", str, access->Mask); > 386 free(str); > 387 } > 388 > 389 /* onto the next ACE */ > 390 i++; > 391 } > 392 count--; > > > I also created a new issue to replace revokeall.exe with Java code as Alan suggested : https://bugs.openjdk.java.net/browse/JDK-8224255 > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > Thanks! > --Daniil > > > ?On 5/19/19, 5:43 PM, "David Holmes" wrote: > > Hi Daniil, > > cc: Boris and Erik J. > > On 20/05/2019 7:12 am, Daniil Titov wrote: > > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > I knew this seemed very familiar ... Boris had a fix for this a few > weeks ago under JDK-8220581. Similar but not identical to yours - see > below. Though getting rid of the exe from the repo is a good idea > (thanks Erik!). > > A few comments > > test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Pre-existing: > > ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" > if [ ! -f "$REVOKEALL" ] ; then > > I would expect a -x test not -f. > > --- > > test/jdk/sun/management/windows/README > > The first copyright year should be 2004. > > 25 This directory contains the source and the binary version > > Delete "and the binary version". > > --- > > test/jdk/sun/management/windows/exerevokeall.c > > Pre-existing: > > 31 * file - suitable for NT/2000/XP only. > > Please delete everything after "file". > > > 355 i++; > 356 count--; > > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic but > i is only incremented under very specific conditions. If you rewrote the > code to avoid the use of the continue then i would not be modified > except where it currently is. > > Thanks, > David > ----- > > > Thanks! > > --Daniil > > > > > > > From david.holmes at oracle.com Tue May 21 06:20:02 2019 From: david.holmes at oracle.com (David Holmes) Date: Tue, 21 May 2019 16:20:02 +1000 Subject: jmx-dev 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: Loosk good. Thanks, David On 21/05/2019 1:25 pm, Daniil Titov wrote: > Please review un updated version of the previous change that also removes unnecessary line > > chmod ug+x $REVOKEALL > > from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > Thanks! > --Daniil > > ?On 5/20/19, 6:02 PM, "serviceability-dev on behalf of Daniil Titov" wrote: > > Please review a new version of the fix that includes the changes David suggested. > > > The count-- is obvious as it is the loop counter, but it is far from > > clear to me that i++ is correct. I don't fully understand the logic > > We need to increment i on line 354: > > 353 if (((ACCESS_ALLOWED_ACE *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { > 354 i++; > 355 count--; > 356 continue; > 357 } > > since the code iterates over all ACE entries for a given file and deletes ones that grant non-owner access to the file. i is the index of the current ACE entry > in the ACL structure. The current ACE entry is retrieved at the beginning of the loop: > > 349 if (!GetAce(acl, i, &ace)) { > > > and the index is always incremented at the end of the loop unless the current entry is deleted. > > 382 if (!deleted) { > 383 str = getSIDString(sid); > 384 if (str != NULL) { > 385 printf("ALLOW %s (access mask=%x)\n", str, access->Mask); > 386 free(str); > 387 } > 388 > 389 /* onto the next ACE */ > 390 i++; > 391 } > 392 count--; > > > I also created a new issue to replace revokeall.exe with Java code as Alan suggested : https://bugs.openjdk.java.net/browse/JDK-8224255 > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > Thanks! > --Daniil > > > ?On 5/19/19, 5:43 PM, "David Holmes" wrote: > > Hi Daniil, > > cc: Boris and Erik J. > > On 20/05/2019 7:12 am, Daniil Titov wrote: > > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > I knew this seemed very familiar ... Boris had a fix for this a few > weeks ago under JDK-8220581. Similar but not identical to yours - see > below. Though getting rid of the exe from the repo is a good idea > (thanks Erik!). > > A few comments > > test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Pre-existing: > > ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" > if [ ! -f "$REVOKEALL" ] ; then > > I would expect a -x test not -f. > > --- > > test/jdk/sun/management/windows/README > > The first copyright year should be 2004. > > 25 This directory contains the source and the binary version > > Delete "and the binary version". > > --- > > test/jdk/sun/management/windows/exerevokeall.c > > Pre-existing: > > 31 * file - suitable for NT/2000/XP only. > > Please delete everything after "file". > > > 355 i++; > 356 count--; > > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic but > i is only incremented under very specific conditions. If you rewrote the > code to avoid the use of the continue then i would not be modified > except where it currently is. > > Thanks, > David > ----- > > > Thanks! > > --Daniil > > > > > > > > > > > From alexey.menkov at oracle.com Tue May 21 01:15:04 2019 From: alexey.menkov at oracle.com (Alex Menkov) Date: Mon, 20 May 2019 18:15:04 -0700 Subject: jmx-dev RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <7929DFDE-28D1-4891-A8B9-D314D20E3CDD@oracle.com> References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> <7929DFDE-28D1-4891-A8B9-D314D20E3CDD@oracle.com> Message-ID: <22f24d90-2677-9686-f68c-700e84edf333@oracle.com> LGTM --alex On 05/20/2019 18:02, Daniil Titov wrote: > Please review a new version of the fix that includes the changes David suggested. > > > The count-- is obvious as it is the loop counter, but it is far from > > clear to me that i++ is correct. I don't fully understand the logic > > We need to increment i on line 354: > > 353 if (((ACCESS_ALLOWED_ACE *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { > 354 i++; > 355 count--; > 356 continue; > 357 } > > since the code iterates over all ACE entries for a given file and deletes ones that grant non-owner access to the file. i is the index of the current ACE entry > in the ACL structure. The current ACE entry is retrieved at the beginning of the loop: > > 349 if (!GetAce(acl, i, &ace)) { > > > and the index is always incremented at the end of the loop unless the current entry is deleted. > > 382 if (!deleted) { > 383 str = getSIDString(sid); > 384 if (str != NULL) { > 385 printf("ALLOW %s (access mask=%x)\n", str, access->Mask); > 386 free(str); > 387 } > 388 > 389 /* onto the next ACE */ > 390 i++; > 391 } > 392 count--; > > > I also created a new issue to replace revokeall.exe with Java code as Alan suggested : https://bugs.openjdk.java.net/browse/JDK-8224255 > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > Thanks! > --Daniil > > > ?On 5/19/19, 5:43 PM, "David Holmes" wrote: > > Hi Daniil, > > cc: Boris and Erik J. > > On 20/05/2019 7:12 am, Daniil Titov wrote: > > Please review the change that fixes the failure of sun/management/jmxremote/bootstrap JMX tests on Windows platform. While running, these tests invoke revokeall.exe utility and this utility hangs. > > > > The problem here is that invokeall.exe goes into an endless loop while iterating over Access Control Entries (ACE) for a given file if it encounters at least one ACE with the type different from ACCESS_ALLOWED_ACE_TYPE. > > > > The change fixes this problem. It also removes revokeall.exe binary from the repository and changes the makefile to get it built instead. > > > > Tier1, tier2, tier3, jdk_svc, and sun/management/jmxremote/bootstrap tests succeeded in Mach5. > > > > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > > I knew this seemed very familiar ... Boris had a fix for this a few > weeks ago under JDK-8220581. Similar but not identical to yours - see > below. Though getting rid of the exe from the repo is a good idea > (thanks Erik!). > > A few comments > > test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Pre-existing: > > ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" > if [ ! -f "$REVOKEALL" ] ; then > > I would expect a -x test not -f. > > --- > > test/jdk/sun/management/windows/README > > The first copyright year should be 2004. > > 25 This directory contains the source and the binary version > > Delete "and the binary version". > > --- > > test/jdk/sun/management/windows/exerevokeall.c > > Pre-existing: > > 31 * file - suitable for NT/2000/XP only. > > Please delete everything after "file". > > > 355 i++; > 356 count--; > > The count-- is obvious as it is the loop counter, but it is far from > clear to me that i++ is correct. I don't fully understand the logic but > i is only incremented under very specific conditions. If you rewrote the > code to avoid the use of the continue then i would not be modified > except where it currently is. > > Thanks, > David > ----- > > > Thanks! > > --Daniil > > > > > > > From daniel.fuchs at oracle.com Tue May 21 09:04:56 2019 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 21 May 2019 10:04:56 +0100 Subject: jmx-dev 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: <440dab5e-090a-adb4-0caa-a035059611b4@oracle.com> On 21/05/2019 04:25, Daniil Titov wrote: > Please review un updated version of the previous change that also removes unnecessary line > > chmod ug+x $REVOKEALL > > from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh > > Webrev:http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 > Bug:https://bugs.openjdk.java.net/browse/JDK-8214545 Looks good to me as well. best regards, -- daniel From serguei.spitsyn at oracle.com Wed May 22 18:46:58 2019 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 22 May 2019 11:46:58 -0700 Subject: jmx-dev 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: References: <00C8E0C5-D10E-4B96-9FD3-41693CF77C97@oracle.com> Message-ID: <44b57cb9-e0bb-db3a-3fb4-2b7e1d7d32ac@oracle.com> Hi Daniil, +1 Thanks, Serguei On 5/20/19 23:20, David Holmes wrote: > Loosk good. > > Thanks, > David > > On 21/05/2019 1:25 pm, Daniil Titov wrote: >> Please review un updated version of the previous change that also >> removes unnecessary line >> >> chmod ug+x $REVOKEALL >> >> from >> test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >> >> Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 >> ???? Thanks! >> --Daniil >> >> ?On 5/20/19, 6:02 PM, "serviceability-dev on behalf of Daniil Titov" >> > daniil.x.titov at oracle.com> wrote: >> >> ???? Please review a new version of the fix that includes the changes >> David suggested. >> ???? ????? > The count-- is obvious as it is the loop counter, but it >> is far from >> ????? >? clear to me that i++ is correct. I don't fully understand >> the logic >> ???? ???? We need to increment i on line 354: >> ???? ????? 353???????? if (((ACCESS_ALLOWED_ACE >> *)ace)->Header.AceType != ACCESS_ALLOWED_ACE_TYPE) { >> ????? 354???????????? i++; >> ????? 355???????????? count--; >> ????? 356???????????? continue; >> ????? 357???????? } >> ???? ???? since the code iterates over all ACE entries for a given >> file and deletes ones that grant non-owner access to the file.? i is >> the index of the current ACE entry >> ???? in the ACL structure. The current ACE entry is retrieved at the >> beginning of the loop: >> ???? ???? 349???????? if (!GetAce(acl, i, &ace)) { >> ???? ???? ???? and the index is always incremented at the end of the >> loop unless the current entry is deleted. >> ???? ???? 382???????? if (!deleted) { >> ????? 383???????????? str = getSIDString(sid); >> ????? 384???????????? if (str != NULL) { >> ????? 385???????????????? printf("ALLOW %s (access mask=%x)\n", str, >> access->Mask); >> ????? 386???????????????? free(str); >> ????? 387???????????? } >> ????? 388 >> ????? 389???????????? /* onto the next ACE */ >> ????? 390???????????? i++; >> ????? 391???????? } >> ????? 392???????? count--; >> ???? ???? ???? I also created a new issue to replace revokeall.exe >> with Java code as Alan suggested : >> https://bugs.openjdk.java.net/browse/JDK-8224255 >> ???? ???? ???? Webrev: >> http://cr.openjdk.java.net/~dtitov/8214545/webrev.02 >> ???? Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 >> ???? ???? Thanks! >> ???? --Daniil >> ???? ???? ???? ?On 5/19/19, 5:43 PM, "David Holmes" >> wrote: >> ???? ???????? Hi Daniil, >> ???????? ???????? cc: Boris and Erik J. >> ???????? ???????? On 20/05/2019 7:12 am, Daniil Titov wrote: >> ???????? > Please review the change that fixes the failure of >> sun/management/jmxremote/bootstrap JMX tests on Windows platform.? >> While running, these tests invoke revokeall.exe utility and this >> utility hangs. >> ???????? > >> ???????? > The problem here is that invokeall.exe goes into an >> endless loop? while iterating over Access Control Entries (ACE) for a >> given file if it encounters at least one ACE with the type different >> from ACCESS_ALLOWED_ACE_TYPE. >> ???????? > >> ???????? > The change fixes this problem.? It also removes >> revokeall.exe binary from the repository and changes the makefile? to >> get it built instead. >> ???????? > >> ???????? > Tier1, tier2, tier3, jdk_svc, and >> sun/management/jmxremote/bootstrap? tests succeeded? in Mach5. >> ???????? > >> ???????? > Webrev: http://cr.openjdk.java.net/~dtitov/8214545 >> ???????? > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 >> ???????? ???????? I knew this seemed very familiar ... Boris had a >> fix for this a few >> ???????? weeks ago under JDK-8220581. Similar but not identical to >> yours - see >> ???????? below. Though getting rid of the exe from the repo is a good >> idea >> ???????? (thanks Erik!). >> ???????? ???????? A few comments >> test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh >> ???????? ???????? Pre-existing: >> ???????? ???????? ! REVOKEALL="$TESTNATIVEPATH/revokeall.exe" >> ??????????????????? if [ ! -f "$REVOKEALL" ] ; then >> ???????? ???????? I would expect a -x test not -f. >> ???????? ???????? --- >> ???????? ???????? test/jdk/sun/management/windows/README >> ???????? ???????? The first copyright year should be 2004. >> ???????? ??????????? 25 This directory contains the source and the >> binary version >> ???????? ???????? Delete "and the binary version". >> ???????? ???????? --- >> ???????? ???????? test/jdk/sun/management/windows/exerevokeall.c >> ???????? ???????? Pre-existing: >> ???????? ?????????? 31? * file - suitable for NT/2000/XP only. >> ???????? ???????? Please delete everything after "file". >> ???????? ???????? ?????????? 355???????????? i++; >> ?????????? 356???????????? count--; >> ???????? ???????? The count-- is obvious as it is the loop counter, >> but it is far from >> ???????? clear to me that i++ is correct. I don't fully understand >> the logic but >> ???????? i is only incremented under very specific conditions. If you >> rewrote the >> ???????? code to avoid the use of the continue then i would not be >> modified >> ???????? except where it currently is. >> ???????? ???????? Thanks, >> ???????? David >> ???????? ----- >> ???????? ???????? > Thanks! >> ???????? > --Daniil >> ???????? > >> ???????? > >> >> From daniil.x.titov at oracle.com Fri May 24 01:22:31 2019 From: daniil.x.titov at oracle.com (Daniil Titov) Date: Thu, 23 May 2019 18:22:31 -0700 Subject: jmx-dev [12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows Message-ID: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> Please review the backport of this fix to JDK 12. The JDK 12 changes applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply because of changed context lines. That's the only difference. Webrev: http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 Main webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 Testing: sun/management/jmxremote/bootstrap, jdk_svc, tier1, tier2 and tier3 tests succeeded. Thanks! --Daniil From david.holmes at oracle.com Fri May 24 02:21:02 2019 From: david.holmes at oracle.com (David Holmes) Date: Fri, 24 May 2019 12:21:02 +1000 Subject: jmx-dev [12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> References: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> Message-ID: <596bff81-01fb-eb8b-a38a-a7e4866198db@oracle.com> Looks good. Thanks, David On 24/05/2019 11:22 am, Daniil Titov wrote: > Please review the backport of this fix to JDK 12. The JDK 12 changes applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply because of changed context lines. That's the only difference. > > Webrev: http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > Main webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 > > Testing: sun/management/jmxremote/bootstrap, jdk_svc, tier1, tier2 and tier3 tests succeeded. > > Thanks! > --Daniil > > > From serguei.spitsyn at oracle.com Fri May 24 09:55:48 2019 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 24 May 2019 02:55:48 -0700 Subject: jmx-dev [12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> References: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> Message-ID: <3d42ce70-852b-7b02-1f40-ff7063a9ec77@oracle.com> Hi Daniil, The fix has been applied cleanly. LGTM++ Thanks, Serguei On 5/23/19 18:22, Daniil Titov wrote: > Please review the backport of this fix to JDK 12. The JDK 12 changes applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply because of changed context lines. That's the only difference. > > Webrev: http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 > Main webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 > > Testing: sun/management/jmxremote/bootstrap, jdk_svc, tier1, tier2 and tier3 tests succeeded. > > Thanks! > --Daniil > > > From alexey.menkov at oracle.com Fri May 24 19:25:52 2019 From: alexey.menkov at oracle.com (Alex Menkov) Date: Fri, 24 May 2019 12:25:52 -0700 Subject: jmx-dev [12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows In-Reply-To: <3d42ce70-852b-7b02-1f40-ff7063a9ec77@oracle.com> References: <7C47A712-8750-4D3D-B6EF-A2605D14B1EB@oracle.com> <3d42ce70-852b-7b02-1f40-ff7063a9ec77@oracle.com> Message-ID: <3f63e2eb-5a9a-9705-39d0-c9a4bf0bd293@oracle.com> +1 --alex On 05/24/2019 02:55, serguei.spitsyn at oracle.com wrote: > Hi Daniil, > > The fix has been applied cleanly. > LGTM++ > > Thanks, > Serguei > > On 5/23/19 18:22, Daniil Titov wrote: >> Please review the backport of this fix to JDK 12. The JDK 12 changes >> applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk >> didn't apply because of changed context lines. That's the only >> difference. >> >> Webrev: >> http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/ >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214545 >> Main webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03 >> >> Testing: sun/management/jmxremote/bootstrap, jdk_svc, tier1, tier2 and >> tier3 tests succeeded. >> >> Thanks! >> --Daniil >> >> >> >