From shade at openjdk.java.net  Thu Dec  3 18:34:08 2020
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Thu, 3 Dec 2020 18:34:08 GMT
Subject: jmx-dev RFR: 8257708: Remove redundant unmodifiableSet wrapper
 from already immutable set returned by Collections.singleton
In-Reply-To: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
References: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
Message-ID: <KkM4hQu-pMTqLoxYW2g8ZBpWsK2jqfd4EV7wEgPD4yE=.1bff25cd-e20d-47d7-8530-5027ceeaff3e@github.com>

On Sun, 29 Nov 2020 18:03:24 GMT, Turbanov Andrey <github.com+741251+turbanoff at openjdk.org> wrote:

> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Changes requested by shade (Reviewer).

Submitted -- https://bugs.openjdk.java.net/browse/JDK-8257708, rename this PR to "8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton" to get it hooked up.

src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java line 60:

> 58:             private final Set<String> classLoadingInterfaceNames =
> 59:                     Collections.singleton(
> 60:                             "java.lang.management.ClassLoadingMXBean");

Here and later, I think we can avoid awkward newlines: `Collections.singleton("java.lang...")`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1505

From github.com+741251+turbanoff at openjdk.java.net  Thu Dec  3 18:34:07 2020
From: github.com+741251+turbanoff at openjdk.java.net (Turbanov Andrey)
Date: Thu, 3 Dec 2020 18:34:07 GMT
Subject: jmx-dev RFR: 8257708: Remove redundant unmodifiableSet wrapper from
 already immutable set returned by Collections.singleton
Message-ID: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>

8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

-------------

Commit messages:
 - 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton
 - [PATCH] Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Changes: https://git.openjdk.java.net/jdk/pull/1505/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1505&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257708
  Stats: 26 lines in 2 files changed: 0 ins; 12 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1505.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1505/head:pull/1505

PR: https://git.openjdk.java.net/jdk/pull/1505

From sspitsyn at openjdk.java.net  Thu Dec  3 20:54:55 2020
From: sspitsyn at openjdk.java.net (Serguei Spitsyn)
Date: Thu, 3 Dec 2020 20:54:55 GMT
Subject: jmx-dev RFR: 8257708: Remove redundant unmodifiableSet wrapper
 from already immutable set returned by Collections.singleton
In-Reply-To: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
References: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
Message-ID: <CUcVOXdy2j9KGdfaWVcyGtp5aGLB0KPfJFRBCltqo9c=.0f74f0f8-aed0-4bba-a9a4-ba89961ec37d@github.com>

On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Hi Andrey,
It looks good - nice simplification.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1505

From github.com+741251+turbanoff at openjdk.java.net  Fri Dec  4 06:34:55 2020
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Fri, 4 Dec 2020 06:34:55 GMT
Subject: jmx-dev Integrated: 8257708: Remove redundant unmodifiableSet
 wrapper from already immutable set returned by Collections.singleton
In-Reply-To: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
References: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
Message-ID: <bnrXa3HuX-heyUdWeHztA6nop9NtXSqZ0N4GVdE6TP8=.8dd7809b-f769-4f3f-a39b-43a64b286165@github.com>

On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

This pull request has now been integrated.

Changeset: d08c612b
Author:    Andrey Turbanov <turbanoff at gmail.com>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d08c612b
Stats:     26 lines in 2 files changed: 0 ins; 12 del; 14 mod

8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Reviewed-by: shade, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/1505

From shade at openjdk.java.net  Fri Dec  4 06:34:54 2020
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 4 Dec 2020 06:34:54 GMT
Subject: jmx-dev RFR: 8257708: Remove redundant unmodifiableSet wrapper
 from already immutable set returned by Collections.singleton
In-Reply-To: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
References: <Dqni0gmwBBrO30OgDEtag3_hyqhg4yryBjIa0thxYFU=.1f087dd5-274e-4f19-a711-b47585ef9626@github.com>
Message-ID: <B8xYBUbB5U0BBNqJF3DFW2K5FciFGOOY1qWKX5Gx7l8=.e1b24612-fa46-494d-8eec-0491339aa420@github.com>

On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Looks good now!

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1505

From dlsmith at openjdk.java.net  Sat Dec  5 01:52:21 2020
From: dlsmith at openjdk.java.net (Dan Smith)
Date: Sat, 5 Dec 2020 01:52:21 GMT
Subject: jmx-dev RFR: 8252180: [JEP 390] Deprecate wrapper class
 constructors for removal
Message-ID: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>

Integration of JEP 390, addressing the following issues:

8252180: [JEP 390] Deprecate wrapper class constructors for removal
8254047: [JEP 390] Revise "value-based class" & apply to wrappers
8252181: [JEP 390] Define & apply annotation jdk.internal.ValueBased
8252183: [JEP 390] Add 'lint' warning for @ValueBased classes
8257027: [JEP 390] Diagnose synchronization on @ValueBased classes

See https://github.com/openjdk/valhalla/tree/jep390 for development history.

-------------

Commit messages:
 - Merge
 - 8257776: [valhalla:jep390] Add disclaimer about future changes to value-based classes
 - 8254275: [valhalla/jep390] Revise "value-based class" & apply to wrappers
 - 8252182: [JEP 390] Diagnose synchronization on @ValueBased classes
 - Merge
 - 8256663: [test] Deprecated use of new Double in jshell ImportTest
 - 8253962: Add @ValueBased to unmodifable Collection implementation classes
 - 8256002: Cleanup of Wrapper changes
 - Merge
 - 8254271: Development to deprecate wrapper class constructors for removal
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/93b6ab56...7c5e5bfe

Changes: https://git.openjdk.java.net/jdk/pull/1636/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1636&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252180
  Stats: 902 lines in 114 files changed: 489 ins; 121 del; 292 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1636.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1636/head:pull/1636

PR: https://git.openjdk.java.net/jdk/pull/1636

From dlsmith at openjdk.java.net  Sat Dec  5 03:07:11 2020
From: dlsmith at openjdk.java.net (Dan Smith)
Date: Sat, 5 Dec 2020 03:07:11 GMT
Subject: jmx-dev RFR: 8252180: [JEP 390] Deprecate wrapper class
 constructors for removal
In-Reply-To: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
References: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
Message-ID: <ame4i0yLoLSpT6rwqcO20lQzYRBLR9FiyD7EKHAKltA=.b12c8d8b-e470-45df-bb0c-1f7330be9545@github.com>

On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
> 
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal
> - Revise "value-based class" & apply to wrappers
> - Define & apply annotation jdk.internal.ValueBased
> - Add 'lint' warning for @ValueBased classes
> - Diagnose synchronization on @ValueBased classes
> 
> All changes have been previously reviewed and integrated into the [`jep390` branch](https://github.com/openjdk/valhalla/tree/jep390) of the `valhalla` repository. See the subtasks of the 5 JBS issues for these changes, including discussion and links to reviews. (Reviewers: mchung, dlsmith, jlaskey, rriggs, lfoltan, fparain, hseigel.)
> 
> CSRs have also been completed or are nearly complete:
> 
> - [JDK-8254324](https://bugs.openjdk.java.net/browse/JDK-8254324) for wrapper class constructor deprecation
> - [JDK-8254944](https://bugs.openjdk.java.net/browse/JDK-8254944) for revisions to "value-based class"
> - [JDK-8256023](https://bugs.openjdk.java.net/browse/JDK-8256023) for new `javac` lint warnings
> 
> Here's an overview of the files changed:
> 
> - `src/hotspot`: implementing diagnostics when `monitorenter` is applied to an instance of a class tagged with `jdk.internal.ValueBased`. This enhances previous work that produced such diagnostics for the primitive wrapper classes.
> 
> - `src/java.base/share/classes/java/lang`: deprecating for removal the wrapper class constructors; revising the definition of "value-based class" in `ValueBased.html` and the description used by linking classes; applying "value-based class" to the primitive wrapper classes; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/lang/constant`: no longer designating these classes as "value-based", since they rely heavily on field inheritance.
> 
> - `src/java.base/share/classes/java/time`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/util`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/jdk/internal`: define the `@jdk.internal.ValueBased` annotation.
> 
> - `src/java.management.rmi`: removing uses of wrapper class constructors.
> 
> - `src/java.xml`: removing uses of wrapper class constructors.
> 
> - `src/jdk.compiler`: implementing the `synchronization` lint category, which reports attempts to synchronize on classes and interfaces annotated with `@jdk.internal.ValueBased`.
> 
> - `src/jdk.incubator.foreign`: revising the description used to link to `ValueBased.html`. (Applying `@jdk.internal.ValueBased` would require a special module export, which was not deemed necessary for an incubating API.)
> 
> - `src/jdk.internal.vm.compiler`: suppressing `javac` deprecation and synchronization warnings in tests
> 
> - `src/jdk.jfr`: supplementary changes for HotSpot diagnostics
> 
> - `test`: testing new `javac` and HotSpot behavior; removing usages of deprecated wrapper class constructors from tests, or suppressing deprecation warnings; revising the description used to link to `ValueBased.html`.

I've updated the description to provide an overview for those unfamiliar with this work. Reviewers are welcome, including those who have previously reviewed a subset of these changes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1636

From rriggs at openjdk.java.net  Mon Dec  7 15:08:12 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Mon, 7 Dec 2020 15:08:12 GMT
Subject: jmx-dev RFR: 8252180: [JEP 390] Deprecate wrapper class
 constructors for removal
In-Reply-To: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
References: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
Message-ID: <Fl-cWTaz17dK2mrEvx318D5ScjkL-up3gtWVzo9x9d4=.83b8febf-1f03-43f6-b836-b44c648e5801@github.com>

On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
> 
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class" & apply to wrappers (dlsmith)
> - Define & apply annotation jdk.internal.ValueBased (rriggs)
> - Add 'lint' warning for @ValueBased classes (sadayapalam)
> - Diagnose synchronization on @ValueBased classes (lfoltan)
> 
> All changes have been previously reviewed and integrated into the [`jep390` branch](https://github.com/openjdk/valhalla/tree/jep390) of the `valhalla` repository. See the subtasks of the 5 JBS issues for these changes, including discussion and links to reviews. (Reviewers: mchung, dlsmith, jlaskey, rriggs, lfoltan, fparain, hseigel.)
> 
> CSRs have also been completed or are nearly complete:
> 
> - [JDK-8254324](https://bugs.openjdk.java.net/browse/JDK-8254324) for wrapper class constructor deprecation
> - [JDK-8254944](https://bugs.openjdk.java.net/browse/JDK-8254944) for revisions to "value-based class"
> - [JDK-8256023](https://bugs.openjdk.java.net/browse/JDK-8256023) for new `javac` lint warnings
> 
> Here's an overview of the files changed:
> 
> - `src/hotspot`: implementing diagnostics when `monitorenter` is applied to an instance of a class tagged with `jdk.internal.ValueBased`. This enhances previous work that produced such diagnostics for the primitive wrapper classes.
> 
> - `src/java.base/share/classes/java/lang`: deprecating for removal the wrapper class constructors; revising the definition of "value-based class" in `ValueBased.html` and the description used by linking classes; applying "value-based class" to the primitive wrapper classes; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/lang/constant`: no longer designating these classes as "value-based", since they rely heavily on field inheritance.
> 
> - `src/java.base/share/classes/java/time`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/util`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/jdk/internal`: define the `@jdk.internal.ValueBased` annotation.
> 
> - `src/java.management.rmi`: removing uses of wrapper class constructors.
> 
> - `src/java.xml`: removing uses of wrapper class constructors.
> 
> - `src/jdk.compiler`: implementing the `synchronization` lint category, which reports attempts to synchronize on classes and interfaces annotated with `@jdk.internal.ValueBased`.
> 
> - `src/jdk.incubator.foreign`: revising the description used to link to `ValueBased.html`. (Applying `@jdk.internal.ValueBased` would require a special module export, which was not deemed necessary for an incubating API.)
> 
> - `src/jdk.internal.vm.compiler`: suppressing `javac` deprecation and synchronization warnings in tests
> 
> - `src/jdk.jfr`: supplementary changes for HotSpot diagnostics
> 
> - `test`: testing new `javac` and HotSpot behavior; removing usages of deprecated wrapper class constructors from tests, or suppressing deprecation warnings; revising the description used to link to `ValueBased.html`.

For the core libraries parts looks ok.

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1636

From hseigel at openjdk.java.net  Mon Dec  7 15:53:14 2020
From: hseigel at openjdk.java.net (Harold Seigel)
Date: Mon, 7 Dec 2020 15:53:14 GMT
Subject: jmx-dev RFR: 8252180: [JEP 390] Deprecate wrapper class
 constructors for removal
In-Reply-To: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
References: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
Message-ID: <DBXljSbfnxVvTWaB3vWYuroiHOTlz8ZVqocZR4JffNw=.1fbca489-56da-4190-ad5a-2fd42512ff59@github.com>

On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
> 
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class" & apply to wrappers (dlsmith)
> - Define & apply annotation jdk.internal.ValueBased (rriggs)
> - Add 'lint' warning for @ValueBased classes (sadayapalam)
> - Diagnose synchronization on @ValueBased classes (lfoltan)
> 
> All changes have been previously reviewed and integrated into the [`jep390` branch](https://github.com/openjdk/valhalla/tree/jep390) of the `valhalla` repository. See the subtasks of the 5 JBS issues for these changes, including discussion and links to reviews. (Reviewers: mchung, dlsmith, jlaskey, rriggs, lfoltan, fparain, hseigel.)
> 
> CSRs have also been completed or are nearly complete:
> 
> - [JDK-8254324](https://bugs.openjdk.java.net/browse/JDK-8254324) for wrapper class constructor deprecation
> - [JDK-8254944](https://bugs.openjdk.java.net/browse/JDK-8254944) for revisions to "value-based class"
> - [JDK-8256023](https://bugs.openjdk.java.net/browse/JDK-8256023) for new `javac` lint warnings
> 
> Here's an overview of the files changed:
> 
> - `src/hotspot`: implementing diagnostics when `monitorenter` is applied to an instance of a class tagged with `jdk.internal.ValueBased`. This enhances previous work that produced such diagnostics for the primitive wrapper classes.
> 
> - `src/java.base/share/classes/java/lang`: deprecating for removal the wrapper class constructors; revising the definition of "value-based class" in `ValueBased.html` and the description used by linking classes; applying "value-based class" to the primitive wrapper classes; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/lang/constant`: no longer designating these classes as "value-based", since they rely heavily on field inheritance.
> 
> - `src/java.base/share/classes/java/time`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/java/util`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
> 
> - `src/java.base/share/classes/jdk/internal`: define the `@jdk.internal.ValueBased` annotation.
> 
> - `src/java.management.rmi`: removing uses of wrapper class constructors.
> 
> - `src/java.xml`: removing uses of wrapper class constructors.
> 
> - `src/jdk.compiler`: implementing the `synchronization` lint category, which reports attempts to synchronize on classes and interfaces annotated with `@jdk.internal.ValueBased`.
> 
> - `src/jdk.incubator.foreign`: revising the description used to link to `ValueBased.html`. (Applying `@jdk.internal.ValueBased` would require a special module export, which was not deemed necessary for an incubating API.)
> 
> - `src/jdk.internal.vm.compiler`: suppressing `javac` deprecation and synchronization warnings in tests
> 
> - `src/jdk.jfr`: supplementary changes for HotSpot diagnostics
> 
> - `test`: testing new `javac` and HotSpot behavior; removing usages of deprecated wrapper class constructors from tests, or suppressing deprecation warnings; revising the description used to link to `ValueBased.html`.

The hotspot changes look good.  In a future change, could you add additional classes, such as ProcessHandle to test TestSyncOnValueBasedClassEvent.  Currently, it only tests primitive classes.

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1636

From lfoltan at openjdk.java.net  Mon Dec  7 16:25:13 2020
From: lfoltan at openjdk.java.net (Lois Foltan)
Date: Mon, 7 Dec 2020 16:25:13 GMT
Subject: jmx-dev RFR: 8252180: [JEP 390] Deprecate wrapper class
 constructors for removal
In-Reply-To: <DBXljSbfnxVvTWaB3vWYuroiHOTlz8ZVqocZR4JffNw=.1fbca489-56da-4190-ad5a-2fd42512ff59@github.com>
References: <14WC4YuIN1sJ3jl5_htTC7wkzyzjpt540r7tmEQ85Lc=.4c5ac2b3-d24a-4aae-886b-b07e671f2948@github.com>
 <DBXljSbfnxVvTWaB3vWYuroiHOTlz8ZVqocZR4JffNw=.1fbca489-56da-4190-ad5a-2fd42512ff59@github.com>
Message-ID: <daRqe8BueKkQgPH9tjRo4guncvyjbw6wdG6szQDOXgY=.be84a3cc-ec84-47c6-8633-19206ee7525b@github.com>

On Mon, 7 Dec 2020 15:50:55 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>> 
>> Development has been broken into 5 tasks, each with its own JBS issue:
>> - Deprecate wrapper class constructors for removal (rriggs)
>> - Revise "value-based class" & apply to wrappers (dlsmith)
>> - Define & apply annotation jdk.internal.ValueBased (rriggs)
>> - Add 'lint' warning for @ValueBased classes (sadayapalam)
>> - Diagnose synchronization on @ValueBased classes (lfoltan)
>> 
>> All changes have been previously reviewed and integrated into the [`jep390` branch](https://github.com/openjdk/valhalla/tree/jep390) of the `valhalla` repository. See the subtasks of the 5 JBS issues for these changes, including discussion and links to reviews. (Reviewers: mchung, dlsmith, jlaskey, rriggs, lfoltan, fparain, hseigel.)
>> 
>> CSRs have also been completed or are nearly complete:
>> 
>> - [JDK-8254324](https://bugs.openjdk.java.net/browse/JDK-8254324) for wrapper class constructor deprecation
>> - [JDK-8254944](https://bugs.openjdk.java.net/browse/JDK-8254944) for revisions to "value-based class"
>> - [JDK-8256023](https://bugs.openjdk.java.net/browse/JDK-8256023) for new `javac` lint warnings
>> 
>> Here's an overview of the files changed:
>> 
>> - `src/hotspot`: implementing diagnostics when `monitorenter` is applied to an instance of a class tagged with `jdk.internal.ValueBased`. This enhances previous work that produced such diagnostics for the primitive wrapper classes.
>> 
>> - `src/java.base/share/classes/java/lang`: deprecating for removal the wrapper class constructors; revising the definition of "value-based class" in `ValueBased.html` and the description used by linking classes; applying "value-based class" to the primitive wrapper classes; marking value-based classes with `@jdk.internal.ValueBased`.
>> 
>> - `src/java.base/share/classes/java/lang/constant`: no longer designating these classes as "value-based", since they rely heavily on field inheritance.
>> 
>> - `src/java.base/share/classes/java/time`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
>> 
>> - `src/java.base/share/classes/java/util`: revising the description used to link to `ValueBased.html`; marking value-based classes with `@jdk.internal.ValueBased`.
>> 
>> - `src/java.base/share/classes/jdk/internal`: define the `@jdk.internal.ValueBased` annotation.
>> 
>> - `src/java.management.rmi`: removing uses of wrapper class constructors.
>> 
>> - `src/java.xml`: removing uses of wrapper class constructors.
>> 
>> - `src/jdk.compiler`: implementing the `synchronization` lint category, which reports attempts to synchronize on classes and interfaces annotated with `@jdk.internal.ValueBased`.
>> 
>> - `src/jdk.incubator.foreign`: revising the description used to link to `ValueBased.html`. (Applying `@jdk.internal.ValueBased` would require a special module export, which was not deemed necessary for an incubating API.)
>> 
>> - `src/jdk.internal.vm.compiler`: suppressing `javac` deprecation and synchronization warnings in tests
>> 
>> - `src/jdk.jfr`: supplementary changes for HotSpot diagnostics
>> 
>> - `test`: testing new `javac` and HotSpot behavior; removing usages of deprecated wrapper class constructors from tests, or suppressing deprecation warnings; revising the description used to link to `ValueBased.html`.
>
> The hotspot changes look good.  In a future change, could you add additional classes, such as ProcessHandle to test TestSyncOnValueBasedClassEvent.  Currently, it only tests primitive classes.

@hseigel thank you for the review.  I have created https://bugs.openjdk.java.net/browse/JDK-8257836 as an RFE to address additional testing.
Lois

-------------

PR: https://git.openjdk.java.net/jdk/pull/1636

From bchristi at openjdk.java.net  Mon Dec 14 19:41:05 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Mon, 14 Dec 2020 19:41:05 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
Message-ID: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>

This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).

Here are the changes covering core libraries code and tests.  Terms were changed as follows:
1. grandfathered -> legacy
2. blacklist -> filter or reject
3. whitelist -> allow or accept
4. master -> coordinator
5. slave -> worker

Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

-------------

Commit messages:
 - Terminology Cleanup
 - corelibs terminology refresh - bchristi

Changes: https://git.openjdk.java.net/jdk/pull/1771/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253497
  Stats: 82 lines in 15 files changed: 1 ins; 0 del; 81 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1771/head:pull/1771

PR: https://git.openjdk.java.net/jdk/pull/1771

From naoto at openjdk.java.net  Mon Dec 14 20:29:56 2020
From: naoto at openjdk.java.net (Naoto Sato)
Date: Mon, 14 Dec 2020 20:29:56 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <6mGHyzJFxdntyaLG6CFPBw87a3I7caQuhWGz8hpLneY=.44f01fb2-a150-42e6-a3b0-853d72d24a1b@github.com>

On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Looks good to me.

test/jdk/java/lang/ClassLoader/Assert.java line 65:

> 63: 
> 64:         int switchSource = 0;
> 65:         if (args.length == 0) { // This is  the coordinator version

Extra space between "is" and "the."

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1771

From kcr at openjdk.java.net  Mon Dec 14 20:38:58 2020
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Mon, 14 Dec 2020 20:38:58 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <ucR9bOGxWzSMGwDy9XYG_xjlDnob_wMLOoksGUE9Xu0=.328ad058-1764-48ca-93ae-9605de0e7aa6@github.com>

On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Marked as reviewed by kcr (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From joehw at openjdk.java.net  Mon Dec 14 21:15:58 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Mon, 14 Dec 2020 21:15:58 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>

On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Marked as reviewed by joehw (Reviewer).

src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 135:

> 133:      * The pattern must be in same format as used in
> 134:      * {@link java.io.ObjectInputFilter.Config#createFilter}.
> 135:      * It may define an accept-list of permitted classes, a reject-list of

should accept-list be allow-list to be consistent with the other two RMI classes and ObjectInputFilter.Status#ALLOWED?

src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 152:

> 150:      * <p>
> 151:      * Care must be taken when defining such a filter, as defining
> 152:      * an accept-list too restrictive or a too-wide reject-list may

would "an allow-list too restrictive or a reject-list too wide" read better?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From rriggs at openjdk.java.net  Mon Dec 14 21:15:56 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Mon, 14 Dec 2020 21:15:56 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <K0seMjLKhhmowZfX2kKeybGzSUvezMw5u96B2QtC-Us=.52ca831d-8036-4fc5-9fe0-f3ce0bf9160c@github.com>

On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Marked as reviewed by rriggs (Reviewer).

src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 135:

> 133:      * The pattern must be in same format as used in
> 134:      * {@link java.io.ObjectInputFilter.Config#createFilter}.
> 135:      * It may define an accept-list of permitted classes, a reject-list of

accept -> allow for consistency

src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 152:

> 150:      * <p>
> 151:      * Care must be taken when defining such a filter, as defining
> 152:      * an accept-list too restrictive or a too-wide reject-list may

accept -> allow for consistency

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 01:38:59 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 01:38:59 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh
In-Reply-To: <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
Message-ID: <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>

On Mon, 14 Dec 2020 21:08:35 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 152:
> 
>> 150:      * <p>
>> 151:      * Care must be taken when defining such a filter, as defining
>> 152:      * an accept-list too restrictive or a too-wide reject-list may
> 
> would "an allow-list too restrictive or a reject-list too wide" read better?

I agree that there is room for improvement here.  How about:
"...an allow-list too restrictively, or a reject-list too broadly, may..."
?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 01:46:08 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 01:46:08 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Brent Christian has updated the pull request incrementally with one additional commit since the last revision:

  updates, per code review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1771/files
  - new: https://git.openjdk.java.net/jdk/pull/1771/files/4efa5d43..29525f05

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1771/head:pull/1771

PR: https://git.openjdk.java.net/jdk/pull/1771

From joehw at openjdk.java.net  Tue Dec 15 01:46:09 2020
From: joehw at openjdk.java.net (Joe Wang)
Date: Tue, 15 Dec 2020 01:46:09 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
 <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>
Message-ID: <TZV1N7mk13QAb8casXllkVpuft3iExT_ISM3QYutRh8=.b168d39b-e786-4b14-b9dd-c742ad073b7a@github.com>

On Tue, 15 Dec 2020 01:36:27 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 152:
>> 
>>> 150:      * <p>
>>> 151:      * Care must be taken when defining such a filter, as defining
>>> 152:      * an accept-list too restrictive or a too-wide reject-list may
>> 
>> would "an allow-list too restrictive or a reject-list too wide" read better?
>
> I agree that there is room for improvement here.  How about:
> "...an allow-list too restrictively, or a reject-list too broadly, may..."
> ?

That sounds good to me

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From alanb at openjdk.java.net  Tue Dec 15 07:36:57 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Tue, 15 Dec 2020 07:36:57 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
Message-ID: <-neClWA41LmYuPXJnPDfdxEplCuopdn8ze3V3GZQ-YU=.d6c7045b-a6c9-49e6-97f9-a0fa84185ffe@github.com>

On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updates, per code review

test/jdk/java/nio/channels/SocketChannel/CloseRegisteredChannel.java line 45:

> 43:         SocketChannel client = SocketChannel.open ();
> 44:         client.connect (new InetSocketAddress (InetAddress.getLoopbackAddress(), port));
> 45:         SocketChannel channel = server.accept ();

Can you rename this to "peer" instead? (we can remove the spurious space after accept while we are there).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From ihse at openjdk.java.net  Tue Dec 15 09:19:56 2020
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Tue, 15 Dec 2020 09:19:56 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <TZV1N7mk13QAb8casXllkVpuft3iExT_ISM3QYutRh8=.b168d39b-e786-4b14-b9dd-c742ad073b7a@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
 <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>
 <TZV1N7mk13QAb8casXllkVpuft3iExT_ISM3QYutRh8=.b168d39b-e786-4b14-b9dd-c742ad073b7a@github.com>
Message-ID: <-lt5TUB2HeKHv4YDbsHzTBucn1FqzcU3dgUIGi3DF6Y=.8cea83a2-6ff4-4692-9be7-cd11fa2879bc@github.com>

On Tue, 15 Dec 2020 01:41:07 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> I agree that there is room for improvement here.  How about:
>> "...an allow-list too restrictively, or a reject-list too broadly, may..."
>> ?
>
> Your call, I'm not a native English speaker :-)  It felt to me it's 'restrictive' than 'restrictively', an adj placed after the noun, e.g. a restrictive allow-list.

It's an adverb, since it's the act of 'defining' that is being done too restrictively or broadly. If you want to have an adjective you would need to rephrase it so it applies to the noun, like 'defining a too restrictive accept-list'. My non-native English vibes would still prefer the former.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 18:50:56 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 18:50:56 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <-neClWA41LmYuPXJnPDfdxEplCuopdn8ze3V3GZQ-YU=.d6c7045b-a6c9-49e6-97f9-a0fa84185ffe@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
 <-neClWA41LmYuPXJnPDfdxEplCuopdn8ze3V3GZQ-YU=.d6c7045b-a6c9-49e6-97f9-a0fa84185ffe@github.com>
Message-ID: <8p4RRf4ltO4wlaOuBRdmlMA-EFGqomUwl2Oat9RwOzw=.95ea6210-d252-4d7a-b316-0384c14b4490@github.com>

On Tue, 15 Dec 2020 07:32:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updates, per code review
>
> test/jdk/java/nio/channels/SocketChannel/CloseRegisteredChannel.java line 45:
> 
>> 43:         SocketChannel client = SocketChannel.open ();
>> 44:         client.connect (new InetSocketAddress (InetAddress.getLoopbackAddress(), port));
>> 45:         SocketChannel channel = server.accept ();
> 
> Can you rename this to "peer" instead? (we can remove the spurious space after accept while we are there).

Yes, I will name it, "peer", and remove the extra space on the affected lines.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bpb at openjdk.java.net  Tue Dec 15 22:00:05 2020
From: bpb at openjdk.java.net (Brian Burkhalter)
Date: Tue, 15 Dec 2020 22:00:05 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
Message-ID: <AP8NPSJB6yGOkKwlngzueZXQNWRsCX4Lrt1vrt5ah7s=.1d742545-f9fc-47f0-bca8-e215fd4510a3@github.com>

On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updates, per code review

test/jdk/java/lang/ClassLoader/Assert.java line 65:

> 63: 
> 64:         int switchSource = 0;
> 65:         if (args.length == 0) { // This is the coordinator version

Perhaps s/coordinator/controller/?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From lancea at openjdk.java.net  Tue Dec 15 22:04:59 2020
From: lancea at openjdk.java.net (Lance Andersen)
Date: Tue, 15 Dec 2020 22:04:59 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <AP8NPSJB6yGOkKwlngzueZXQNWRsCX4Lrt1vrt5ah7s=.1d742545-f9fc-47f0-bca8-e215fd4510a3@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
 <AP8NPSJB6yGOkKwlngzueZXQNWRsCX4Lrt1vrt5ah7s=.1d742545-f9fc-47f0-bca8-e215fd4510a3@github.com>
Message-ID: <lU3j1evUF7FtehkVSeaeiVDKrK8bWb2Q3AINxBnN35s=.407a29f7-a0fd-43ac-9864-7bd1487af545@github.com>

On Tue, 15 Dec 2020 21:57:17 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updates, per code review
>
> test/jdk/java/lang/ClassLoader/Assert.java line 65:
> 
>> 63: 
>> 64:         int switchSource = 0;
>> 65:         if (args.length == 0) { // This is the coordinator version
> 
> Perhaps s/coordinator/controller/?

Let's change it to: 

// This is the controller

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 22:05:00 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 22:05:00 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <lU3j1evUF7FtehkVSeaeiVDKrK8bWb2Q3AINxBnN35s=.407a29f7-a0fd-43ac-9864-7bd1487af545@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <gvGudpAHznlo-2b2W2a0dxtgDX3Ws6Lq_9-Q2D65Zmo=.2cdb68d7-5d25-4b68-90e5-2444a2ce7adb@github.com>
 <AP8NPSJB6yGOkKwlngzueZXQNWRsCX4Lrt1vrt5ah7s=.1d742545-f9fc-47f0-bca8-e215fd4510a3@github.com>
 <lU3j1evUF7FtehkVSeaeiVDKrK8bWb2Q3AINxBnN35s=.407a29f7-a0fd-43ac-9864-7bd1487af545@github.com>
Message-ID: <DixdPSfjNXoAXjFMzfNI6iRa7BbNOLoQCckDtqnryWU=.de23933e-32d2-433a-ae6c-ae4b937e918f@github.com>

On Tue, 15 Dec 2020 22:02:00 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> test/jdk/java/lang/ClassLoader/Assert.java line 65:
>> 
>>> 63: 
>>> 64:         int switchSource = 0;
>>> 65:         if (args.length == 0) { // This is the coordinator version
>> 
>> Perhaps s/coordinator/controller/?
>
> Let's change it to: 
> 
> // This is the controller

Will do.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From smarks at openjdk.java.net  Tue Dec 15 22:16:57 2020
From: smarks at openjdk.java.net (Stuart Marks)
Date: Tue, 15 Dec 2020 22:16:57 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v2]
In-Reply-To: <-lt5TUB2HeKHv4YDbsHzTBucn1FqzcU3dgUIGi3DF6Y=.8cea83a2-6ff4-4692-9be7-cd11fa2879bc@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
 <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>
 <TZV1N7mk13QAb8casXllkVpuft3iExT_ISM3QYutRh8=.b168d39b-e786-4b14-b9dd-c742ad073b7a@github.com>
 <-lt5TUB2HeKHv4YDbsHzTBucn1FqzcU3dgUIGi3DF6Y=.8cea83a2-6ff4-4692-9be7-cd11fa2879bc@github.com>
Message-ID: <PyLAAK64lq7vFe4t4X_NSwXfg3piCq69KvUQZNFmmvg=.b8f00bd3-70ad-40ac-8deb-fadaa60b88c8@github.com>

On Tue, 15 Dec 2020 09:17:03 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Your call, I'm not a native English speaker :-)  It felt to me it's 'restrictive' than 'restrictively', an adj placed after the noun, e.g. a restrictive allow-list.
>
> It's an adverb, since it's the act of 'defining' that is being done too restrictively or broadly. If you want to have an adjective you would need to rephrase it so it applies to the noun, like 'defining a too restrictive accept-list'. My non-native English vibes would still prefer the former.

I'd suggest `... as defining an allow-list that is too narrow or a reject-list that is too-wide may prevent ...`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 22:21:12 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 22:21:12 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v3]
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <cFd-StKSZN3OLzli4GiTY-h0Q-1i4T6fpKUmXE49cvk=.ca841417-510b-47ae-9710-5bfc4bdcaef4@github.com>

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Brent Christian has updated the pull request incrementally with three additional commits since the last revision:

 - This is the controller
 - use 'controller' in Assert.java
 - use 'peer' in CloseRegisteredChannel.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1771/files
  - new: https://git.openjdk.java.net/jdk/pull/1771/files/29525f05..b8cd8b6d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=01-02

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1771/head:pull/1771

PR: https://git.openjdk.java.net/jdk/pull/1771

From bpb at openjdk.java.net  Tue Dec 15 22:46:59 2020
From: bpb at openjdk.java.net (Brian Burkhalter)
Date: Tue, 15 Dec 2020 22:46:59 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v3]
In-Reply-To: <cFd-StKSZN3OLzli4GiTY-h0Q-1i4T6fpKUmXE49cvk=.ca841417-510b-47ae-9710-5bfc4bdcaef4@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <cFd-StKSZN3OLzli4GiTY-h0Q-1i4T6fpKUmXE49cvk=.ca841417-510b-47ae-9710-5bfc4bdcaef4@github.com>
Message-ID: <e88mdnB1oPR5l7rUi6IcfOhc0rhFmRtobpMDjnYpY_k=.99332134-9e45-4040-abb8-3e16d1e8bd6c@github.com>

On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - This is the controller
>  - use 'controller' in Assert.java
>  - use 'peer' in CloseRegisteredChannel.java

Marked as reviewed by bpb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From rriggs at openjdk.java.net  Tue Dec 15 22:46:58 2020
From: rriggs at openjdk.java.net (Roger Riggs)
Date: Tue, 15 Dec 2020 22:46:58 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v3]
In-Reply-To: <cFd-StKSZN3OLzli4GiTY-h0Q-1i4T6fpKUmXE49cvk=.ca841417-510b-47ae-9710-5bfc4bdcaef4@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <cFd-StKSZN3OLzli4GiTY-h0Q-1i4T6fpKUmXE49cvk=.ca841417-510b-47ae-9710-5bfc4bdcaef4@github.com>
Message-ID: <AWElw-dsAxq_LvaeyNvTfiCViBf298Zx-vLakIYoSn0=.ae305bb0-5a63-404f-8363-2465da38627f@github.com>

On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - This is the controller
>  - use 'controller' in Assert.java
>  - use 'peer' in CloseRegisteredChannel.java

Marked as reviewed by rriggs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 23:09:55 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 23:09:55 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v3]
In-Reply-To: <PyLAAK64lq7vFe4t4X_NSwXfg3piCq69KvUQZNFmmvg=.b8f00bd3-70ad-40ac-8deb-fadaa60b88c8@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <8AAYm6R8mELwB5SCh1OMouMRsJxK1HJbY8YF_27Vt0g=.cd499dba-ef15-4283-ad9e-154efc5319d0@github.com>
 <BmzALdZWNiH3LMJ2xUOHNcLdU6kEu0GRkktPpo2BkII=.f5136170-5d4f-4ee5-8c37-2454916938a6@github.com>
 <TZV1N7mk13QAb8casXllkVpuft3iExT_ISM3QYutRh8=.b168d39b-e786-4b14-b9dd-c742ad073b7a@github.com>
 <-lt5TUB2HeKHv4YDbsHzTBucn1FqzcU3dgUIGi3DF6Y=.8cea83a2-6ff4-4692-9be7-cd11fa2879bc@github.com>
 <PyLAAK64lq7vFe4t4X_NSwXfg3piCq69KvUQZNFmmvg=.b8f00bd3-70ad-40ac-8deb-fadaa60b88c8@github.com>
Message-ID: <YhamnqlvGjeHCQphbMzf8m7zznb6ZLv1BOquII5ymac=.ed3985e2-8cb6-4eae-b6f0-5bde8d65bc63@github.com>

On Tue, 15 Dec 2020 22:13:58 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> It's an adverb, since it's the act of 'defining' that is being done too restrictively or broadly. If you want to have an adjective you would need to rephrase it so it applies to the noun, like 'defining a too restrictive accept-list'. My non-native English vibes would still prefer the former.
>
> I'd suggest `... as defining an allow-list that is too narrow or a reject-list that is too wide may prevent ...`.
> 
> (edited to remove hyphen from "too-wide")

Even better!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Tue Dec 15 23:14:14 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Tue, 15 Dec 2020 23:14:14 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v4]
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Brent Christian has updated the pull request incrementally with one additional commit since the last revision:

  improve SERIAL_FILTER_PATTERN comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1771/files
  - new: https://git.openjdk.java.net/jdk/pull/1771/files/b8cd8b6d..ba586413

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1771/head:pull/1771

PR: https://git.openjdk.java.net/jdk/pull/1771

From smarks at openjdk.java.net  Tue Dec 15 23:36:58 2020
From: smarks at openjdk.java.net (Stuart Marks)
Date: Tue, 15 Dec 2020 23:36:58 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v4]
In-Reply-To: <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>
Message-ID: <C46xXPgVdcqMIwz0gqhRZUe0WmGX44f7kLTY1CYMXwg=.bfa0f5c1-a091-4c4f-863a-f2031847a5b5@github.com>

On Tue, 15 Dec 2020 23:14:14 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve SERIAL_FILTER_PATTERN comment

Marked as reviewed by smarks (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From alanb at openjdk.java.net  Wed Dec 16 07:13:58 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Wed, 16 Dec 2020 07:13:58 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v4]
In-Reply-To: <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>
Message-ID: <F-rpAlhTfXxB85ATNs9d20d4LHw0OCgcI3zCFJ_xmTk=.fb0827e5-690c-4ea8-bcea-6c3690481652@github.com>

On Tue, 15 Dec 2020 23:14:14 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   improve SERIAL_FILTER_PATTERN comment

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/java/util/Locale.java line 1649:

> 1647:      * <p>This implements the 'Language-Tag' production of BCP47, and
> 1648:      * so supports legacy (regular and irregular, referred to as
> 1649:      * {@code Type: grandfathered} in BCP47) as well as

You might consider putting quotes around "Type; grandfathered" here, otherwise looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Wed Dec 16 20:00:59 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Wed, 16 Dec 2020 20:00:59 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v4]
In-Reply-To: <F-rpAlhTfXxB85ATNs9d20d4LHw0OCgcI3zCFJ_xmTk=.fb0827e5-690c-4ea8-bcea-6c3690481652@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <AclI3mrK8jFmyiN-6zMuX3DWCZ45M_WfiJizKNyOl44=.d0538c9c-8b32-44e7-a8d4-a179ab0b5cad@github.com>
 <F-rpAlhTfXxB85ATNs9d20d4LHw0OCgcI3zCFJ_xmTk=.fb0827e5-690c-4ea8-bcea-6c3690481652@github.com>
Message-ID: <_3eyagnLPeaqOmlVW65dLaW-Wml-BqQHSAtqFGgtzcE=.1168634c-3ed4-457a-867c-5d8bcd0d12c1@github.com>

On Wed, 16 Dec 2020 07:10:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve SERIAL_FILTER_PATTERN comment
>
> src/java.base/share/classes/java/util/Locale.java line 1649:
> 
>> 1647:      * <p>This implements the 'Language-Tag' production of BCP47, and
>> 1648:      * so supports legacy (regular and irregular, referred to as
>> 1649:      * {@code Type: grandfathered} in BCP47) as well as
> 
> You might consider putting quotes around "Type; grandfathered" here, otherwise looks good.

Yes, having that in quotes instead of in {@code} would be consistent with the rest of Locale.java.  I will change that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Wed Dec 16 20:08:11 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Wed, 16 Dec 2020 20:08:11 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v5]
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <YtcsLXC3RyluT0sdpQPKNnU3hFe3v8gnEC1hB00hHhI=.949b851d-5e2a-4e61-a83e-f13cb0afa1ec@github.com>

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

Brent Christian has updated the pull request incrementally with one additional commit since the last revision:

  Use quotes instead of @code in Locale

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1771/files
  - new: https://git.openjdk.java.net/jdk/pull/1771/files/ba586413..03264330

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1771&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1771/head:pull/1771

PR: https://git.openjdk.java.net/jdk/pull/1771

From smarks at openjdk.java.net  Wed Dec 16 22:17:56 2020
From: smarks at openjdk.java.net (Stuart Marks)
Date: Wed, 16 Dec 2020 22:17:56 GMT
Subject: jmx-dev RFR: 8253497: Core Libs Terminology Refresh [v5]
In-Reply-To: <YtcsLXC3RyluT0sdpQPKNnU3hFe3v8gnEC1hB00hHhI=.949b851d-5e2a-4e61-a83e-f13cb0afa1ec@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
 <YtcsLXC3RyluT0sdpQPKNnU3hFe3v8gnEC1hB00hHhI=.949b851d-5e2a-4e61-a83e-f13cb0afa1ec@github.com>
Message-ID: <7eyzI35LC0CuYkwMo5nfLC8CrEZxmIcX8GfbSKy91MI=.d3322944-9580-410c-b387-490742c36c5a@github.com>

On Wed, 16 Dec 2020 20:08:11 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
>> 
>> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
>> 1. grandfathered -> legacy
>> 2. blacklist -> filter or reject
>> 3. whitelist -> allow or accept
>> 4. master -> coordinator
>> 5. slave -> worker
>> 
>> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use quotes instead of @code in Locale

Marked as reviewed by smarks (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

From bchristi at openjdk.java.net  Wed Dec 16 23:12:55 2020
From: bchristi at openjdk.java.net (Brent Christian)
Date: Wed, 16 Dec 2020 23:12:55 GMT
Subject: jmx-dev Integrated: 8253497: Core Libs Terminology Refresh
In-Reply-To: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
References: <Q9n5PnfVVjVHNYG2TXoENP74QpQXuLfQhY7FuLyX47g=.56731360-cafe-44cb-b119-0d6b681def11@github.com>
Message-ID: <pHBg-ZCup9YJny2THa4bJtMYhdBb5Rj1ln30zVjaA1w=.5d97c032-d5d5-40c3-84f6-5003170d3b35@github.com>

On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
> 
> Here are the changes covering core libraries code and tests.  Terms were changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or reject
> 3. whitelist -> allow or accept
> 4. master -> coordinator
> 5. slave -> worker
> 
> Addressing similar issues in upstream 3rd party code is out of scope of this PR.  Such changes will be picked up from their upstream sources.

This pull request has now been integrated.

Changeset: b2f03554
Author:    Brent Christian <bchristi at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/b2f03554
Stats:     82 lines in 15 files changed: 1 ins; 0 del; 81 mod

8253497: Core Libs Terminology Refresh

Reviewed-by: naoto, kcr, rriggs, joehw, bpb, smarks, alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771