jmx-dev RFR: 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Aleksey Shipilev shade at openjdk.java.net
Thu Dec 3 18:34:08 UTC 2020


On Sun, 29 Nov 2020 18:03:24 GMT, Turbanov Andrey <github.com+741251+turbanoff at openjdk.org> wrote:

> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton

Changes requested by shade (Reviewer).

Submitted -- https://bugs.openjdk.java.net/browse/JDK-8257708, rename this PR to "8257708: Remove redundant unmodifiableSet wrapper from already immutable set returned by Collections.singleton" to get it hooked up.

src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java line 60:

> 58:             private final Set<String> classLoadingInterfaceNames =
> 59:                     Collections.singleton(
> 60:                             "java.lang.management.ClassLoadingMXBean");

Here and later, I think we can avoid awkward newlines: `Collections.singleton("java.lang...")`

-------------

PR: https://git.openjdk.java.net/jdk/pull/1505


More information about the jmx-dev mailing list