From thejasvi.v.voniadka at oracle.com Mon May 4 12:35:14 2020 From: thejasvi.v.voniadka at oracle.com (Thejasvi Voniadka) Date: Mon, 4 May 2020 05:35:14 -0700 (PDT) Subject: jmx-dev [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests In-Reply-To: References: Message-ID: <1d7ad0b3-2b3a-4950-b559-929451e13283@default> Adding jmx-dev and security-dev. -----Original Message----- From: Thejasvi Voniadka Sent: Monday, May 4, 2020 12:56 PM To: core-libs-dev at openjdk.java.net Subject: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8244199 Description: The test "test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails intermittently on a lower release. While investigating the cause for the failure, I felt the diagnostic messaging built into the test was not adequate. Some of the issues observed: 1. If the test throws a RuntimeException, the full stack trace is not displayed. 2. The test has several logging statements. However, the logging environment is not properly initialized to allow levels such as FINE when needed. 3. The logging sequence could be improved: some messages end up at stdout, and others at stderr, which makes it harder to follow the output. The patch is to improve the test in these lines. Webrev: http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.full.00 I have also used this opportunity to clean-up the test code as a whole, in lines of removal of redundant logic, formatting, coding guidelines, etc.... If the above patch looks too confusing and is hard to follow, here is a simpler version that shows only the core logic changes (I intend to submit only the full patch to be committed though): http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.simple.00 The patch has been tested on mach5, and all jmxremote tests passed. From thejasvi.v.voniadka at oracle.com Wed May 6 06:09:21 2020 From: thejasvi.v.voniadka at oracle.com (Thejasvi Voniadka) Date: Tue, 5 May 2020 23:09:21 -0700 (PDT) Subject: jmx-dev [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests In-Reply-To: <1d7ad0b3-2b3a-4950-b559-929451e13283@default> References: <1d7ad0b3-2b3a-4950-b559-929451e13283@default> Message-ID: <4f805057-4bdb-42d7-b1e7-bf658a052615@default> Hello, A quick follow-up on this request.. -----Original Message----- From: Thejasvi Voniadka Sent: Monday, May 4, 2020 12:56 PM To: core-libs-dev at openjdk.java.net Subject: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8244199 Description: The test "test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails intermittently on a lower release. While investigating the cause for the failure, I felt the diagnostic messaging built into the test was not adequate. Some of the issues observed: 1. If the test throws a RuntimeException, the full stack trace is not displayed. 2. The test has several logging statements. However, the logging environment is not properly initialized to allow levels such as FINE when needed. 3. The logging sequence could be improved: some messages end up at stdout, and others at stderr, which makes it harder to follow the output. The patch is to improve the test in these lines. Webrev: http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.full.00 I have also used this opportunity to clean-up the test code as a whole, in lines of removal of redundant logic, formatting, coding guidelines, etc.... If the above patch looks too confusing and is hard to follow, here is a simpler version that shows only the core logic changes (I intend to submit only the full patch to be committed though): http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.simple.00 The patch has been tested on mach5, and all jmxremote tests passed. From thejasvi.v.voniadka at oracle.com Fri May 8 00:47:28 2020 From: thejasvi.v.voniadka at oracle.com (Thejasvi Voniadka) Date: Thu, 7 May 2020 17:47:28 -0700 (PDT) Subject: jmx-dev RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Message-ID: <8177caa9-b705-40d9-b35e-59834cfed2d5@default> Hi, May someone please sponsor this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8244199 Description: The test "test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails intermittently on a lower release. While investigating the cause for the failure, I felt the diagnostic messaging built into the test was not adequate. Some of the issues observed: 1. If the test throws a RuntimeException, the full stack trace is not displayed. 2. The test has several logging statements. However, the logging environment is not properly initialized to allow levels such as FINE and FINER. 3. The logging sequence could be improved: some messages end up at stdout, and others at stderr, which makes it harder to follow the output. The patch is to improve the test in these lines. Webrev: http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.full.00 I have also used this opportunity to clean-up the test code as a whole, in lines of removal of redundant logic, formatting, coding guidelines, etc.... If the above patch looks too confusing and is hard to follow, here is a simpler version that shows only the core logic changes (I intend to submit the full patch to be pushed though): http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.simple.00 The patch has been tested on mach5, and all jmxremote tests passed. From thejasvi.v.voniadka at oracle.com Tue May 12 02:18:27 2020 From: thejasvi.v.voniadka at oracle.com (Thejasvi Voniadka) Date: Mon, 11 May 2020 19:18:27 -0700 (PDT) Subject: jmx-dev RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests In-Reply-To: <8177caa9-b705-40d9-b35e-59834cfed2d5@default> References: <8177caa9-b705-40d9-b35e-59834cfed2d5@default> Message-ID: <5ff0d35a-1a19-4a30-9c59-d7f9d29aba28@default> Ping.. -----Original Message----- From: Thejasvi Voniadka Sent: Friday, May 8, 2020 6:17 AM To: core-libs-dev at openjdk.java.net; jmx-dev at openjdk.java.net; security-dev at openjdk.java.net Subject: RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May someone please sponsor this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8244199 Description: The test "test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails intermittently on a lower release. While investigating the cause for the failure, I felt the diagnostic messaging built into the test was not adequate. Some of the issues observed: 1. If the test throws a RuntimeException, the full stack trace is not displayed. 2. The test has several logging statements. However, the logging environment is not properly initialized to allow levels such as FINE and FINER. 3. The logging sequence could be improved: some messages end up at stdout, and others at stderr, which makes it harder to follow the output. The patch is to improve the test in these lines. Webrev: http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.full.00 I have also used this opportunity to clean-up the test code as a whole, in lines of removal of redundant logic, formatting, coding guidelines, etc.... If the above patch looks too confusing and is hard to follow, here is a simpler version that shows only the core logic changes (I intend to submit the full patch to be pushed though): http://cr.openjdk.java.net/~tvoniadka/reviews/8244199/webrev.simple.00 The patch has been tested on mach5, and all jmxremote tests passed.