jmx-dev RFR: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management [v2]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Fri Oct 1 23:00:29 UTC 2021
On Fri, 1 Oct 2021 21:12:57 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:
>> There are a few places in code, where manual `for` loop is used with Iterator to iterate over Collection.
>> Instead of manual `for` cycles, it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
>> It doesn't have any performance impact: javac compiler generates similar code when compiling enhanced-for cycle.
>> Similar cleanups:
>> 1. [JDK-8274016](https://bugs.openjdk.java.net/browse/JDK-8274016) java.desktop
>> 2. [JDK-8274237](https://bugs.openjdk.java.net/browse/JDK-8274237) java.base
>> 3. [JDK-8274261](https://bugs.openjdk.java.net/browse/JDK-8274261) jdk.jcmd
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management
> small code-style fixes
Thank you for the update. It looks good.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5695
More information about the jmx-dev
mailing list