jmx-dev RFR: 8298173: GarbageCollectionNotificationContentTest test failed: no decrease in Eden usage

[Serguei Spitsyn]

On Wed, 7 Dec 2022 21:50:11 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Test should not check that Eden has decreased in used size if the GCCause is "No GC".
> 
> These happen with the message "end of concurrent GC pause" which is logged by the GCMemoryManager _conc_gc_memory_manager (in G1MonitoringSupport).  This GCMemoryManager only interacts with the old gen memory pool, so it is expected that eden usage does not change.
> 
> Updated a few variable names to make it more obvious what count and number are recording, and some formatting.  The key  part of the change is at line 137 onwards.

Looks good.
Posted one nit.
Thanks,
Serguei

test/jdk/com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationContentTest.java line 94:

> 92:         numberOfGCMBeans = names.size();
> 93:         for (ObjectName n : names) {
> 94:             if(mbs.isInstanceOf(n, "javax.management.NotificationEmitter")) {

Nit: missed space in "if(".

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11572