From kevinw at openjdk.java.net  Mon Feb  7 17:34:29 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Mon, 7 Feb 2022 17:34:29 GMT
Subject: jmx-dev RFR: 6779701: Wrong defect ID in the code of test
 LocalRMIServerSocketFactoryTest.java
Message-ID: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>

Trivial comment and exception text update, correcting a bug ID to make more sense.

-------------

Commit messages:
 - 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Changes: https://git.openjdk.java.net/jdk/pull/7371/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7371&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-6779701
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7371.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7371/head:pull/7371

PR: https://git.openjdk.java.net/jdk/pull/7371

From cjplummer at openjdk.java.net  Mon Feb  7 17:46:08 2022
From: cjplummer at openjdk.java.net (Chris Plummer)
Date: Mon, 7 Feb 2022 17:46:08 GMT
Subject: jmx-dev RFR: 6779701: Wrong defect ID in the code of test
 LocalRMIServerSocketFactoryTest.java
In-Reply-To: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
References: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
Message-ID: <ficgt7S4a_Qtru4ynrm2k0ovuDuL9Fft2feP228MIOI=.03545d91-c25d-46d8-b55f-edf55e165cfb@github.com>

On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Trivial comment and exception text update, correcting a bug ID to make more sense.

Marked as reviewed by cjplummer (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7371

From dfuchs at openjdk.java.net  Mon Feb  7 18:12:15 2022
From: dfuchs at openjdk.java.net (Daniel Fuchs)
Date: Mon, 7 Feb 2022 18:12:15 GMT
Subject: jmx-dev RFR: 6779701: Wrong defect ID in the code of test
 LocalRMIServerSocketFactoryTest.java
In-Reply-To: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
References: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
Message-ID: <ATi1A3C8W0CPsZ3VrkIGDyxpz4oN4iK-IL8KN40Deuk=.00a3eb27-cecb-419b-9728-608ce80e7aea@github.com>

On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Trivial comment and exception text update, correcting a bug ID to make more sense.

LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7371

From kevinw at openjdk.java.net  Mon Feb  7 18:19:10 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Mon, 7 Feb 2022 18:19:10 GMT
Subject: jmx-dev RFR: 6779701: Wrong defect ID in the code of test
 LocalRMIServerSocketFactoryTest.java
In-Reply-To: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
References: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
Message-ID: <AasbBY0kezxVyelGj7bK0N3uw7tM7GgwgOFrv2ZJffM=.7c034ce9-abec-488e-afd5-853c2620eade@github.com>

On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Trivial comment and exception text update, correcting a bug ID to make more sense.

Thanks Chris, thanks Daniel!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7371

From kevinw at openjdk.java.net  Mon Feb  7 18:19:10 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Mon, 7 Feb 2022 18:19:10 GMT
Subject: jmx-dev Integrated: 6779701: Wrong defect ID in the code of test
 LocalRMIServerSocketFactoryTest.java
In-Reply-To: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
References: <oh_I7nWzMSMAduZ_-_fTxoSBGY4Y9rhjOLXSWxSoiec=.8a4b499a-d2d9-42a1-8468-3e8f92b6998e@github.com>
Message-ID: <qbIa_tjY9DcAge_mpSABJSI9lL-_8OdQQbjjoODMhZw=.e231e217-1d7f-4c45-aee9-da9fa6558d7f@github.com>

On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Trivial comment and exception text update, correcting a bug ID to make more sense.

This pull request has now been integrated.

Changeset: 8a662105
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8a662105c2da1f0fb9b7ecc5058fc85858439ed9
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Reviewed-by: cjplummer, dfuchs

-------------

PR: https://git.openjdk.java.net/jdk/pull/7371

From kevinw at openjdk.java.net  Wed Feb 23 14:15:18 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Wed, 23 Feb 2022 14:15:18 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
Message-ID: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>

Test fails occasionally due to a port clash.
Presumably the port that was returned by Utils.getFreePort(), is no longer free.
The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
It should retry with a new port if we fail due to a port in use, for some limited number of attempts.

main already has some retry logic, but not working:
it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.

So...

Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

-------------

Commit messages:
 - Remove tab.
 - Throw on last retry if port clash persists.
 - Merge remote-tracking branch 'upstream/master' into 8206187_DefaultAgentFilterTest
 - 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

Changes: https://git.openjdk.java.net/jdk/pull/7589/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7589&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8206187
  Stats: 73 lines in 1 file changed: 25 ins; 29 del; 19 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7589.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7589/head:pull/7589

PR: https://git.openjdk.java.net/jdk/pull/7589

From msheppar at openjdk.java.net  Wed Feb 23 17:22:49 2022
From: msheppar at openjdk.java.net (Mark Sheppard)
Date: Wed, 23 Feb 2022 17:22:49 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
In-Reply-To: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
Message-ID: <K54B4iOXC_W6lLpZbxwKacBNIHO9rZIEbrMhX4XCqgc=.26b3a4f2-d6ae-452d-9a2f-5c21a29a2429@github.com>

On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Test fails occasionally due to a port clash.
> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
> 
> main already has some retry logic, but not working:
> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
> 
> So...
> 
> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

This is reasonable approach to take and should ameliorate the BindException failure condition.
But, as it is using the same port allocation strategy which is in current use, then it will be still be
suspect to intermittent BindException failures. This will be especially true, as with the current failures,
there is a lot of network testing activity with concurrent network test execution and the MACH5 test framework itself e.g. logstash etc.

An alternative is to use a fixed port 1098, which previously was the default for RMI Activation daemon.
This is now available as activation has been removed from the java platform in JDK17.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From amenkov at openjdk.java.net  Wed Feb 23 17:45:53 2022
From: amenkov at openjdk.java.net (Alex Menkov)
Date: Wed, 23 Feb 2022 17:45:53 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
In-Reply-To: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
Message-ID: <_KkuygOYarPELAzDh2OC8TelGKgMzjg-llUkCQIxeDk=.7031205c-a4e5-489a-b879-04953fd133a4@github.com>

On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Test fails occasionally due to a port clash.
> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
> 
> main already has some retry logic, but not working:
> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
> 
> So...
> 
> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

The test uses warm-up predicate in a strange way - it returns true for any output from child process.
The main purpose of the predicate is to wait until some expected output is produced, and return false to skip other lines (for example in some environments VM may print some warnings).
For this test it may be "main enter" (printed from TestApp.main()).
To handle "port in use" error the predicate can search for "bindexception" or "port already in use" line.
I don't think check for "exception" and "error" makes much sense here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Thu Feb 24 10:33:05 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Thu, 24 Feb 2022 10:33:05 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
In-Reply-To: <K54B4iOXC_W6lLpZbxwKacBNIHO9rZIEbrMhX4XCqgc=.26b3a4f2-d6ae-452d-9a2f-5c21a29a2429@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <K54B4iOXC_W6lLpZbxwKacBNIHO9rZIEbrMhX4XCqgc=.26b3a4f2-d6ae-452d-9a2f-5c21a29a2429@github.com>
Message-ID: <lmPsmHYtosdS4xNU8_BMNNG5nXDcQvISJ550FGmkqaY=.67d7d9bf-1d6f-4573-b7ab-745776f42e61@github.com>

On Wed, 23 Feb 2022 17:19:16 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

> An alternative is to use a fixed port 1098

Thanks Mark - I will avoid that fixed slot as we no doubt run tests concurrently, and also in case these get backported far enough that it's not free. 8-)

Utils.getFreePort() lets new ServerSocket choose a port,  but there's clearly a race to use it.  We could make it simply random, but I think we need still need to retry like this to avoid failures --  will monitor and see how the race goes with 10 attempts.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Thu Feb 24 11:40:03 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Thu, 24 Feb 2022 11:40:03 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
In-Reply-To: <_KkuygOYarPELAzDh2OC8TelGKgMzjg-llUkCQIxeDk=.7031205c-a4e5-489a-b879-04953fd133a4@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <_KkuygOYarPELAzDh2OC8TelGKgMzjg-llUkCQIxeDk=.7031205c-a4e5-489a-b879-04953fd133a4@github.com>
Message-ID: <Nl1uIBeNrduJZpJxPaLsnUjy3fIa_7XQngm0JiGqBYY=.b013b19a-5499-432c-9247-0215df0a0de5@github.com>

On Wed, 23 Feb 2022 17:42:35 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The test uses warm-up predicate in a strange way

Thanks Alex - yes so that's why we only see one line in the predicate, it contains the word "exception" and the predicate returns true, signalling that the process is done starting up. 8-)
But if you do see an exception, you're never going to see the text from the app that it has started OK, so I see why it was returning true always - we were either seeing an error, or otherwise we presume TestApp has started.
But it returned true after seeing the first line, which does not contain "bindexception", so it never saw the BindException later to recognise the port being in use.

Anyway...
I will update shortly to hopefully clarify the predicate part.  Still good to keep main() simpler and not have duplicated retry logic there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Thu Feb 24 12:17:54 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Thu, 24 Feb 2022 12:17:54 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v2]
In-Reply-To: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
Message-ID: <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>

> Test fails occasionally due to a port clash.
> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
> 
> main already has some retry logic, but not working:
> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
> 
> So...
> 
> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  Clarify predicate usage.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7589/files
  - new: https://git.openjdk.java.net/jdk/pull/7589/files/a1bc3d0e..6cdcde8a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7589&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7589&range=00-01

  Stats: 10 lines in 1 file changed: 4 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7589.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7589/head:pull/7589

PR: https://git.openjdk.java.net/jdk/pull/7589

From msheppar at openjdk.java.net  Thu Feb 24 12:49:04 2022
From: msheppar at openjdk.java.net (Mark Sheppard)
Date: Thu, 24 Feb 2022 12:49:04 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v2]
In-Reply-To: <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
Message-ID: <4mGs7EgpTyMNS9IK-IVWUVvCiAuos9LEgggOngjqFvM=.fa120324-1ce7-4094-af5b-52974a0d20db@github.com>

On Thu, 24 Feb 2022 12:17:54 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Test fails occasionally due to a port clash.
>> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
>> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
>> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
>> 
>> main already has some retry logic, but not working:
>> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
>> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
>> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
>> 
>> So...
>> 
>> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
>> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify predicate usage.

Marked as reviewed by msheppar (Reviewer).

test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java line 174:

> 172:     private static final int FREE_PORT_ATTEMPTS = 10;
> 173: 
> 174:     private static void testDefaultAgent(String propertyFile) throws Exception {

This is a good refactoring change as it also removes some broken logic in the current retry strategy

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From amenkov at openjdk.java.net  Thu Feb 24 13:14:10 2022
From: amenkov at openjdk.java.net (Alex Menkov)
Date: Thu, 24 Feb 2022 13:14:10 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v2]
In-Reply-To: <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
Message-ID: <aDNuBKahZgGaeFqN0nE4MfvDJ6X_Pl9hVzAQj67LuVQ=.6b1c8aa9-a686-46fb-aefe-93ef95d52f56@github.com>

On Thu, 24 Feb 2022 12:17:54 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Test fails occasionally due to a port clash.
>> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
>> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
>> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
>> 
>> main already has some retry logic, but not working:
>> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
>> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
>> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
>> 
>> So...
>> 
>> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
>> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify predicate usage.

Marked as reviewed by amenkov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Thu Feb 24 15:02:40 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Thu, 24 Feb 2022 15:02:40 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v3]
In-Reply-To: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
Message-ID: <tC1DqvRwBrMchlsXvM3ViDELg0fAiXe2UlTAJv0ext8=.a28946eb-4308-4a2e-9f5e-5ebd02061901@github.com>

> Test fails occasionally due to a port clash.
> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
> 
> main already has some retry logic, but not working:
> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
> 
> So...
> 
> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  break to terminate retry loop when succesful

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7589/files
  - new: https://git.openjdk.java.net/jdk/pull/7589/files/6cdcde8a..33649830

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7589&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7589&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7589.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7589/head:pull/7589

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Thu Feb 24 15:02:42 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Thu, 24 Feb 2022 15:02:42 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v2]
In-Reply-To: <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <wu5NkLJiO5CW3CyDfMm3ZfwWKu1RTzJ8ENmpEnvQ6Dc=.12d1acca-2b53-4fe1-95aa-31dd6628ace4@github.com>
Message-ID: <2wuW-h6ZQ4qTmPhHo89cfvY64q8jrWjUI0MQMPZGy8Y=.cd822605-743b-4d42-b4b5-fdc9d2491c2c@github.com>

On Thu, 24 Feb 2022 12:17:54 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Test fails occasionally due to a port clash.
>> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
>> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
>> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
>> 
>> main already has some retry logic, but not working:
>> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
>> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
>> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
>> 
>> So...
>> 
>> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
>> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarify predicate usage.

Thanks for the reviews!

Apologies, one more update - I had a break in there earlier to terminate the retry loop, and I removed it accidentally when changing things to make it fail.
The retry loop has to let the testDefaultAgent method complete normally (which needs the break), or by throwing an Exception.
Both looking good now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From msheppar at openjdk.java.net  Thu Feb 24 23:40:12 2022
From: msheppar at openjdk.java.net (Mark Sheppard)
Date: Thu, 24 Feb 2022 23:40:12 GMT
Subject: jmx-dev RFR: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use [v3]
In-Reply-To: <tC1DqvRwBrMchlsXvM3ViDELg0fAiXe2UlTAJv0ext8=.a28946eb-4308-4a2e-9f5e-5ebd02061901@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
 <tC1DqvRwBrMchlsXvM3ViDELg0fAiXe2UlTAJv0ext8=.a28946eb-4308-4a2e-9f5e-5ebd02061901@github.com>
Message-ID: <AhGodJNbqA6Y7AM_3xGmLKvJOWA3g45QrWZlKRmOtCo=.38825ff5-9132-4a4e-bd27-ce31a2016d5c@github.com>

On Thu, 24 Feb 2022 15:02:40 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Test fails occasionally due to a port clash.
>> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
>> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
>> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
>> 
>> main already has some retry logic, but not working:
>> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
>> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
>> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
>> 
>> So...
>> 
>> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
>> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   break to terminate retry loop when succesful

Marked as reviewed by msheppar (Reviewer).

A good spot by yourself ... as the focus was on the BindException correction and the pass condition is an Exception being thrown, it was easy to miss the break for a failure condition ... a similar issue existed in the current test albeit only if an InvocationTargetException with a nested BindException was thrown and the retry resulted in the 
InvalidClassException or UnmarcshalledException !!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589

From kevinw at openjdk.java.net  Fri Feb 25 08:00:02 2022
From: kevinw at openjdk.java.net (Kevin Walls)
Date: Fri, 25 Feb 2022 08:00:02 GMT
Subject: jmx-dev Integrated: 8206187:
 javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
 fails with Port already in use
In-Reply-To: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
References: <BjnXf49oU5e-4i1UT0Dz1NHvgqphXvpx1slVEI5UDwM=.01d4d996-3a52-4e88-a95a-2cd280b4be0c@github.com>
Message-ID: <CNkoA3StnxVuWojiObpXS0oDaX653gqqH_C4pl_aCYg=.f8a7a777-124e-48d5-90b6-90f23fd33965@github.com>

On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Test fails occasionally due to a port clash.
> Presumably the port that was returned by Utils.getFreePort(), is no longer free.
> The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process.
> It should retry with a new port if we fail due to a port in use, for some limited number of attempts.
> 
> main already has some retry logic, but not working:
> it checks for an InvocationTargetException to contain a BindException, but it simply gets a BindException, thrown by TestAppRun.start().
> TestAppRun.start() runs the new process and scans for errors, but on failure its predicate has only seen the first line of a failure, so a BindException is never recognised and thrown.
> Also main does not limit the retries, and handling the port retry in main() is duplicated, for each run of the test method.
> 
> So...
> 
> Make the error-scanning predicate in TestAppRun recognise a "port in use" message and throw a BindExeption.  This is a notification to the caller that it failed, it's not the actual BindException as that was thrown in a different process.
> Make the testDefaultAgent method (the main part of the test) handle retrying with a new port, a limited number of times.

This pull request has now been integrated.

Changeset: cd36be42
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cd36be42c2eb3eacdb3625e87510eb15acac3230
Stats:     82 lines in 1 file changed: 30 ins; 30 del; 22 mod

8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

Reviewed-by: msheppar, amenkov

-------------

PR: https://git.openjdk.java.net/jdk/pull/7589