From djelinski at openjdk.org  Tue Jul  5 21:06:58 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Tue, 5 Jul 2022 21:06:58 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code
Message-ID: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>

This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 

The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.

I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.

-------------

Commit messages:
 - Remove unused variables (windows)
 - Remove unused variables (macos)
 - Remove unused variables (linux)

Changes: https://git.openjdk.org/jdk/pull/9383/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8289768
  Stats: 69 lines in 45 files changed: 0 ins; 65 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/9383.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9383/head:pull/9383

PR: https://git.openjdk.org/jdk/pull/9383

From dfuchs at openjdk.org  Wed Jul  6 09:39:28 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Wed, 6 Jul 2022 09:39:28 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <KaJHebp-ApC21FZYke6AekCJZYJR09p-0dNQfAkLKkU=.a187d507-ab37-4086-86bc-e1f03e52a067@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

Changes to libnet look good. Please wait until you have obtained approvals from maintainers of the other areas to integrate,

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Wed Jul  6 08:57:23 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Jul 2022 08:57:23 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <cSxCo06RRmSKNsQWRjAe2_lf5fpbm9R_c-crab--ac8=.3cc175af-0bf3-43b2-a345-a16314862e88@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

test failure is unrelated, caused by [JDK-8289619](https://bugs.openjdk.org/browse/JDK-8289619)

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Wed Jul  6 05:32:29 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Wed, 6 Jul 2022 05:32:29 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
Message-ID: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>

> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
> 
> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
> 
> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.

Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge remote-tracking branch 'origin' into unused-variables
 - Remove unused variables (windows)
 - Remove unused variables (macos)
 - Remove unused variables (linux)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9383/files
  - new: https://git.openjdk.org/jdk/pull/9383/files/915680c0..b4cd5374

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=00-01

  Stats: 491 lines in 22 files changed: 458 ins; 5 del; 28 mod
  Patch: https://git.openjdk.org/jdk/pull/9383.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9383/head:pull/9383

PR: https://git.openjdk.org/jdk/pull/9383

From lancea at openjdk.org  Wed Jul  6 15:35:39 2022
From: lancea at openjdk.org (Lance Andersen)
Date: Wed, 6 Jul 2022 15:35:39 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <LoVNDWlc51SJQBDzXcw8BTrvooN3L3-unDnIRLCHgek=.53cef1f1-2273-4da5-9d64-b3346f19814e@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

zlib looks fine given it is openjdk and not an upstream needed change

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From weijun at openjdk.org  Wed Jul  6 16:44:53 2022
From: weijun at openjdk.org (Weijun Wang)
Date: Wed, 6 Jul 2022 16:44:53 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <ZMpyNEU8PTGXpzZCkL5qkbpRdthjX3UpghdXRPILoeI=.9fd9bfdb-5f33-4537-8155-d1d3624f2236@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

Changes in security (`java.security.jgss`, `jdk.crypto.cryptoki`, `jdk.crypto.mscapi`) look fine to me.

-------------

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From naoto at openjdk.org  Wed Jul  6 19:46:33 2022
From: naoto at openjdk.org (Naoto Sato)
Date: Wed, 6 Jul 2022 19:46:33 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <sHbNPpkAlwc9slRcjKYbXCWOgpKXN-XEunqXoXX1644=.76ae69fd-5911-4090-923f-f7c47c8ca088@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From cjplummer at openjdk.org  Thu Jul  7 19:16:48 2022
From: cjplummer at openjdk.org (Chris Plummer)
Date: Thu, 7 Jul 2022 19:16:48 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
Message-ID: <7Cpve0LsselBf8cHCfT_4qs3j1XeaNFmxP62RFSMW8A=.8d642396-9421-4099-bfad-21aeeffaaa35@github.com>

On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin' into unused-variables
>  - Remove unused variables (windows)
>  - Remove unused variables (macos)
>  - Remove unused variables (linux)

Are you going to update copyrights?

I reviewed src/jdk.hotspot.agent, src/jdk.jdi/, src/jdk.jdwp.agent, and src/jdk.management. Looks good other than copyrights and the suggestion I made for additional cleanup in symtab.c.

src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 308:

> 306:   ELF_SHDR* shbuf = NULL;
> 307:   ELF_SHDR* cursct = NULL;
> 308:   ELF_PHDR* phbuf = NULL;

phbuf is also essentially unused. The only reference is to free it if non-null, but it's always NULL, so that code can be removed too.

-------------

Changes requested by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From cjplummer at openjdk.org  Fri Jul  8 07:20:46 2022
From: cjplummer at openjdk.org (Chris Plummer)
Date: Fri, 8 Jul 2022 07:20:46 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
Message-ID: <HWiis80fIvQdlOVtea6thFNk_VbOGDHltnJPDJMdo68=.7b9929c1-1a6c-48e3-bef3-369b91fda72e@github.com>

On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

Marked as reviewed by cjplummer (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Fri Jul  8 07:12:44 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Fri, 8 Jul 2022 07:12:44 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
Message-ID: <2_Xy-WrhqelW5xoQnKgSrnb1WSEENT6zlJ4ZRbnJDvo=.0e7b8752-9def-459a-ac6a-1172dbd3d5f7@github.com>

On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

Copyrights updated.

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Fri Jul  8 07:08:46 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Fri, 8 Jul 2022 07:08:46 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
Message-ID: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>

> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
> 
> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
> 
> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.

Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:

 - Update copyright
 - Remove more unused variables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9383/files
  - new: https://git.openjdk.org/jdk/pull/9383/files/b4cd5374..da30ef90

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9383&range=01-02

  Stats: 30 lines in 26 files changed: 0 ins; 4 del; 26 mod
  Patch: https://git.openjdk.org/jdk/pull/9383.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9383/head:pull/9383

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Fri Jul  8 07:08:50 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Fri, 8 Jul 2022 07:08:50 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v2]
In-Reply-To: <7Cpve0LsselBf8cHCfT_4qs3j1XeaNFmxP62RFSMW8A=.8d642396-9421-4099-bfad-21aeeffaaa35@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <umrx8D9dOcsFUPI5GdEOsuWNNVw_nBeV_2GlhdsIJy0=.08bd28d4-a345-4d83-8f53-1e7bae70b939@github.com>
 <7Cpve0LsselBf8cHCfT_4qs3j1XeaNFmxP62RFSMW8A=.8d642396-9421-4099-bfad-21aeeffaaa35@github.com>
Message-ID: <5lYmVui3caVoMyThlWMlQP1etBfuLQan6v6OUIBYh_o=.e1d33b03-8791-4462-a9e7-b13287df2aa8@github.com>

On Thu, 7 Jul 2022 19:06:52 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Daniel Jeli?ski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin' into unused-variables
>>  - Remove unused variables (windows)
>>  - Remove unused variables (macos)
>>  - Remove unused variables (linux)
>
> src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c line 308:
> 
>> 306:   ELF_SHDR* shbuf = NULL;
>> 307:   ELF_SHDR* cursct = NULL;
>> 308:   ELF_PHDR* phbuf = NULL;
> 
> phbuf is also essentially unused. The only reference is to free it if non-null, but it's always NULL, so that code can be removed too.

Good catch! Also removed similar code from macOS version.

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From alanb at openjdk.org  Fri Jul  8 08:03:39 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Fri, 8 Jul 2022 08:03:39 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
Message-ID: <eHLckqcFYnMhyC7rkOqTdkPozbDzFLzUdXRMmSRtWfE=.937733de-7eec-4360-b491-bdd219ad8c38@github.com>

On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

Marked as reviewed by alanb (Reviewer).

src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c line 686:

> 684:     LPCWSTR lpFileName = jlong_to_ptr(pathAddress);
> 685:     PSECURITY_DESCRIPTOR pSecurityDescriptor = jlong_to_ptr(descAddress);
> 686:     DWORD lengthNeeded = 0;

lengthNeeded, it seems not :-)

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From michaelm at openjdk.org  Mon Jul 11 07:00:45 2022
From: michaelm at openjdk.org (Michael McMahon)
Date: Mon, 11 Jul 2022 07:00:45 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
Message-ID: <HkJBah90Rykst8JP7axwitZPwaRlj_eHFD0U-wbUK6g=.875e3af1-c0b0-475a-ad0f-bba7d785dc67@github.com>

On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

libnet changes look fine to me

-------------

Marked as reviewed by michaelm (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From chegar at openjdk.org  Mon Jul 11 08:13:45 2022
From: chegar at openjdk.org (Chris Hegarty)
Date: Mon, 11 Jul 2022 08:13:45 GMT
Subject: jmx-dev RFR: 8289768: Clean up unused code [v3]
In-Reply-To: <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
 <Omx-_YGG52LbvB5MDiNE6Pbe9KVRtIOGyX0-vlezeVY=.8fd6eeff-62e5-481a-bd49-6c405fcd7cf5@github.com>
Message-ID: <0LufT1j0Gvkv3sFYqCQUR7aBmIU9lHIdOWBHVJyDc-M=.ee7f2980-e54f-4507-9ce3-73378faad4b8@github.com>

On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

>> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
>> 
>> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
>> 
>> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.
>
> Daniel Jeli?ski has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright
>  - Remove more unused variables

LGTM

-------------

Marked as reviewed by chegar (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9383

From djelinski at openjdk.org  Tue Jul 12 11:34:43 2022
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Tue, 12 Jul 2022 11:34:43 GMT
Subject: jmx-dev Integrated: 8289768: Clean up unused code
In-Reply-To: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
References: <nehhEkgli8579FpeJaBJd-I63OcfarH_XhHEBmW6R2A=.91a3cb1c-2482-42aa-bd69-a48f4bd48283@github.com>
Message-ID: <fcOcK4urRUx8yHC5j19TBmdIOnwWsM_OrGjKl8gKkrE=.69dd372d-d6d4-463a-8eff-8c69dc5f3eee@github.com>

On Tue, 5 Jul 2022 20:19:10 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

> This patch removes many unused variables and one unused label reported by the compilers when relevant warnings are enabled. 
> 
> The unused code was found by compiling after removing `unused` from the list of disabled warnings for [gcc](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L190) and [clang](https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L203), and enabling [C4189](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189?view=msvc-170) MSVC warning.
> 
> I only removed variables that were uninitialized or initialized without side effects. I verified that the removed variables were not used in any `#ifdef`'d code. I checked that the changed code still compiles on Windows, Linux and Mac, both in release and debug versions.

This pull request has now been integrated.

Changeset: 04c47da1
Author:    Daniel Jeli?ski <djelinski at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4
Stats:     98 lines in 46 files changed: 0 ins; 69 del; 29 mod

8289768: Clean up unused code

Reviewed-by: dfuchs, lancea, weijun, naoto, cjplummer, alanb, michaelm, chegar

-------------

PR: https://git.openjdk.org/jdk/pull/9383

From duke at openjdk.org  Thu Jul 14 22:09:43 2022
From: duke at openjdk.org (Bill Huang)
Date: Thu, 14 Jul 2022 22:09:43 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version
Message-ID: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>

This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

-------------

Commit messages:
 - Updated copyright header.
 - Converted FileDescriptorCount shell tests to java tests.

Changes: https://git.openjdk.org/jdk/pull/9503/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8290180
  Stats: 130 lines in 4 files changed: 7 ins; 119 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/9503.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9503/head:pull/9503

PR: https://git.openjdk.org/jdk/pull/9503

From lmesnik at openjdk.org  Thu Jul 14 22:26:02 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Thu, 14 Jul 2022 22:26:02 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version
In-Reply-To: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
Message-ID: <D9MLEUYUhBObN62xmYOzVFfrerLpo7rLIMaSA1RKTCQ=.1e9b422e-3e52-4501-be1a-b0090bf6d1dd@github.com>

On Thu, 14 Jul 2022 21:56:57 GMT, Bill Huang <duke at openjdk.org> wrote:

> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java line 29:

> 27:  * @summary Basic unit test of UnixOperatingSystemMXBean.getMaxFileDescriptorCount()
> 28:  * @author  Steve Bohne
> 29:  * @requires (os.family=="linux")

please add spaces, braces are not required, see examples in jtreg tests
@requires os.family == "linux"

test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java line 31:

> 29:  * @requires (os.family=="linux")
> 30:  *
> 31:  * @run main/othervm GetMaxFileDescriptorCount

is othervm required here?

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Thu Jul 14 22:41:02 2022
From: duke at openjdk.org (Bill Huang)
Date: Thu, 14 Jul 2022 22:41:02 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version
In-Reply-To: <D9MLEUYUhBObN62xmYOzVFfrerLpo7rLIMaSA1RKTCQ=.1e9b422e-3e52-4501-be1a-b0090bf6d1dd@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <D9MLEUYUhBObN62xmYOzVFfrerLpo7rLIMaSA1RKTCQ=.1e9b422e-3e52-4501-be1a-b0090bf6d1dd@github.com>
Message-ID: <e7OlF5ABQXX-uUA9zR1RACEfcze_4Fu37BzM2PLEFkg=.339b69ba-de22-47cd-a877-68bcba0b67a9@github.com>

On Thu, 14 Jul 2022 22:21:56 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> test/jdk/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.java line 31:
> 
>> 29:  * @requires (os.family=="linux")
>> 30:  *
>> 31:  * @run main/othervm GetMaxFileDescriptorCount
> 
> is othervm required here?

No, it is not needed. I will remove it.

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Thu Jul 14 22:46:09 2022
From: duke at openjdk.org (Bill Huang)
Date: Thu, 14 Jul 2022 22:46:09 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
Message-ID: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>

> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Removed othervm option and fixed @requires coding style.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9503/files
  - new: https://git.openjdk.org/jdk/pull/9503/files/69ed7ea8..13d99c69

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/9503.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9503/head:pull/9503

PR: https://git.openjdk.org/jdk/pull/9503

From lmesnik at openjdk.org  Thu Jul 14 22:46:10 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Thu, 14 Jul 2022 22:46:10 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <UIJXKjdyBSEo3rv44_E1fmf2Xn52pygtAozJNiavd_E=.307d7a49-fe54-46cf-afd2-f1069b47e9ac@github.com>

On Thu, 14 Jul 2022 22:42:45 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

Marked as reviewed by lmesnik (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From lmesnik at openjdk.org  Thu Jul 14 22:51:05 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Thu, 14 Jul 2022 22:51:05 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <Vw9owKoQugbyyW6n3ms_BK79hj7SZ7DDDFg1uxXK51U=.2f0beaca-643b-4723-9e27-276aea25924d@github.com>

On Thu, 14 Jul 2022 22:46:09 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

There are some possible cleanups in the tests (comments, unused args, variable name style) but seem out of scope for this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Thu Jul 14 22:58:03 2022
From: duke at openjdk.org (Bill Huang)
Date: Thu, 14 Jul 2022 22:58:03 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <hg1JStqaCi-rspxgWAWUgoPaceM5EYvHC4xaTW_RR94=.5793e3c2-71ff-4349-a9de-9fa789f4db48@github.com>

On Thu, 14 Jul 2022 22:46:09 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

It is not out of scope. I can do the clean up along with this PR. Can you please give me some hints what could be optimized?

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From amenkov at openjdk.org  Thu Jul 14 23:04:11 2022
From: amenkov at openjdk.org (Alex Menkov)
Date: Thu, 14 Jul 2022 23:04:11 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <qJ3tkayugc_l9JlJl9sa9WRsKiJ9tDRBXTS3NMixcfE=.08849111-8618-4dbd-8ac5-b76b8150d02c@github.com>

On Thu, 14 Jul 2022 22:46:09 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

Marked as reviewed by amenkov (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From lmesnik at openjdk.org  Thu Jul 14 23:04:11 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Thu, 14 Jul 2022 23:04:11 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <NQDLCKF7Apjs69rZNNpdWBbwBcJ_xY83pscOd5MVXEs=.97db0e26-5670-45a2-b6e0-43059f8e8f04@github.com>

On Thu, 14 Jul 2022 22:46:09 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

The variables should use camelCase. Like min_count_for_pass -> minCountForPass 
Variable trace not needed, just print count always
The mention of Solaris should be removed from comments, also I don't know if instructions for manual testing are needed, but it would be better to say "to know actual value run smth".

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From dholmes at openjdk.org  Fri Jul 15 01:59:58 2022
From: dholmes at openjdk.org (David Holmes)
Date: Fri, 15 Jul 2022 01:59:58 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
Message-ID: <xfwc_KNC6_sCcQAWzJ-IbmRzPo-4wlVOrpTHx2LIYy4=.64863c97-16c2-4a3b-b031-7ff7c2f7b8e6@github.com>

On Thu, 14 Jul 2022 22:46:09 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed othervm option and fixed @requires coding style.

Is the restriction to run on Linux actually still valid? Shouldn't this work on any of our Posix-like  platforms? I suspect you need to read "Linux" as "not Solaris or Windows" when looking at this test (and possibly others).

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Fri Jul 15 16:49:50 2022
From: duke at openjdk.org (Bill Huang)
Date: Fri, 15 Jul 2022 16:49:50 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <xfwc_KNC6_sCcQAWzJ-IbmRzPo-4wlVOrpTHx2LIYy4=.64863c97-16c2-4a3b-b031-7ff7c2f7b8e6@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
 <xfwc_KNC6_sCcQAWzJ-IbmRzPo-4wlVOrpTHx2LIYy4=.64863c97-16c2-4a3b-b031-7ff7c2f7b8e6@github.com>
Message-ID: <5ReLEM9TnAX_MEkB7Tc56BDXf7ASUgUhpcZ0ARZI7Kg=.2aea5792-5bf6-4853-990b-42c8fb824313@github.com>

On Fri, 15 Jul 2022 01:56:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed othervm option and fixed @requires coding style.
>
> Is the restriction to run on Linux actually still valid? Shouldn't this work on any of our Posix-like  platforms? I suspect you need to read "Linux" as "not Solaris or Windows" when looking at this test (and possibly others).

@dholmes-ora I agreed. These tests should be working on any unix-based system. I can change the restriction to be not Windows. The other question is should we include Solaris as it is also unix based.

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Fri Jul 15 17:55:55 2022
From: duke at openjdk.org (Bill Huang)
Date: Fri, 15 Jul 2022 17:55:55 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v3]
In-Reply-To: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
Message-ID: <CC1-Z8C5UidgTv6havh3cQzrLsm6MiJe0aq7tPJ90FE=.bf2015ff-0126-4273-ba0e-dc42527b3d0b@github.com>

> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Cleaned up tests and changed OS restriction to not windows.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9503/files
  - new: https://git.openjdk.org/jdk/pull/9503/files/13d99c69..76c46d03

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=01-02

  Stats: 53 lines in 2 files changed: 1 ins; 34 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/9503.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9503/head:pull/9503

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Fri Jul 15 18:02:58 2022
From: duke at openjdk.org (Bill Huang)
Date: Fri, 15 Jul 2022 18:02:58 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <NQDLCKF7Apjs69rZNNpdWBbwBcJ_xY83pscOd5MVXEs=.97db0e26-5670-45a2-b6e0-43059f8e8f04@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
 <NQDLCKF7Apjs69rZNNpdWBbwBcJ_xY83pscOd5MVXEs=.97db0e26-5670-45a2-b6e0-43059f8e8f04@github.com>
Message-ID: <h7hej0r1h1CFdh5d5GMVSrkX2oimgaZO5FOUOhgEw_4=.173bf4dc-6d61-43b2-9bb0-9f1a68e78ea8@github.com>

On Thu, 14 Jul 2022 23:01:50 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed othervm option and fixed @requires coding style.
>
> The variables should use camelCase. Like min_count_for_pass -> minCountForPass 
> Variable trace not needed, just print count always
> The mention of Solaris should be removed from comments, also I don't know if instructions for manual testing are needed, but it would be better to say "to know actual value run smth".

@lmesnik I've completely removed the comments for manual tests because I don't think manual tests are necessary in this scenario. If the purpose of the tests is to compare FD count from the Java API to the system properties, it can be done in automated tests. Potential test cases could be opening a new file and observing the opened FD count for increment, or checking the value from the system call. We can address this in a separate ticket if we want.

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From duke at openjdk.org  Fri Jul 15 18:09:08 2022
From: duke at openjdk.org (Bill Huang)
Date: Fri, 15 Jul 2022 18:09:08 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v4]
In-Reply-To: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
Message-ID: <hcecRnt04PpJe1DA99Q5HBi_Sx6bzbZw7XJSzCZ5Kok=.8d1a3c03-1099-4a19-9d60-4a5f259c50a9@github.com>

> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Removed unwanted whitespaces.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9503/files
  - new: https://git.openjdk.org/jdk/pull/9503/files/76c46d03..fed0b270

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9503&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/9503.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9503/head:pull/9503

PR: https://git.openjdk.org/jdk/pull/9503

From lmesnik at openjdk.org  Fri Jul 15 18:31:04 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Fri, 15 Jul 2022 18:31:04 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v4]
In-Reply-To: <hcecRnt04PpJe1DA99Q5HBi_Sx6bzbZw7XJSzCZ5Kok=.8d1a3c03-1099-4a19-9d60-4a5f259c50a9@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <hcecRnt04PpJe1DA99Q5HBi_Sx6bzbZw7XJSzCZ5Kok=.8d1a3c03-1099-4a19-9d60-4a5f259c50a9@github.com>
Message-ID: <q0EyagVUrUDKcuevkKzoyCsYCHLeBVtRRLp3np2Hs7w=.0df2d1a3-c768-4e35-8fdd-f48a8b09b345@github.com>

On Fri, 15 Jul 2022 18:09:08 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unwanted whitespaces.

Marked as reviewed by lmesnik (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From amenkov at openjdk.org  Fri Jul 15 21:40:03 2022
From: amenkov at openjdk.org (Alex Menkov)
Date: Fri, 15 Jul 2022 21:40:03 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v4]
In-Reply-To: <hcecRnt04PpJe1DA99Q5HBi_Sx6bzbZw7XJSzCZ5Kok=.8d1a3c03-1099-4a19-9d60-4a5f259c50a9@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <hcecRnt04PpJe1DA99Q5HBi_Sx6bzbZw7XJSzCZ5Kok=.8d1a3c03-1099-4a19-9d60-4a5f259c50a9@github.com>
Message-ID: <HqdEilMO_QBY4G7UlxagMOaIyg7vfNLjv3hwtJQVnlU=.f8e3ef42-87db-4f55-b045-f7befa632ad3@github.com>

On Fri, 15 Jul 2022 18:09:08 GMT, Bill Huang <duke at openjdk.org> wrote:

>> This is a task to convert shell tests to Java tests. The shell scripts to be removed are responsible for compiling Java files and running the tests on Linux systems. This functionality can be achieved with JTReg tag @requires (os.family=="linux").
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unwanted whitespaces.

Still good to me

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From dholmes at openjdk.org  Mon Jul 18 02:05:48 2022
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 18 Jul 2022 02:05:48 GMT
Subject: jmx-dev RFR: 8290180: Convert
 com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh
 to jtreg java version [v2]
In-Reply-To: <5ReLEM9TnAX_MEkB7Tc56BDXf7ASUgUhpcZ0ARZI7Kg=.2aea5792-5bf6-4853-990b-42c8fb824313@github.com>
References: <GVPRW0DDurIFj1uVCxI9vhNDSI8a_p3rPVx6PdqbO6E=.30a7ffe9-9ba8-4832-8f74-b98ae194c3c2@github.com>
 <4JMcN4QLYZVP1DmL8iAvHVj_Uw8GSRngxZtamOh6caU=.0855f1b8-3b07-4d4f-988a-f832a8b9cd88@github.com>
 <xfwc_KNC6_sCcQAWzJ-IbmRzPo-4wlVOrpTHx2LIYy4=.64863c97-16c2-4a3b-b031-7ff7c2f7b8e6@github.com>
 <5ReLEM9TnAX_MEkB7Tc56BDXf7ASUgUhpcZ0ARZI7Kg=.2aea5792-5bf6-4853-990b-42c8fb824313@github.com>
Message-ID: <E3QWbXWBLFQm8fHsDBNnwgVtTRyWO4orH4BvI8Svw0w=.8ba3eb75-1be1-40c0-9454-ae203ca8cd67@github.com>

On Fri, 15 Jul 2022 16:46:43 GMT, Bill Huang <duke at openjdk.org> wrote:

> The other question is should we include Solaris as it is also unix based.

@bwhuang-us there is no Solaris support in mainline.

-------------

PR: https://git.openjdk.org/jdk/pull/9503

From kevin.walls at oracle.com  Wed Jul 27 20:28:17 2022
From: kevin.walls at oracle.com (Kevin Walls)
Date: Wed, 27 Jul 2022 20:28:17 +0000
Subject: jmx-dev Proposed JEP: 8285724: Deprecate JMX M-Lets (Management
 Applets) for Removal
Message-ID: <MN2PR10MB3278638860CD17F3A579D9C097979@MN2PR10MB3278.namprd10.prod.outlook.com>

Hi,

Seeking any comments on this JEP proposal:

8285724: Deprecate JMX M-Lets (Management Applets) for Removal
https://bugs.openjdk.org/browse/JDK-8285724

Thanks
Kevin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jmx-dev/attachments/20220727/ec12c3ab/attachment.htm>