From duke at openjdk.java.net  Wed Jun  8 17:46:33 2022
From: duke at openjdk.java.net (XenoAmess)
Date: Wed, 8 Jun 2022 17:46:33 GMT
Subject: jmx-dev RFR: 8285149: Using HashMap.newHashMap to replace new
 HashMap(int) [v4]
In-Reply-To: <4K3rhX2RGM_yaCKKJALcP7EplXS2pJXM8zYGNGEg-6Y=.c03f7730-b26a-459a-8d60-ea8ab9149603@github.com>
References: <nbTEkGMOp3gIZCYq1vfhE1Zy1RDJsWFkUGQzVPM4gI0=.427e4dba-2ea2-48e5-9cdd-e3eade99096c@github.com>
 <zFlFjdt_WK9VyWsAxqnfhvu-MmJe1IKc7WtyBNkPE5A=.ec807db1-ad90-4e27-99d7-8a1ea145aa71@github.com>
 <S9LU83ceTWEKtLvzA4D63u3Qysv4rk6f83rZ7QvfR5E=.936ea9b1-c42b-47c7-8a98-4c8803c67fe8@github.com>
 <xW_IMRaU3A70QAxx5vnH990FVkxQnTq1EAf-F7rz3Nw=.17ca4b0e-ee2b-45bb-8cd1-c380bb6a0990@github.com>
 <4K3rhX2RGM_yaCKKJALcP7EplXS2pJXM8zYGNGEg-6Y=.c03f7730-b26a-459a-8d60-ea8ab9149603@github.com>
Message-ID: <I6KYBeCQX2UL3oyZRSoJS5kebHUgVdaeMie1rZaMmYo=.44589461-05c3-48f6-add0-9ef7fc6b7f69@github.com>

On Thu, 28 Apr 2022 16:33:48 GMT, XenoAmess <duke at openjdk.java.net> wrote:

>> I'm getting a bit tired of seeing these JDK wide changes with lots of files touched.
>> Delete all changes in desktop from this PR and re-submit them as a separate PR.
>> 
>> Also do not change J2DBench. We deliberately avoid using new API so that we can take it and
>> run it on very old JDK versions to help track regressions.
>
> @prrace
> 
>> Delete all changes in desktop from this PR and re-submit them as a separate PR.
> 
> changes to java.desktop reverted.
> 
>> Also do not change J2DBench. We deliberately avoid using new API so that we can take it and run it on very old JDK versions to help track regressions.
> 
> For J2DBench, I don't see any changes that not complicated with older jdk version for now. please recheck. thanks.

> @XenoAmess This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

comment

-------------

PR: https://git.openjdk.java.net/jdk/pull/8301

From lmesnik at openjdk.java.net  Thu Jun 16 00:31:37 2022
From: lmesnik at openjdk.java.net (Leonid Mesnik)
Date: Thu, 16 Jun 2022 00:31:37 GMT
Subject: jmx-dev RFR: 8179227:
 com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total
 swap size ... but getTotalSwapSpaceSize returned ...
Message-ID: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>

The failure is very intermittent and I wasn't able to reproduce it.

I suspect that the swap might be changed during test execution so I add the corresponding check. 

If test still fails after fix we should at least exclude this potential problem.

-------------

Commit messages:
 - 8179227

Changes: https://git.openjdk.org/jdk/pull/9174/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9174&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8179227
  Stats: 33 lines in 1 file changed: 14 ins; 16 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/9174.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9174/head:pull/9174

PR: https://git.openjdk.org/jdk/pull/9174

From jwilhelm at openjdk.java.net  Thu Jun 16 07:09:00 2022
From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson)
Date: Thu, 16 Jun 2022 07:09:00 GMT
Subject: jmx-dev RFR: Merge jdk19
Message-ID: <3ke8kqVmpxVV01b8rL7MU8DWpDvHrqBHC7Oj4O83c5g=.dafbc6b1-9798-4182-bbbb-cbb5f035586d@github.com>

Forwardport JDK 19 -> JDK 20

-------------

Commit messages:
 - Merge
 - 8288533: Missing @param tags in com.sun.source classes
 - 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
 - 8288414: Long::compress/expand samples are not correct
 - 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
 - 8288324: Loom: Uninitialized JvmtiEnvs in VM_Virtual* ops
 - 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
 - 8287889: (fs) Files.copy description of REPLACE_EXISTING is hard to read
 - 8288303: C1: Miscompilation due to broken Class.getModifiers intrinsic
 - 8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed
 - ... and 1 more: https://git.openjdk.org/jdk/compare/39526e28...8b43a607

The webrevs contain the adjustments done while merging with regards to each parent branch:
 - master: https://webrevs.openjdk.org/?repo=jdk&pr=9179&range=00.0
 - jdk19: https://webrevs.openjdk.org/?repo=jdk&pr=9179&range=00.1

Changes: https://git.openjdk.org/jdk/pull/9179/files
  Stats: 254 lines in 17 files changed: 193 ins; 13 del; 48 mod
  Patch: https://git.openjdk.org/jdk/pull/9179.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9179/head:pull/9179

PR: https://git.openjdk.org/jdk/pull/9179

From jwilhelm at openjdk.org  Thu Jun 16 12:05:20 2022
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 16 Jun 2022 12:05:20 GMT
Subject: jmx-dev Integrated: Merge jdk19
In-Reply-To: <3ke8kqVmpxVV01b8rL7MU8DWpDvHrqBHC7Oj4O83c5g=.dafbc6b1-9798-4182-bbbb-cbb5f035586d@github.com>
References: <3ke8kqVmpxVV01b8rL7MU8DWpDvHrqBHC7Oj4O83c5g=.dafbc6b1-9798-4182-bbbb-cbb5f035586d@github.com>
Message-ID: <jE5ZH0NidXVkm_bPpXtl0UPI_FXUl9NK5fQyfDq6Cvg=.57654ad5-3d0b-4019-a178-2777c19d9611@github.com>

On Thu, 16 Jun 2022 07:00:53 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Forwardport JDK 19 -> JDK 20

This pull request has now been integrated.

Changeset: 3d12c022
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3d12c0225b31bb359bec70aac6befd879cd0c934
Stats:     254 lines in 17 files changed: 193 ins; 13 del; 48 mod

Merge

-------------

PR: https://git.openjdk.org/jdk/pull/9179

From sspitsyn at openjdk.org  Thu Jun 16 16:38:46 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Thu, 16 Jun 2022 16:38:46 GMT
Subject: jmx-dev RFR: 8288599:
 com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total
 swap size ... but getTotalSwapSpaceSize returned ...
In-Reply-To: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
References: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
Message-ID: <WIcvTtQc9hcsqrSKw0kCuIou3w5TLETqcgxd-wOpSbs=.8873fdcd-d879-4ec5-9228-09cd7585a35e@github.com>

On Thu, 16 Jun 2022 00:23:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The failure is very intermittent and I wasn't able to reproduce it.
> 
> I suspect that the swap might be changed during test execution so I add the corresponding check. 
> 
> If test still fails after fix we should at least exclude this potential problem.

Looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9174

From kevinw at openjdk.org  Fri Jun 17 11:53:52 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Fri, 17 Jun 2022 11:53:52 GMT
Subject: jmx-dev RFR: 8288599:
 com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total
 swap size ... but getTotalSwapSpaceSize returned ...
In-Reply-To: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
References: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
Message-ID: <QvdzoRlAnFwbccHZbq8rPed2v3TXMDQiJg0P7g6YzLA=.428100a6-7d03-4537-955d-da6966891fef@github.com>

On Thu, 16 Jun 2022 00:23:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The failure is very intermittent and I wasn't able to reproduce it.
> 
> I suspect that the swap might be changed during test execution so I add the corresponding check. 
> 
> If test still fails after fix we should at least exclude this potential problem.

Marked as reviewed by kevinw (Committer).

test/jdk/com/sun/management/OperatingSystemMXBean/TestTotalSwap.java line 76:

> 74: 
> 75:         // if swap data from OS chnaged re-read OS and MBean data
> 76:         while (expected_swap_size != getSwapSizeFromOs()) {

Can we put a limit on this?
OS swap usage could be continually changing, this seems worth a try but we want to escape and give up after some number of tries?
If there is some variation that's making us fail, we could also mask off some number of low bits, or a byte or more even, to do an approximate comparison?  Might want to try that if retrying does not succeed.

-------------

PR: https://git.openjdk.org/jdk/pull/9174

From jwilhelm at openjdk.org  Fri Jun 17 12:24:19 2022
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 17 Jun 2022 12:24:19 GMT
Subject: jmx-dev RFR: Merge jdk19
Message-ID: <iAAt-vOyoM8VX3hFOWbmy1AVrFxNuBLzw1dRbe6E4IY=.96c7e0d9-668c-459f-be99-570db613cfa9@github.com>

Forwardport JDK 19 -> JDK 20

-------------

Commit messages:
 - Merge
 - 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
 - 8287401: jpackage tests failing on Windows due to powershell issue
 - 8288534: Out of bound errors for memory segment access mentions wrong values

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk/pull/9197/files
  Stats: 50 lines in 14 files changed: 25 ins; 3 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/9197.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9197/head:pull/9197

PR: https://git.openjdk.org/jdk/pull/9197

From jwilhelm at openjdk.org  Fri Jun 17 13:50:58 2022
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 17 Jun 2022 13:50:58 GMT
Subject: jmx-dev Integrated: Merge jdk19
In-Reply-To: <iAAt-vOyoM8VX3hFOWbmy1AVrFxNuBLzw1dRbe6E4IY=.96c7e0d9-668c-459f-be99-570db613cfa9@github.com>
References: <iAAt-vOyoM8VX3hFOWbmy1AVrFxNuBLzw1dRbe6E4IY=.96c7e0d9-668c-459f-be99-570db613cfa9@github.com>
Message-ID: <x6UTZXwCO29ezzLkLFigvnD4BaqyXY-69f8ivIwKPcc=.e384ca8e-0fe4-431e-a0c5-8384907fff3a@github.com>

On Fri, 17 Jun 2022 12:16:32 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Forwardport JDK 19 -> JDK 20

This pull request has now been integrated.

Changeset: af64d316
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/af64d316c0f687c4ceab7591e050449c64e3babc
Stats:     50 lines in 14 files changed: 25 ins; 3 del; 22 mod

Merge

-------------

PR: https://git.openjdk.org/jdk/pull/9197

From lmesnik at openjdk.org  Fri Jun 17 20:03:01 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Fri, 17 Jun 2022 20:03:01 GMT
Subject: jmx-dev RFR: 8288599:
 com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total
 swap size ... but getTotalSwapSpaceSize returned ...
In-Reply-To: <QvdzoRlAnFwbccHZbq8rPed2v3TXMDQiJg0P7g6YzLA=.428100a6-7d03-4537-955d-da6966891fef@github.com>
References: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
 <QvdzoRlAnFwbccHZbq8rPed2v3TXMDQiJg0P7g6YzLA=.428100a6-7d03-4537-955d-da6966891fef@github.com>
Message-ID: <-y8zfGeqiyXKNilAcxSYhltZwvFamziNXbSSS_qVq4U=.970d9b80-58e8-435e-9a1f-29d913be7d98@github.com>

On Fri, 17 Jun 2022 11:50:08 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> The failure is very intermittent and I wasn't able to reproduce it.
>> 
>> I suspect that the swap might be changed during test execution so I add the corresponding check. 
>> 
>> If test still fails after fix we should at least exclude this potential problem.
>
> test/jdk/com/sun/management/OperatingSystemMXBean/TestTotalSwap.java line 76:
> 
>> 74: 
>> 75:         // if swap data from OS chnaged re-read OS and MBean data
>> 76:         while (expected_swap_size != getSwapSizeFromOs()) {
> 
> Can we put a limit on this?
> OS swap usage could be continually changing, this seems worth a try but we want to escape and give up after some number of tries?
> If there is some variation that's making us fail, we could also mask off some number of low bits, or a byte or more even, to do an approximate comparison?  Might want to try that if retrying does not succeed.

I doubt that swap might change so often. The failure is reproduced once in several months.
Let's check the logs if the test failed.

-------------

PR: https://git.openjdk.org/jdk/pull/9174

From lmesnik at openjdk.org  Tue Jun 21 18:41:30 2022
From: lmesnik at openjdk.org (Leonid Mesnik)
Date: Tue, 21 Jun 2022 18:41:30 GMT
Subject: jmx-dev Integrated: 8288599:
 com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total
 swap size ... but getTotalSwapSpaceSize returned ...
In-Reply-To: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
References: <vF-k4J6b0MXybGWWtPHEy0u8uFalGofqsXzC8OHrAVY=.8d1a05ee-fc19-4694-b055-5d12c09dc9e9@github.com>
Message-ID: <vvKqfL4w0n6DZ1NzUjfzfFJZ5nswDf7PYbFHQ6yRraw=.bba4c295-0747-491e-a2a5-885aae960fd6@github.com>

On Thu, 16 Jun 2022 00:23:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The failure is very intermittent and I wasn't able to reproduce it.
> 
> I suspect that the swap might be changed during test execution so I add the corresponding check. 
> 
> If test still fails after fix we should at least exclude this potential problem.

This pull request has now been integrated.

Changeset: f0804304
Author:    Leonid Mesnik <lmesnik at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f0804304400f380661a8a06e4c1dad97068fae60
Stats:     33 lines in 1 file changed: 14 ins; 16 del; 3 mod

8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...

Reviewed-by: sspitsyn, kevinw

-------------

PR: https://git.openjdk.org/jdk/pull/9174