From iklam at openjdk.java.net  Tue May 10 04:09:57 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Tue, 10 May 2022 04:09:57 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
Message-ID: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>

The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.

It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.

I also cleaned up related code in the JDK and HotSpot.

Testing:
- Passed tiers 1 and 2
- Tiers 3, 4, 5 are in progress

-------------

Commit messages:
 - 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()

Changes: https://git.openjdk.java.net/jdk/pull/8622/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8622&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286441
  Stats: 193 lines in 15 files changed: 0 ins; 144 del; 49 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8622.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8622/head:pull/8622

PR: https://git.openjdk.java.net/jdk/pull/8622

From alanb at openjdk.java.net  Tue May 10 20:02:48 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Tue, 10 May 2022 20:02:48 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
Message-ID: <dPmSVzIHGfwcmaJTIGwDS6O9Ppl0QAcBYbGDwqaFDJU=.480f6a7b-5da5-4fc9-8e13-2c678e605465@github.com>

On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
> 
> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
> 
> I also cleaned up related code in the JDK and HotSpot.
> 
> Testing:
> - Passed tiers 1 and 2
> - Tiers 3, 4, 5 are in progress

src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/PerfDataBuffer.java line 60:

> 58:             FileChannel fc = new RandomAccessFile(f, "r").getChannel();
> 59:             ByteBuffer bb = fc.map(FileChannel.MapMode.READ_ONLY, 0L, (int)fc.size());
> 60:             fc.close();               // doesn't need to remain open

I think you can change this to:


        try (FileChannel fc = FileChannel.open(f.toPath())) {
            ByteBuffer bb = ...
            createPerfDataBuffer(bb, 0);
        }

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From alanb at openjdk.java.net  Tue May 10 20:06:47 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Tue, 10 May 2022 20:06:47 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
Message-ID: <fJVbOoDRaDA37EScdewg0G4nCyTzYZ2M4ZXWY_ubpoQ=.1be2132e-0af9-4a36-a9ee-33cc182f745d@github.com>

On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
> 
> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
> 
> I also cleaned up related code in the JDK and HotSpot.
> 
> Testing:
> - Passed tiers 1 and 2
> - Tiers 3, 4, 5 are in progress

I skimmed through the changes and I think they look okay. In the distant past there were tools outside of the JDK that used the jvmstat API directly. It's possible that VisualVM still does but it would only compile/run if --add-exports is used to export the sun.jvmstat.* packages. So it might be that dropping the parameter from a method in RemoteHost is noticed and I think that is okay because this package is not exported and is not meant to be used by code outside of the JDK.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From redestad at openjdk.java.net  Tue May 10 21:47:50 2022
From: redestad at openjdk.java.net (Claes Redestad)
Date: Tue, 10 May 2022 21:47:50 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
Message-ID: <5AjTeD3XkuyBV8Dux7QVRkJgDwTiJ4Et9303eiMLjNU=.84477522-bbdb-4215-976f-729910707634@github.com>

On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
> 
> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
> 
> I also cleaned up related code in the JDK and HotSpot.
> 
> Testing:
> - Passed tiers 1 and 2
> - Tiers 3, 4, 5 are in progress

Nice cleanup!

(Some stylistic suggestions inline, feel free to ignore)

src/hotspot/os/windows/perfMemory_windows.cpp line 1781:

> 1779: // address space.
> 1780: //
> 1781: void PerfMemory::attach(const char* user, int vmid,

One line?

src/hotspot/share/prims/perf.cpp line 84:

> 82: 
> 83:   // attach to the PerfData memory region for the specified VM
> 84:   PerfMemory::attach(user_utf, vmid,

One line?

src/hotspot/share/runtime/perfMemory.hpp line 146:

> 144:     // methods for attaching to and detaching from the PerfData
> 145:     // memory segment of another JVM process on the same system.
> 146:     static void attach(const char* user, int vmid,

One line?

src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java line 74:

> 72:         Integer v = lvmid;
> 73:         RemoteVm stub = null;
> 74:         StringBuilder sb = new StringBuilder();

Suggestion:

        String vmidStr = "local://" + lvmid + "@localhost";

-------------

Marked as reviewed by redestad (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 02:43:21 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 02:43:21 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach() [v2]
In-Reply-To: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
Message-ID: <nJ3YUlzlAvMknJJxLkByfKxWQJ-2vYUFhJhC4DRyrCY=.9e4b5a6b-69cd-4792-89dc-94b3b1664d99@github.com>

> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
> 
> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
> 
> I also cleaned up related code in the JDK and HotSpot.
> 
> Testing:
> - Passed tiers 1 and 2
> - Tiers 3, 4, 5 are in progress

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8622/files
  - new: https://git.openjdk.java.net/jdk/pull/8622/files/22c22c30..34a01f71

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8622&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8622&range=00-01

  Stats: 14 lines in 5 files changed: 1 ins; 7 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8622.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8622/head:pull/8622

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 02:43:24 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 02:43:24 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach() [v2]
In-Reply-To: <5AjTeD3XkuyBV8Dux7QVRkJgDwTiJ4Et9303eiMLjNU=.84477522-bbdb-4215-976f-729910707634@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
 <5AjTeD3XkuyBV8Dux7QVRkJgDwTiJ4Et9303eiMLjNU=.84477522-bbdb-4215-976f-729910707634@github.com>
Message-ID: <h_uM9CtM8JppYGlFDCZ6-xLM2MWY7kB2K6yuFrwzCvU=.ae2e89b3-2862-48ba-82a9-17bfcc37d777@github.com>

On Tue, 10 May 2022 21:43:44 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 1781:
> 
>> 1779: // address space.
>> 1780: //
>> 1781: void PerfMemory::attach(const char* user, int vmid,
> 
> One line?

Fixed

> src/hotspot/share/prims/perf.cpp line 84:
> 
>> 82: 
>> 83:   // attach to the PerfData memory region for the specified VM
>> 84:   PerfMemory::attach(user_utf, vmid,
> 
> One line?

Fixed

> src/hotspot/share/runtime/perfMemory.hpp line 146:
> 
>> 144:     // methods for attaching to and detaching from the PerfData
>> 145:     // memory segment of another JVM process on the same system.
>> 146:     static void attach(const char* user, int vmid,
> 
> One line?

Fixed

> src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java line 74:
> 
>> 72:         Integer v = lvmid;
>> 73:         RemoteVm stub = null;
>> 74:         StringBuilder sb = new StringBuilder();
> 
> Suggestion:
> 
>         String vmidStr = "local://" + lvmid + "@localhost";

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 02:43:25 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 02:43:25 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach() [v2]
In-Reply-To: <dPmSVzIHGfwcmaJTIGwDS6O9Ppl0QAcBYbGDwqaFDJU=.480f6a7b-5da5-4fc9-8e13-2c678e605465@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
 <dPmSVzIHGfwcmaJTIGwDS6O9Ppl0QAcBYbGDwqaFDJU=.480f6a7b-5da5-4fc9-8e13-2c678e605465@github.com>
Message-ID: <BMNhbA9nWHe8hI992LIuX9duAoUDuVQjuvA5iJRG1I4=.39fc8993-d6ce-4019-ae82-2eb190c36683@github.com>

On Tue, 10 May 2022 19:59:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/PerfDataBuffer.java line 60:
> 
>> 58:             FileChannel fc = new RandomAccessFile(f, "r").getChannel();
>> 59:             ByteBuffer bb = fc.map(FileChannel.MapMode.READ_ONLY, 0L, (int)fc.size());
>> 60:             fc.close();               // doesn't need to remain open
> 
> I think you can change this to:
> 
> 
>         try (FileChannel fc = FileChannel.open(f.toPath())) {
>             ByteBuffer bb = ...
>             createPerfDataBuffer(bb, 0);
>         }

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 02:52:47 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 02:52:47 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <fJVbOoDRaDA37EScdewg0G4nCyTzYZ2M4ZXWY_ubpoQ=.1be2132e-0af9-4a36-a9ee-33cc182f745d@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
 <fJVbOoDRaDA37EScdewg0G4nCyTzYZ2M4ZXWY_ubpoQ=.1be2132e-0af9-4a36-a9ee-33cc182f745d@github.com>
Message-ID: <t8HcObumyWDO7DRRif0BR4CLXxRE921QnzaVcUlYUew=.c26c55ad-a64a-4198-97d2-c3db486ba9c7@github.com>

On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> I skimmed through the changes and I think they look okay. In the distant past there were tools outside of the JDK that used the jvmstat API directly. It's possible that VisualVM still does but it would only compile/run if --add-exports is used to export the sun.jvmstat.* packages. So it might be that dropping the parameter from a method in RemoteHost is noticed and I think that is okay because this package is not exported and is not meant to be used by code outside of the JDK.

The APIs changed by this PR are:

- sun.jvmstat.monitor.remote.RemoteHost::attachVm
- sun.jvmstat.monitor.VmIdentifier::getMode
- sun.jvmstat.monitor.HostIdentifier::getMode
- jdk.internal.perf.Perf::attach

I checked the latest VisualVM source code. Some of the above classes are referenced, but none of the affected APIs are called.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From alanb at openjdk.java.net  Wed May 11 18:12:53 2022
From: alanb at openjdk.java.net (Alan Bateman)
Date: Wed, 11 May 2022 18:12:53 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach() [v2]
In-Reply-To: <nJ3YUlzlAvMknJJxLkByfKxWQJ-2vYUFhJhC4DRyrCY=.9e4b5a6b-69cd-4792-89dc-94b3b1664d99@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
 <nJ3YUlzlAvMknJJxLkByfKxWQJ-2vYUFhJhC4DRyrCY=.9e4b5a6b-69cd-4792-89dc-94b3b1664d99@github.com>
Message-ID: <_-q4dXADJO6xSX8M9-NhCN7WcPzea67b7Dr6VTru5Ug=.f06265df-c88e-40ab-8955-dfdf00157dab@github.com>

On Wed, 11 May 2022 02:43:21 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
>> 
>> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
>> 
>> I also cleaned up related code in the JDK and HotSpot.
>> 
>> Testing:
>> - Passed tiers 1 and 2
>> - Tiers 3, 4, 5 are in progress
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 19:29:57 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 19:29:57 GMT
Subject: jmx-dev RFR: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <fJVbOoDRaDA37EScdewg0G4nCyTzYZ2M4ZXWY_ubpoQ=.1be2132e-0af9-4a36-a9ee-33cc182f745d@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
 <fJVbOoDRaDA37EScdewg0G4nCyTzYZ2M4ZXWY_ubpoQ=.1be2132e-0af9-4a36-a9ee-33cc182f745d@github.com>
Message-ID: <LvpF1pmJ9MSZD7OYitX5Q_jy2uJSNG1cUZWY3KywhyU=.8080bd6b-2b9d-4992-81cf-39d8ed158cf9@github.com>

On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
>> 
>> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
>> 
>> I also cleaned up related code in the JDK and HotSpot.
>> 
>> Testing:
>> - Passed tiers 1 ~ 5
>
> I skimmed through the changes and I think they look okay. In the distant past there were tools outside of the JDK that used the jvmstat API directly. It's possible that VisualVM still does but it would only compile/run if --add-exports is used to export the sun.jvmstat.* packages. So it might be that dropping the parameter from a method in RemoteHost is noticed and I think that is okay because this package is not exported and is not meant to be used by code outside of the JDK.

Thanks to @AlanBateman and @cl4es for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From iklam at openjdk.java.net  Wed May 11 19:29:59 2022
From: iklam at openjdk.java.net (Ioi Lam)
Date: Wed, 11 May 2022 19:29:59 GMT
Subject: jmx-dev Integrated: 8286441: Remove mode parameter from
 jdk.internal.perf.Perf.attach()
In-Reply-To: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
References: <v4jlLM5QuBflwl2OztKHBEscTqbTKarmP6sp2W2322o=.f216f27a-38fd-4296-8f18-3a45f60ed052@github.com>
Message-ID: <c5o6SCVcv3i5y1sOxqKYcrktFjB-Wwxr4Fzj8xwIULs=.3f841139-5230-4357-b88c-568e93e453fe@github.com>

On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported the value `"rw"` since the source code was imported to the openjdk repo more than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode is specified.
> 
> It's unlikely such a mode will be required for future enhancements. Support for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the only supported mode.
> 
> I also cleaned up related code in the JDK and HotSpot.
> 
> Testing:
> - Passed tiers 1 ~ 5

This pull request has now been integrated.

Changeset: fcf49f42
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fcf49f42cef4ac3e50b3b480aecf6fa38cf5be00
Stats:     205 lines in 15 files changed: 3 ins; 153 del; 49 mod

8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()

Reviewed-by: redestad, alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622

From ihse at openjdk.java.net  Fri May 13 15:14:43 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 13 May 2022 15:14:43 GMT
Subject: jmx-dev RFR: 8285366: Fix typos in serviceability [v2]
In-Reply-To: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
References: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
Message-ID: <de2J9hbH6Geo9BTK6iIPUAZGlDY6rV_RKI5-3GAir1U=.95c6f093-6bc8-4335-935e-7f2965325a57@github.com>

> I ran `codespell` on modules owned by the serviceability team (`java.instrument java.management.rmi java.management jdk.attach jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd jdk.management.agent jdk.management`), and accepted those changes where it indeed discovered real typos.
> 
> 
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
> 
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Revert "invocable"

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8334/files
  - new: https://git.openjdk.java.net/jdk/pull/8334/files/4b26668d..ad36a59a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8334&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8334&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8334.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8334/head:pull/8334

PR: https://git.openjdk.java.net/jdk/pull/8334

From ihse at openjdk.java.net  Fri May 13 15:18:26 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 13 May 2022 15:18:26 GMT
Subject: jmx-dev RFR: 8285366: Fix typos in serviceability [v3]
In-Reply-To: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
References: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
Message-ID: <spv7AmHQlRMq1ecLah808rHAow8zcvCViF_El1OX_ho=.8361392e-4647-44d9-8219-6724f232d2aa@github.com>

> I ran `codespell` on modules owned by the serviceability team (`java.instrument java.management.rmi java.management jdk.attach jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd jdk.management.agent jdk.management`), and accepted those changes where it indeed discovered real typos.
> 
> 
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
> 
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8334/files
  - new: https://git.openjdk.java.net/jdk/pull/8334/files/ad36a59a..4490ef75

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8334&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8334&range=01-02

  Stats: 117 lines in 117 files changed: 0 ins; 0 del; 117 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8334.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8334/head:pull/8334

PR: https://git.openjdk.java.net/jdk/pull/8334

From ihse at openjdk.java.net  Fri May 13 15:20:38 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 13 May 2022 15:20:38 GMT
Subject: jmx-dev Integrated: 8285366: Fix typos in serviceability
In-Reply-To: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
References: <3BDXgNscMXk8wYsWooUxX0e-jJXTHMCdSBR1nxvrM3U=.3f0ea3bd-2b82-4940-8bf6-cca605d7a183@github.com>
Message-ID: <31om9CILXc-UyN6Rbq8TQ3rgRgKopMrAlzF0o2hp84c=.2c91e2cd-08e2-400f-b320-19444106d5ad@github.com>

On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> I ran `codespell` on modules owned by the serviceability team (`java.instrument java.management.rmi java.management jdk.attach jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi jdk.jdwp.agent jdk.jstatd jdk.management.agent jdk.management`), and accepted those changes where it indeed discovered real typos.
> 
> 
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
> 
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.

This pull request has now been integrated.

Changeset: 76caeed4
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/76caeed498d868c7923461fb481349c0a2cbd99d
Stats:     303 lines in 136 files changed: 0 ins; 0 del; 303 mod

8285366: Fix typos in serviceability

Reviewed-by: kevinw, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/8334

From aivanov at openjdk.java.net  Wed May 18 14:53:28 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Wed, 18 May 2022 14:53:28 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in source
 code
Message-ID: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>

Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?

It's the last issue in the series, and it still touches different areas of the code.

-------------

Commit messages:
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'an? an?' in source code
 - 8284209: Replace remaining usages of 'a the' in source code
 - 8284209: Replace remaining usages of 'an the' in source code
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/69ff86a3...8290c07e

Changes: https://git.openjdk.java.net/jdk/pull/8771/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8771&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284209
  Stats: 51 lines in 41 files changed: 0 ins; 2 del; 49 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

From lancea at openjdk.java.net  Wed May 18 14:59:56 2022
From: lancea at openjdk.java.net (Lance Andersen)
Date: Wed, 18 May 2022 14:59:56 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <H0aIQ5SRJgWgvc_Hp8Y6ClzE86lEOzNYOKiV56ueWU0=.9bf1a830-fb68-4f70-a254-3b5d182739ae@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8771

From wetmore at openjdk.java.net  Wed May 18 15:19:55 2022
From: wetmore at openjdk.java.net (Bradford Wetmore)
Date: Wed, 18 May 2022 15:19:55 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <BlEMdHGx8wwWoDnuSLakASovW6f-yse6TPC3pbF6bcE=.8caab0de-e0bf-457d-883e-ae779ccff635@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Looked at 

-java.security.jgss.

LGTM

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8771

From dfuchs at openjdk.java.net  Wed May 18 16:07:52 2022
From: dfuchs at openjdk.java.net (Daniel Fuchs)
Date: Wed, 18 May 2022 16:07:52 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <hqiM9eFHWbK89Zfb-ZaJGalvghiDsyvw09l6hQI8YxA=.6cb984f1-c988-4f52-bd07-406a5362fe70@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Logging/JNDI OK

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8771

From iris at openjdk.java.net  Wed May 18 17:04:50 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Wed, 18 May 2022 17:04:50 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <KFAmufl8fur2ZWbG3C6rN_8h7oficN_4ViuHJ7hfvg4=.3ee598c2-3fd1-4344-bd94-89459431f74b@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8771

From jjg at openjdk.java.net  Wed May 18 22:06:44 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 18 May 2022 22:06:44 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <aEkG0OZ86yGP3oWxO4p1nrLGfm0uEdI0SOvg4EczMaY=.c368691e-af13-46dc-8e60-b664f8094e00@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

javac and javadoc changes look OK

test/langtools/tools/javac/modules/T8168854/module-info.java line 4:

> 2:  * @test
> 3:  * @bug 8168854
> 4:  * @summary javac erroneously reject a service interface inner class in a provides clause

FYI, this duplication was in the JBS issue summary; now fixed there.

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8771

From ihse at openjdk.java.net  Fri May 20 08:42:44 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Fri, 20 May 2022 08:42:44 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <RmHbfRXO30BBvfEUmUW7R2l6YV8gOypiJVRi-E1Z40E=.2275399d-8168-4fd2-8f39-2a6be94db1db@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Build changes look good. Thanks for the cleanup!

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8771

From aivanov at openjdk.java.net  Mon May 23 20:46:23 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Mon, 23 May 2022 20:46:23 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code [v2]
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <6pmdug3Hpy1LPgcb-OIdMP6XuOWpWYngOju7mFPdDV4=.a68d1c15-58a3-4ffa-b94d-a1a14666f9eb@github.com>

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - Merge master
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the a' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'the the' in source code
 - 8284209: Replace remaining usages of 'an? an?' in source code
 - 8284209: Replace remaining usages of 'a the' in source code
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/5b7d066c...fab0a4bb

-------------

Changes: https://git.openjdk.java.net/jdk/pull/8771/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8771&range=01
  Stats: 50 lines in 40 files changed: 0 ins; 2 del; 48 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

From aivanov at openjdk.java.net  Tue May 24 09:52:29 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Tue, 24 May 2022 09:52:29 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code [v3]
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <yDxT1sZCfM9b18MbUqSFDeyieqOfB5aBWMLKNxZEeYg=.8278ad27-ca58-4bf7-a236-d79604a6bff9@github.com>

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright to 2022

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8771/files
  - new: https://git.openjdk.java.net/jdk/pull/8771/files/fab0a4bb..4d529f79

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8771&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8771&range=01-02

  Stats: 24 lines in 24 files changed: 0 ins; 0 del; 24 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8771/head:pull/8771

PR: https://git.openjdk.java.net/jdk/pull/8771

From lancea at openjdk.java.net  Tue May 24 09:58:42 2022
From: lancea at openjdk.java.net (Lance Andersen)
Date: Tue, 24 May 2022 09:58:42 GMT
Subject: jmx-dev RFR: 8284209: Replace remaining usages of 'a the' in
 source code [v3]
In-Reply-To: <yDxT1sZCfM9b18MbUqSFDeyieqOfB5aBWMLKNxZEeYg=.8278ad27-ca58-4bf7-a236-d79604a6bff9@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
 <yDxT1sZCfM9b18MbUqSFDeyieqOfB5aBWMLKNxZEeYg=.8278ad27-ca58-4bf7-a236-d79604a6bff9@github.com>
Message-ID: <orVtBes_pss1zNktMdUeKjQeZmAHhREnRo2NXmb4Ip0=.deb262e2-aa59-4235-9308-4232698603d2@github.com>

On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
>> 
>> It's the last issue in the series, and it still touches different areas of the code.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright to 2022

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8771

From aivanov at openjdk.java.net  Tue May 24 20:12:09 2022
From: aivanov at openjdk.java.net (Alexey Ivanov)
Date: Tue, 24 May 2022 20:12:09 GMT
Subject: jmx-dev Integrated: 8284209: Replace remaining usages of 'a the' in
 source code
In-Reply-To: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
References: <ewmTp7ccQjOPMRtn1liuiPkStFACC1nyQeM6kTzjFFg=.1671b250-90fb-47f9-90dc-1828e316c4a8@github.com>
Message-ID: <JXgQy5enWm0flv2yyi6KK36WsHpPuZHj8uhkz_P13H0=.b9d1bc0a-ad41-416a-ab60-22c8271b9413@github.com>

On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the?
> 
> It's the last issue in the series, and it still touches different areas of the code.

This pull request has now been integrated.

Changeset: 9b7e42c0
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/9b7e42c0f078db778dda1011d85cd92e3e4eb979
Stats:     74 lines in 40 files changed: 0 ins; 2 del; 72 mod

8284209: Replace remaining usages of 'a the' in source code

Reviewed-by: lancea, wetmore, dfuchs, iris, jjg, ihse

-------------

PR: https://git.openjdk.java.net/jdk/pull/8771