From dfuchs at openjdk.org  Tue Nov  1 12:21:13 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Tue, 1 Nov 2022 12:21:13 GMT
Subject: jmx-dev RFR: 8295729: Add jcheck whitespace checking for
 properties files [v3]
In-Reply-To: <zIAGVqLBXo50aa5WRbe56xpkKVEyHv0FEk4gwRXlpXg=.55305d94-5232-4a29-beea-31f54b52626c@github.com>
References: <nUcyMLQqktyxHgKYhpjitMYsI4IzEw4tZqFe0L6ioH4=.56ee2f1e-48b0-41f6-a852-cbe6f99edaeb@github.com>
 <zIAGVqLBXo50aa5WRbe56xpkKVEyHv0FEk4gwRXlpXg=.55305d94-5232-4a29-beea-31f54b52626c@github.com>
Message-ID: <A4qnEed0y9IwAfcxrUtVyXLkcuaHKUlwps8MVVFUAyw=.042a86fd-8c9c-498d-8172-606712c83849@github.com>

On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes.
>> 
>> With the new Skara jcheck, it is possible to increase the coverage of the whitespace checks (in the old mercurial version, this was more or less impossible).
>> 
>> The only manual change is to `.jcheck/conf`. All other changes were made by running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "Remove check for .properties from jcheck"
>    
>    This reverts commit c91fdaa19dc06351598bd1c0614e1af3bfa08ae2.
>  - Change trailing space and tab in values to unicode encoding

Changes to java (resp sun) .util.logging tests and javax.management tests look good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10792

From mchhipa at openjdk.org  Fri Nov  4 15:21:10 2022
From: mchhipa at openjdk.org (Mahendra Chhipa)
Date: Fri, 4 Nov 2022 15:21:10 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v3]
In-Reply-To: <qWE-amaTygY7zpnTiw-Posy9H4JLslqXLGkb86rqg3o=.d95dd7d5-0022-4a93-bc22-85fc7861bcb6@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <qWE-amaTygY7zpnTiw-Posy9H4JLslqXLGkb86rqg3o=.d95dd7d5-0022-4a93-bc22-85fc7861bcb6@github.com>
Message-ID: <BwtKbeSfkbw4hYLRSv34x95SbBjERsPd-v0mqUj88U0=.e5dff6b0-69c1-4014-94b4-6f538d4b68df@github.com>

On Thu, 27 Oct 2022 19:08:06 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
>> 
>> Tests include: 
>> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
>> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
>> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverted exclusion of nonlocal registry tests.

test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalRegistryBase.java line 31:

> 29:     static final String instructions =
> 30:             "This is a manual test that requires rmiregistry run on a different host"
> 31:                     + ". Login or ssh to a different host, install the latest JDK "

replace "latest JDK" with "JDK under test"

test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java line 55:

> 53:  * property -Dregistry.host set to the hostname or IP address of the different host.
> 54:  */
> 55: public class NonLocalRegistryTest extends NonLocalRegistryBase {

Move  private static void assertIsAccessException(Throwable ex) method to NonLocalRegistryBase class.

test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java line 81:

> 79:  * with the hostname or IP address of the different host and run the test with jtreg.
> 80:  */
> 81: public class NonLocalSkeletonTest extends NonLocalRegistryBase {

Move  private static void assertIsAccessException(Throwable ex)  method to NonLocalRegistryBase class.

test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 222:

> 220:             System.out.printf("Found expected AccessException: %s%n%n", t);
> 221:         } else {
> 222:             throw new RuntimeException("AccessException did not occur when expected", ex);

private static void assertIsAccessException(Throwable ex) is define in all these three test classes, move this method in lib/jdk/test/lib

test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 226:

> 224:     }
> 225: 
> 226:     private String readHostInput(int index) {

Duplicate code, this code is also in NonLocalRegistryBase.java, Please move this code in a common class under lib/jdk/test/lib. Or move this NonLocalRegistryBase.java under lib/jdk/test/lib and provide some generic name.

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Sat Nov  5 00:04:39 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Sat, 5 Nov 2022 00:04:39 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v4]
In-Reply-To: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
Message-ID: <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>

> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
> 
> Tests include: 
> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10825/files
  - new: https://git.openjdk.org/jdk/pull/10825/files/5ee556aa..278564b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10825&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10825&range=02-03

  Stats: 217 lines in 5 files changed: 75 ins; 113 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/10825.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Sat Nov  5 00:04:40 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Sat, 5 Nov 2022 00:04:40 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v3]
In-Reply-To: <BwtKbeSfkbw4hYLRSv34x95SbBjERsPd-v0mqUj88U0=.e5dff6b0-69c1-4014-94b4-6f538d4b68df@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <qWE-amaTygY7zpnTiw-Posy9H4JLslqXLGkb86rqg3o=.d95dd7d5-0022-4a93-bc22-85fc7861bcb6@github.com>
 <BwtKbeSfkbw4hYLRSv34x95SbBjERsPd-v0mqUj88U0=.e5dff6b0-69c1-4014-94b4-6f538d4b68df@github.com>
Message-ID: <2VbiCuTeGEE80AzxSyf5ePuW1H4yfqpr7-_mE16NPxA=.a12dff2e-c03e-4f8f-b6f5-18b25ab3cb24@github.com>

On Fri, 4 Nov 2022 15:17:43 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reverted exclusion of nonlocal registry tests.
>
> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 222:
> 
>> 220:             System.out.printf("Found expected AccessException: %s%n%n", t);
>> 221:         } else {
>> 222:             throw new RuntimeException("AccessException did not occur when expected", ex);
> 
> private static void assertIsAccessException(Throwable ex) is define in all these three test classes, move this method in lib/jdk/test/lib

This method is test dependent that checks for specific keywords in the AccessException. It seems better remain inside the test classes.

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Mon Nov  7 19:38:08 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Mon, 7 Nov 2022 19:38:08 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/ shell
 tests to Java version
Message-ID: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>

There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils.

-------------

Commit messages:
 - JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

Changes: https://git.openjdk.org/jdk/pull/11029/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11029&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293450
  Stats: 453 lines in 4 files changed: 216 ins; 234 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/11029.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11029/head:pull/11029

PR: https://git.openjdk.org/jdk/pull/11029

From sspitsyn at openjdk.org  Mon Nov  7 23:22:30 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Mon, 7 Nov 2022 23:22:30 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/
 shell tests to Java version
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <_YdUIZ-jJx061FAojvH4lGptQWtOlSsDIT5Dgcbo9_Q=.24fa4704-2ec1-49e2-bccb-acc14d3d492b@github.com>

On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhuang at openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

The refactoring looks pretty good.
But I have a couple of questions.
Q1: The method `grantAccess` is converted to the util method `grantFileAccess` and it does not look the same. Could you, please, explain what are the changes?
Q2: I'm confused about conversion of the shell tests. Your fix does not convert any shell test. Also, I do not see any changes to the shell ile `test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh` listed in the enhancement. Can you explain, please?

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From bhuang at openjdk.org  Tue Nov  8 00:21:31 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Tue, 8 Nov 2022 00:21:31 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/
 shell tests to Java version
In-Reply-To: <_YdUIZ-jJx061FAojvH4lGptQWtOlSsDIT5Dgcbo9_Q=.24fa4704-2ec1-49e2-bccb-acc14d3d492b@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
 <_YdUIZ-jJx061FAojvH4lGptQWtOlSsDIT5Dgcbo9_Q=.24fa4704-2ec1-49e2-bccb-acc14d3d492b@github.com>
Message-ID: <gsVw21ob2iuGygLmSTocKhuZeass7pGx4uESqX4XTy8=.cf6f7fc8-a4d5-4c0c-b80a-865ef244699d@github.com>

On Mon, 7 Nov 2022 23:20:15 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> The refactoring looks pretty good.
> But I have a couple of questions.
> Q1: The method `grantAccess` is converted to the util method `grantFileAccess` and it does not look the same. Could you, please, explain what are the changes?
> Q2: I'm confused about conversion of the shell tests. Your fix does not convert any shell test. Also, I do not see any changes to the shell ile `test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh` listed in the enhancement. Can you explain, please?

Hi @sspitsyn, the methods `grantAccess` and `grantFileAccess` are almost identical except for the parameter `AccessControl access` being changed to a boolean which is used to indicate user access or full access. There is also a minor change in building a new ACL entry out of the original entry.

For your Q2 , it is in closed part of JDK. Please see the JBS ticket for the PR link.

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From sspitsyn at openjdk.org  Tue Nov  8 08:20:27 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Tue, 8 Nov 2022 08:20:27 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/
 shell tests to Java version
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <JElh_t18dZXThoLnT9n1YIIIQEO_pX-OPqetZlVMcRY=.1d6c53c4-f7a9-46f0-80d1-d3a756944775@github.com>

On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhuang at openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

test/lib/jdk/test/lib/Utils.java line 980:

> 978:                         PosixFilePermissions.fromString("rwxrwxrwx"));
> 979:             }
> 980:         } else if (attr.contains("acl")) {

I like more the style as it was before:

            String perms = userOnly ? "rw-------" : "rwxrwxrwx";
            Files.setPosixFilePermissions(file, PosixFilePermissions.fromString(perms));

instead of this:

                Files.setPosixFilePermissions(file,
                        PosixFilePermissions.fromString("rwx------"));
            } else { /* Allow access to everyone */
                Files.setPosixFilePermissions(file,
                        PosixFilePermissions.fromString("rwxrwxrwx"));

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From sspitsyn at openjdk.org  Tue Nov  8 08:39:08 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Tue, 8 Nov 2022 08:39:08 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/
 shell tests to Java version
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <_e2mWJMihJQGeKKLEtUcHBLZy6s1rOLYnNcLcRQzuKQ=.03670db8-ac4e-4605-a575-87890bc4d83b@github.com>

On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhuang at openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

I've placed a couple of comments.
Otherwise, it looks okay to me.
Thanks,
Serguei

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From sspitsyn at openjdk.org  Tue Nov  8 08:44:18 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Tue, 8 Nov 2022 08:44:18 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/closed/sun/management/
 shell tests to Java version
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <TTlG1KjyW5Wd42tVC-C9IBa55m3yBxqGfK20aIzFOAs=.bfc31280-87ab-4c88-87a1-dd60f81b4a02@github.com>

On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhuang at openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

test/lib/jdk/test/lib/Utils.java line 1007:

> 1005:                     }
> 1006:                 }
> 1007:             }

What was your motivation to get rid of the `Util` methods `revokeAccess`, `allowAccess` and `buildAclEntry`? The implementation did not become more clearer nor simpler. But reviewing it became harder.

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From bhuang at openjdk.org  Tue Nov  8 18:10:24 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Tue, 8 Nov 2022 18:10:24 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/sun/management/ shell
 tests to Java version
In-Reply-To: <TTlG1KjyW5Wd42tVC-C9IBa55m3yBxqGfK20aIzFOAs=.bfc31280-87ab-4c88-87a1-dd60f81b4a02@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
 <TTlG1KjyW5Wd42tVC-C9IBa55m3yBxqGfK20aIzFOAs=.bfc31280-87ab-4c88-87a1-dd60f81b4a02@github.com>
Message-ID: <1fQtMd7Wtg4mWIhjbcekB2jGf-3mf3XESTutxmey0OY=.1326b1ee-60e1-498c-a76e-e3b1ddc0c8f6@github.com>

On Tue, 8 Nov 2022 08:39:39 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> test/lib/jdk/test/lib/Utils.java line 1007:
> 
>> 1005:                     }
>> 1006:                 }
>> 1007:             }
> 
> What was your motivation to get rid of the `Util` methods `revokeAccess`, `allowAccess` and `buildAclEntry`? The implementation did not become more clearer nor simpler. But reviewing it became harder.

Sure, I will add those methods back.

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From bhuang at openjdk.org  Tue Nov  8 18:20:34 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Tue, 8 Nov 2022 18:20:34 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/sun/management/ shell
 tests to Java version [v2]
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11029/files
  - new: https://git.openjdk.org/jdk/pull/11029/files/98a7188e..191cd5ca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11029&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11029&range=00-01

  Stats: 47 lines in 1 file changed: 31 ins; 11 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/11029.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11029/head:pull/11029

PR: https://git.openjdk.org/jdk/pull/11029

From sspitsyn at openjdk.org  Wed Nov  9 10:03:34 2022
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Wed, 9 Nov 2022 10:03:34 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/sun/management/ shell
 tests to Java version [v2]
In-Reply-To: <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
 <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
Message-ID: <5KO0PHIMbjYP5ScIoj_NHc2QpaW5pWSdM-zUuk6gcVA=.a0d52fdf-94fb-4cc7-b30a-30c5d6642256@github.com>

On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

Thank you for the update.
Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11029

From kevinw at openjdk.org  Wed Nov  9 12:41:01 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 9 Nov 2022 12:41:01 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/sun/management/ shell
 tests to Java version [v2]
In-Reply-To: <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
 <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
Message-ID: <IIovqTWOqn9biEvZRW7PBcFsRSlXrXcAMl5gCHPvTRw=.5c67da52-d4a4-4534-a493-bf545c69458c@github.com>

On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

Looks ok! 8-)

-------------

Marked as reviewed by kevinw (Committer).

PR: https://git.openjdk.org/jdk/pull/11029

From bhuang at openjdk.org  Wed Nov  9 18:12:39 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Wed, 9 Nov 2022 18:12:39 GMT
Subject: jmx-dev RFR: JDK-8293450 Convert test/sun/management/ shell
 tests to Java version [v2]
In-Reply-To: <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
 <Ghss3fjwzuEo6GZdo16PT2V6w-TQkuYf4T6IuwdccEI=.c8df8554-633f-40d4-9a85-768dfa299b96@github.com>
Message-ID: <ex5x8Q3MAhmLbdk1Cxjdbo79qVcnIEa09DHF9jjF2_I=.369091ce-e42a-4fdb-bb46-ac3dfc2089de@github.com>

On Tue, 8 Nov 2022 18:20:34 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

It seems there is an integration issue with this PR as the JBS ticket is marked as confidential. I will open a new ticket for this change.

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From bhuang at openjdk.org  Wed Nov  9 19:05:40 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Wed, 9 Nov 2022 19:05:40 GMT
Subject: jmx-dev Integrated: 8296718: Refactor bootstrap Test Common
 Functionalities to test/lib/Utils
In-Reply-To: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
References: <f_Xu1haC4hgfb91Dtb8GaDevT0cK-x4kG9YxgnDGBP0=.f2896870-7164-4407-a8ca-6fb29e372854@github.com>
Message-ID: <thPkNq6JLfnVbJDdyfOdT_0BypItIanQiaSzhy3DJ2A=.a272212b-527e-478a-bf77-daf5f4f4d047@github.com>

On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhuang at openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.

This pull request has now been integrated.

Changeset: cc8bf950
Author:    Bill Huang <bhuang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cc8bf95046d1fba0f88b0e17481f36b2be870659
Stats:     473 lines in 4 files changed: 236 ins; 234 del; 3 mod

8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils

Reviewed-by: sspitsyn, kevinw

-------------

PR: https://git.openjdk.org/jdk/pull/11029

From prappo at openjdk.org  Mon Nov 14 20:03:35 2022
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 14 Nov 2022 20:03:35 GMT
Subject: jmx-dev RFR: 8296953: Fix a typo in exception documentation
Message-ID: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>

Please review this trivial documentation change that fixes a typo accidentally found while comparing javadoc output for an unrelated change in jdk.javadoc.

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/jdk/pull/11140/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11140&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296953
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/11140.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11140/head:pull/11140

PR: https://git.openjdk.org/jdk/pull/11140

From cjplummer at openjdk.org  Mon Nov 14 20:23:26 2022
From: cjplummer at openjdk.org (Chris Plummer)
Date: Mon, 14 Nov 2022 20:23:26 GMT
Subject: jmx-dev RFR: 8296953: Fix a typo in exception documentation
In-Reply-To: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
References: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
Message-ID: <FXpORDs2zOIyqAUPNuDYjBwk8p9wf7l1kqjyuipVDVE=.db010021-2eb9-4be0-af1c-98ab454f2246@github.com>

On Mon, 14 Nov 2022 19:04:49 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this trivial documentation change that fixes a typo accidentally found while comparing javadoc output for an unrelated change in jdk.javadoc.

Looks like a day 1 bug. Changes look good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11140

From dfuchs at openjdk.org  Mon Nov 14 21:33:59 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Mon, 14 Nov 2022 21:33:59 GMT
Subject: jmx-dev RFR: 8296953: Fix a typo in exception documentation
In-Reply-To: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
References: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
Message-ID: <utzq6WT3T_y0GJXP2zunpzrRDsWLjg0oWWSR4YbmWCc=.05232426-7f2b-4c22-b399-779f3e0d5ff0@github.com>

On Mon, 14 Nov 2022 19:04:49 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this trivial documentation change that fixes a typo accidentally found while comparing javadoc output for an unrelated change in jdk.javadoc.

Marked as reviewed by dfuchs (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11140

From prappo at openjdk.org  Wed Nov 16 09:21:09 2022
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 16 Nov 2022 09:21:09 GMT
Subject: jmx-dev Integrated: 8296953: Fix a typo in exception documentation
In-Reply-To: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
References: <wO3BcW6ZX27G0yyS9YwbN2U5Au9n2O9YdSPIVj7DZUo=.ebcf2473-22bd-4a3e-a7ef-8e19b591d8f2@github.com>
Message-ID: <yZHk5jD7_VM8f1hvUuVss4A8YF2Y_xu7WeU_bMC8bWA=.f39c084f-4370-4f34-a8ec-c3bf30c20321@github.com>

On Mon, 14 Nov 2022 19:04:49 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this trivial documentation change that fixes a typo accidentally found while comparing javadoc output for an unrelated change in jdk.javadoc.

This pull request has now been integrated.

Changeset: 97ab2c3e
Author:    Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/97ab2c3ea61daa32ab51506fefa42d486121e089
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

8296953: Fix a typo in exception documentation

Reviewed-by: cjplummer, dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/11140

From duke at openjdk.org  Thu Nov 17 06:36:59 2022
From: duke at openjdk.org (Poison)
Date: Thu, 17 Nov 2022 06:36:59 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be volatile
 to ensure that different threads get the latest ticks
Message-ID: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>

As the title says, add the volatile modifier.

-------------

Commit messages:
 - 8297173: usageTicks and totalTicks should be volatile

Changes: https://git.openjdk.org/jdk/pull/11199/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11199&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297173
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11199.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11199/head:pull/11199

PR: https://git.openjdk.org/jdk/pull/11199

From sgehwolf at openjdk.org  Thu Nov 17 09:12:23 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 17 Nov 2022 09:12:23 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks
In-Reply-To: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
Message-ID: <PXlEBgZmo0Mvr6pgquwHpKF0vL3cyR41lnbZ0ACjUro=.9ed7f82e-905f-496f-ba09-c6ab86903975@github.com>

On Thu, 17 Nov 2022 06:28:37 GMT, Poison <duke at openjdk.org> wrote:

> As the title says, add the volatile modifier.

Seems OK to me.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11199

From sgehwolf at openjdk.org  Thu Nov 17 09:28:19 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 17 Nov 2022 09:28:19 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks
In-Reply-To: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
Message-ID: <02FwbRm7VD08T3TD2jyV3UKaazbCF2-EC4eFAMJJowY=.bc46e149-a66e-4c9c-ab6f-4d878d9bb3b3@github.com>

On Thu, 17 Nov 2022 06:28:37 GMT, Poison <duke at openjdk.org> wrote:

> As the title says, add the volatile modifier.

Please enable testing for your fork.

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From alanb at openjdk.org  Thu Nov 17 09:37:23 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Thu, 17 Nov 2022 09:37:23 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks
In-Reply-To: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
Message-ID: <WIjo1ak5MvWnrke8wmBnAssZVFxSKdHf9A-fLNv13IU=.8b005416-aa6c-4a13-95b2-b23b8035a8ad@github.com>

On Thu, 17 Nov 2022 06:28:37 GMT, Poison <duke at openjdk.org> wrote:

> As the title says, add the volatile modifier.

src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 53:

> 51:     private abstract class ContainerCpuTicks {
> 52:         private volatile long usageTicks = 0;
> 53:         private volatile long totalTicks = 0;

You can drop initialising the fields to 0 (their default value) while you are at it as they are volatile writes.

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From duke at openjdk.org  Thu Nov 17 09:43:39 2022
From: duke at openjdk.org (Poison)
Date: Thu, 17 Nov 2022 09:43:39 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks [v2]
In-Reply-To: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
Message-ID: <__C9hdFdiGwECNQ9NBVry5dNseFyVSlHQSN8GYdlVf8=.65b8af68-5327-42e4-9445-e2237cb38aa7@github.com>

> As the title says, add the volatile modifier.

Poison has updated the pull request incrementally with one additional commit since the last revision:

  8297173: usageTicks and totalTicks should be volatile

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11199/files
  - new: https://git.openjdk.org/jdk/pull/11199/files/dd459966..f6b19bb0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11199&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11199&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11199.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11199/head:pull/11199

PR: https://git.openjdk.org/jdk/pull/11199

From duke at openjdk.org  Thu Nov 17 09:43:39 2022
From: duke at openjdk.org (Poison)
Date: Thu, 17 Nov 2022 09:43:39 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks [v2]
In-Reply-To: <WIjo1ak5MvWnrke8wmBnAssZVFxSKdHf9A-fLNv13IU=.8b005416-aa6c-4a13-95b2-b23b8035a8ad@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
 <WIjo1ak5MvWnrke8wmBnAssZVFxSKdHf9A-fLNv13IU=.8b005416-aa6c-4a13-95b2-b23b8035a8ad@github.com>
Message-ID: <YeHJqnrDK_CUslxJ2M850EAa_oUNsy13f0A897Rqh3I=.5f0a39e6-c6b6-4fdb-ba65-ccfb050d5d3e@github.com>

On Thu, 17 Nov 2022 09:35:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Poison has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8297173: usageTicks and totalTicks should be volatile
>
> src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 53:
> 
>> 51:     private abstract class ContainerCpuTicks {
>> 52:         private volatile long usageTicks = 0;
>> 53:         private volatile long totalTicks = 0;
> 
> You can drop initialising the fields to 0 (their default value) while you are at it as they are volatile writes.

OK

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From alanb at openjdk.org  Thu Nov 17 10:14:35 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Thu, 17 Nov 2022 10:14:35 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks [v2]
In-Reply-To: <__C9hdFdiGwECNQ9NBVry5dNseFyVSlHQSN8GYdlVf8=.65b8af68-5327-42e4-9445-e2237cb38aa7@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
 <__C9hdFdiGwECNQ9NBVry5dNseFyVSlHQSN8GYdlVf8=.65b8af68-5327-42e4-9445-e2237cb38aa7@github.com>
Message-ID: <JqJVbIDC9KV46tKWhS9kA7C0PkFyT5nktfenFSfhSdo=.24048fbb-75cf-40a0-b249-3a413538c003@github.com>

On Thu, 17 Nov 2022 09:43:39 GMT, Poison <duke at openjdk.org> wrote:

>> As the title says, add the volatile modifier.
>
> Poison has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8297173: usageTicks and totalTicks should be volatile

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From sgehwolf at openjdk.org  Fri Nov 18 10:44:53 2022
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 18 Nov 2022 10:44:53 GMT
Subject: jmx-dev RFR: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks [v2]
In-Reply-To: <__C9hdFdiGwECNQ9NBVry5dNseFyVSlHQSN8GYdlVf8=.65b8af68-5327-42e4-9445-e2237cb38aa7@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
 <__C9hdFdiGwECNQ9NBVry5dNseFyVSlHQSN8GYdlVf8=.65b8af68-5327-42e4-9445-e2237cb38aa7@github.com>
Message-ID: <n4CQvCf3tFuIAuGwVo-yaReIP2oaukPpGypX-nfkVCI=.1408bde9-f27b-4310-a379-9c290e2af7f7@github.com>

On Thu, 17 Nov 2022 09:43:39 GMT, Poison <duke at openjdk.org> wrote:

>> As the title says, add the volatile modifier.
>
> Poison has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8297173: usageTicks and totalTicks should be volatile

@tianshuang If you /integrate again, I can sponsor for you if you like.

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From duke at openjdk.org  Fri Nov 18 10:48:29 2022
From: duke at openjdk.org (Poison)
Date: Fri, 18 Nov 2022 10:48:29 GMT
Subject: jmx-dev Integrated: 8297173: usageTicks and totalTicks should be
 volatile to ensure that different threads get the latest ticks
In-Reply-To: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
References: <vVeAFSO8zj0GQ3O6d8V8Hql7w8H8aCnu9LjWKCxJ2Ic=.85fc1eb5-aba7-41d0-9b4d-ddba88aab217@github.com>
Message-ID: <o_XAG3slXnYC_4tKgjvVY1f7s342vBpWPYKtkq3MJGA=.58095d4e-a0a9-4e6d-a095-b1a8c82aafef@github.com>

On Thu, 17 Nov 2022 06:28:37 GMT, Poison <duke at openjdk.org> wrote:

> As the title says, add the volatile modifier.

This pull request has now been integrated.

Changeset: dd18d76b
Author:    tianshuang <tianshuang.me at gmail.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dd18d76b4c1dfa79707634bcd4df4f8e7cfb8b70
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks

Reviewed-by: sgehwolf, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/11199

From mchhipa at openjdk.org  Fri Nov 25 17:05:11 2022
From: mchhipa at openjdk.org (Mahendra Chhipa)
Date: Fri, 25 Nov 2022 17:05:11 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v4]
In-Reply-To: <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
Message-ID: <4y7Bt3HYXsF48N7jku8aOSm8v9vHeywxe0nfX_2hBmI=.f4c24c4b-5ee0-4ced-ba0d-9f6dda1ff632@github.com>

On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
>> 
>> Tests include: 
>> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
>> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
>> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

LGTM

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From mernst at openjdk.org  Sun Nov 27 17:53:30 2022
From: mernst at openjdk.org (Michael Ernst)
Date: Sun, 27 Nov 2022 17:53:30 GMT
Subject: jmx-dev RFR: 8294321: Fix typos in files under test/jdk/java,
 test/jdk/jdk, test/jdk/jni [v2]
In-Reply-To: <JM2iW2-imTXG8KxxinxGWCXP8FwOesEjeQheWbooMoY=.2dfbad6d-e4e3-43b3-90b9-fdd7ac22e9d1@github.com>
References: <Son2XWweoJeNzBalwQ4_ujZfK_jkwdh5tEozAk8QXXo=.e1ccc05f-84d7-454d-be22-5855aeed0c52@github.com>
 <JM2iW2-imTXG8KxxinxGWCXP8FwOesEjeQheWbooMoY=.2dfbad6d-e4e3-43b3-90b9-fdd7ac22e9d1@github.com>
Message-ID: <gOXCJJl7JqlhdMiDjhu5kbAGieFHPelXHl_XvNG3Pyw=.881b6edb-36c1-4044-99da-18b45b28a69b@github.com>

On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst <mernst at openjdk.org> wrote:

>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Reinstate typos in Apache code that is copied into the JDK
>  - Merge ../jdk-openjdk into typos-typos
>  - Remove file that was removed upstream
>  - Fix inconsistency in capitalization
>  - Undo change in zlip
>  - Fix typos

Could someone who knows the undocumented ins and outs of creating JDK pull requests could split this pull request up into multiple PRs?  Then it can be merged, rather than wasting all the effort that went into it.

-------------

PR: https://git.openjdk.org/jdk/pull/10029

From jpai at openjdk.org  Mon Nov 28 09:02:13 2022
From: jpai at openjdk.org (Jaikiran Pai)
Date: Mon, 28 Nov 2022 09:02:13 GMT
Subject: jmx-dev RFR: 8294321: Fix typos in files under test/jdk/java,
 test/jdk/jdk, test/jdk/jni [v2]
In-Reply-To: <gOXCJJl7JqlhdMiDjhu5kbAGieFHPelXHl_XvNG3Pyw=.881b6edb-36c1-4044-99da-18b45b28a69b@github.com>
References: <Son2XWweoJeNzBalwQ4_ujZfK_jkwdh5tEozAk8QXXo=.e1ccc05f-84d7-454d-be22-5855aeed0c52@github.com>
 <JM2iW2-imTXG8KxxinxGWCXP8FwOesEjeQheWbooMoY=.2dfbad6d-e4e3-43b3-90b9-fdd7ac22e9d1@github.com>
 <gOXCJJl7JqlhdMiDjhu5kbAGieFHPelXHl_XvNG3Pyw=.881b6edb-36c1-4044-99da-18b45b28a69b@github.com>
Message-ID: <o4GUMwlhtn6ng4FZjHRzZ3iqJD0dlAWKnXsufxhmbqk=.4920d482-3bba-4814-88b6-6a7e839349e2@github.com>

On Sun, 27 Nov 2022 17:49:57 GMT, Michael Ernst <mernst at openjdk.org> wrote:

> Could someone who knows the undocumented ins and outs of creating JDK pull requests could split this pull request up into multiple PRs? Then it can be merged, rather than wasting all the effort that went into it.

I've raised https://github.com/openjdk/jdk/pull/11385 for one set of changes from this current PR. I'll pick up the other ones shortly in different PRs.

-------------

PR: https://git.openjdk.org/jdk/pull/10029

From alanb at openjdk.org  Mon Nov 28 14:00:41 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Mon, 28 Nov 2022 14:00:41 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v4]
In-Reply-To: <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
Message-ID: <mNMeb3HKwl1weuqN2CjsUedePKbs-k95_yGq7Q9rFy8=.7267687b-b7d2-4d2f-8073-0b7585ab52dc@github.com>

On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
>> 
>> Tests include: 
>> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
>> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
>> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>
> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments.

test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 167:

> 165:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName)));
> 166:         Set<InetAddress> hostAddrs =
> 167:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(host)));

Is there a reason to change this from Set.of?

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Mon Nov 28 17:57:28 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Mon, 28 Nov 2022 17:57:28 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v4]
In-Reply-To: <mNMeb3HKwl1weuqN2CjsUedePKbs-k95_yGq7Q9rFy8=.7267687b-b7d2-4d2f-8073-0b7585ab52dc@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
 <mNMeb3HKwl1weuqN2CjsUedePKbs-k95_yGq7Q9rFy8=.7267687b-b7d2-4d2f-8073-0b7585ab52dc@github.com>
Message-ID: <Q9BMqN7NuctsNMhV33CAUs-P9pRs1Ue9MAaKAnVxRbc=.86042f68-2e12-4f8c-b97b-be7495b4369f@github.com>

On Mon, 28 Nov 2022 13:56:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments.
>
> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 167:
> 
>> 165:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName)));
>> 166:         Set<InetAddress> hostAddrs =
>> 167:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(host)));
> 
> Is there a reason to change this from Set.of?

This is a workaround for duplicate elements detected by Set.of(). On my localhost, InetAddress.getAllByName(localhost returns duplicate IPv6 addresses with different scoped id which is not counted during comparison. This change shouldn't impact the goal of these tests which is to verify that registry modification request from client side is prohibited.

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From alanb at openjdk.org  Mon Nov 28 18:38:24 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Mon, 28 Nov 2022 18:38:24 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v4]
In-Reply-To: <Q9BMqN7NuctsNMhV33CAUs-P9pRs1Ue9MAaKAnVxRbc=.86042f68-2e12-4f8c-b97b-be7495b4369f@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
 <ZRrHnabQ3x6urbHgMdedJWtKqELx1LX-E3TsakdiiEE=.5d2bee16-6ca5-4e0b-a5a6-ad9091338987@github.com>
 <mNMeb3HKwl1weuqN2CjsUedePKbs-k95_yGq7Q9rFy8=.7267687b-b7d2-4d2f-8073-0b7585ab52dc@github.com>
 <Q9BMqN7NuctsNMhV33CAUs-P9pRs1Ue9MAaKAnVxRbc=.86042f68-2e12-4f8c-b97b-be7495b4369f@github.com>
Message-ID: <U39SoaM1fBbmcl5oC2ao5IfQcGyJcccMYH9Xb7fkZ4Y=.4da3ee4e-f988-40f6-8dc1-22c5aaf7c3be@github.com>

On Mon, 28 Nov 2022 17:54:51 GMT, Bill Huang <bhuang at openjdk.org> wrote:

>> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 167:
>> 
>>> 165:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(myHostName)));
>>> 166:         Set<InetAddress> hostAddrs =
>>> 167:                 Set.copyOf(Arrays.asList(InetAddress.getAllByName(host)));
>> 
>> Is there a reason to change this from Set.of?
>
> This is a workaround for duplicate elements detected by Set.of(). On my localhost, InetAddress.getAllByName(localhost returns duplicate IPv6 addresses with different scoped id which is not counted during comparison. This change shouldn't impact the goal of these tests which is to verify that registry modification request from client side is prohibited.

Thanks. You might want to add a comment to avoid drive-by suggestions to simplify it.

-------------

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Tue Nov 29 00:55:08 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Tue, 29 Nov 2022 00:55:08 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v5]
In-Reply-To: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
Message-ID: <hJUmYdnknmW_cKjllLMbcQYp8eXkHWa5E2yaSIZ6Q98=.d7875a0b-809c-4f80-92a1-1d93073aabf1@github.com>

> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
> 
> Tests include: 
> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java

Bill Huang has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10825/files
  - new: https://git.openjdk.org/jdk/pull/10825/files/278564b3..cff3773c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10825&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10825&range=03-04

  Stats: 9 lines in 3 files changed: 5 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10825.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825

PR: https://git.openjdk.org/jdk/pull/10825

From bhuang at openjdk.org  Tue Nov 29 01:06:49 2022
From: bhuang at openjdk.org (Bill Huang)
Date: Tue, 29 Nov 2022 01:06:49 GMT
Subject: jmx-dev RFR: JDK-8295756 Improve NonLocalRegistry Manual Test
 Process [v6]
In-Reply-To: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
References: <zimo9_4V7yIIQ80Etwuvzqy7sRZvsJw5zbaeYv6J8gM=.67e06cf4-0f42-4f2c-9081-9fd5461b7b12@github.com>
Message-ID: <YVD7WPx80_VPKZAoG_beZSdtDGS240fW1iDJ66ci4Ok=.874dbaa2-caf5-47a5-9971-848f0ca5007d@github.com>

> The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction to the test engineer about the test requirement. 
> 
> Tests include: 
> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java 
> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java 
> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java

Bill Huang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:

 - Merge master
 - Implemented review comments.
 - Implemented review comments.
 - Reverted exclusion of nonlocal registry tests.
 - Updated test instruction messages.
 - Updated TEST.groups
 - JDK-8295756 Improve NonLocalRegistry Manual Test Process

-------------

Changes: https://git.openjdk.org/jdk/pull/10825/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10825&range=05
  Stats: 350 lines in 7 files changed: 256 ins; 58 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/10825.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10825/head:pull/10825

PR: https://git.openjdk.org/jdk/pull/10825

From ihse at openjdk.org  Tue Nov 29 19:26:36 2022
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 29 Nov 2022 19:26:36 GMT
Subject: jmx-dev RFR: 8295729: Add jcheck whitespace checking for
 properties files [v3]
In-Reply-To: <zIAGVqLBXo50aa5WRbe56xpkKVEyHv0FEk4gwRXlpXg=.55305d94-5232-4a29-beea-31f54b52626c@github.com>
References: <nUcyMLQqktyxHgKYhpjitMYsI4IzEw4tZqFe0L6ioH4=.56ee2f1e-48b0-41f6-a852-cbe6f99edaeb@github.com>
 <zIAGVqLBXo50aa5WRbe56xpkKVEyHv0FEk4gwRXlpXg=.55305d94-5232-4a29-beea-31f54b52626c@github.com>
Message-ID: <D-_pSm7C9d1Wdx-g6Tz0PTX_7CgFMitkkGCV907jv_8=.77ff6af8-466b-42ab-a015-73589600dab1@github.com>

On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes.
>> 
>> With the new Skara jcheck, it is possible to increase the coverage of the whitespace checks (in the old mercurial version, this was more or less impossible).
>> 
>> The only manual change is to `.jcheck/conf`. All other changes were made by running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "Remove check for .properties from jcheck"
>    
>    This reverts commit c91fdaa19dc06351598bd1c0614e1af3bfa08ae2.
>  - Change trailing space and tab in values to unicode encoding

Yes bot, I know. I'll need to split this up into multiple steps, but please keep this open for a while more. Thank you.

-------------

PR: https://git.openjdk.org/jdk/pull/10792

From kevinw at openjdk.org  Wed Nov 30 13:22:21 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 13:22:21 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for Removal
Message-ID: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>

Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.

This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.

More details in bug, and CSR JDK-8297795

-------------

Commit messages:
 - Test updates
 - 8297794: Deprecate JMX Management Applets for Removal

Changes: https://git.openjdk.org/jdk/pull/11430/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297794
  Stats: 41 lines in 19 files changed: 23 ins; 1 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/11430.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11430/head:pull/11430

PR: https://git.openjdk.org/jdk/pull/11430

From alanb at openjdk.org  Wed Nov 30 13:35:20 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 30 Nov 2022 13:35:20 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <-_66BL8kLaRv8aSuOJBlJscW0ftTOt8hmg6dobnS8n4=.429e2240-61f6-429c-994b-139de1284581@github.com>

On Wed, 30 Nov 2022 12:08:22 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

Are you planning to add the @deprecated tag with the description for why they are deprecated? I'm surprised the java.management module compiles without it but maybe this module has doclint config in its make file.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From dfuchs at openjdk.org  Wed Nov 30 14:02:22 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Wed, 30 Nov 2022 14:02:22 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <riu2zSiAIBd3Tw5Qm2zDjDLE6qR0IEE9PK9k0AtBwzE=.ed4be1b2-9b1d-46a4-b653-ec7ce1f54a1d@github.com>

On Wed, 30 Nov 2022 12:08:22 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

I have the same remark as Alan - I believe an `@deprecated ` text is needed in the API documentation of the public exported classes that are deprecated. At the minimum something like:

* @deprecated This class is deprecated for removal. There is no replacement. 


I also see that you have chosen to add `@SuppressWarnings` in tests. Not sure what the rules are for the serviceability area - but usually it's fine to keep the deprecation warning in tests (that is: suppressing deprecation warnings in tests is usually optional).

src/java.management/share/classes/javax/management/loading/MLetObjectInputStream.java line 43:

> 41: class MLetObjectInputStream extends ObjectInputStream {
> 42: 
> 43:     @SuppressWarnings("removal")

Shouldn't `MLetObjectInputStream` be deprecated for removal too? I mean - if MLet was removed - would we need to keep that class? If it were deprecated for removal too then I suspect that there would be no need to suppress the warning here (and below).

src/java.management/share/classes/javax/management/loading/MLetParser.java line 156:

> 154:      * Scan an html file for {@literal <mlet>} tags.
> 155:      */
> 156:     @SuppressWarnings("removal")

Same remark here. This class should probably be deprecated for removal too.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 14:28:21 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 14:28:21 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <HVBddmX5U5IQ0lwhThoPdh0sD9-p1c_sl006A8ZQ-f8=.a8c916d4-1704-440c-9669-f7f7deb8c514@github.com>

On Wed, 30 Nov 2022 12:08:22 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

Thanks both, yes will add a doc comment also.  Currently the generated docs give you: "Deprecated, for removal: This API element is subject to removal in a future version." But will add more around that.

MLetObjectInputStream and MLetParser are not public classes, so thinking they are not part of the public API we need to deprecate before removal.

Happy to try and avoid test logs being full of excess noise with those suppression annotations... 8-)

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From dfuchs at openjdk.org  Wed Nov 30 14:46:06 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Wed, 30 Nov 2022 14:46:06 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal
In-Reply-To: <HVBddmX5U5IQ0lwhThoPdh0sD9-p1c_sl006A8ZQ-f8=.a8c916d4-1704-440c-9669-f7f7deb8c514@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <HVBddmX5U5IQ0lwhThoPdh0sD9-p1c_sl006A8ZQ-f8=.a8c916d4-1704-440c-9669-f7f7deb8c514@github.com>
Message-ID: <keZLPW4upQI0M5Ijz4YgU0FflbHSIYQ7mRHe5a_Rn2c=.ff58dbbc-d07f-4c7c-b122-0d39e6b5ff4d@github.com>

On Wed, 30 Nov 2022 14:24:36 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> MLetObjectInputStream and MLetParser are not public classes, so thinking they are not part of the public API we need to deprecate before removal.

Whether a class is public exported or not has no real relationship with whether it should have the `@Deprecated` annotation or not. It is better to add the `@Deprecated` annotation eagerly to all classes that are part of the feature being deprecated, if they are only used for the implementation of that feature, and if the thinking is that they would be removed if the feature is removed. Plus it usually simplifies things as it usually minimizes the places where you need to suppress warnings.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 15:21:53 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 15:21:53 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  deprecated api doc text

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11430/files
  - new: https://git.openjdk.org/jdk/pull/11430/files/b82530ad..55c7a188

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=00-01

  Stats: 17 lines in 4 files changed: 16 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/11430.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11430/head:pull/11430

PR: https://git.openjdk.org/jdk/pull/11430

From rriggs at openjdk.org  Wed Nov 30 15:47:26 2022
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 30 Nov 2022 15:47:26 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
Message-ID: <CjrfDA3ZMAbdnONHeueM1Ibdg1cQeSF6y_nTCqnoY-Y=.3b49c999-b5bd-4852-8ea4-bee3748c5667@github.com>

On Wed, 30 Nov 2022 15:21:53 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
>> 
>> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
>> 
>> More details in bug, and CSR JDK-8297795
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deprecated api doc text

src/java.management/share/classes/javax/management/loading/MLet.java line 165:

> 163:  * to load classes that could not be found in the loaded jar files.
> 164:  *
> 165:  * @deprecated This API is part of Management Applets (m-lets), which is a legacy feature that allows loading

I think `m-let` should be capital M.  ->  `M-let`.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From alanb at openjdk.org  Wed Nov 30 16:11:32 2022
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 30 Nov 2022 16:11:32 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <riu2zSiAIBd3Tw5Qm2zDjDLE6qR0IEE9PK9k0AtBwzE=.ed4be1b2-9b1d-46a4-b653-ec7ce1f54a1d@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <riu2zSiAIBd3Tw5Qm2zDjDLE6qR0IEE9PK9k0AtBwzE=.ed4be1b2-9b1d-46a4-b653-ec7ce1f54a1d@github.com>
Message-ID: <fuc6t-ZOIKTb_hv0HNBExZHIM0eh97jdNqKSLwSE6Xo=.a1404edc-c760-446e-946f-43167017f499@github.com>

On Wed, 30 Nov 2022 13:50:13 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   deprecated api doc text
>
> src/java.management/share/classes/javax/management/loading/MLetObjectInputStream.java line 43:
> 
>> 41: class MLetObjectInputStream extends ObjectInputStream {
>> 42: 
>> 43:     @SuppressWarnings("removal")
> 
> Shouldn't `MLetObjectInputStream` be deprecated for removal too? I mean - if MLet was removed - would we need to keep that class? If it were deprecated for removal too then I suspect that there would be no need to suppress the warning here (and below).

It's not public so not part of the API, but you may be right that it would reduce the number of places where the warning needs to be suppressed.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 16:44:21 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 16:44:21 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <CjrfDA3ZMAbdnONHeueM1Ibdg1cQeSF6y_nTCqnoY-Y=.3b49c999-b5bd-4852-8ea4-bee3748c5667@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
 <CjrfDA3ZMAbdnONHeueM1Ibdg1cQeSF6y_nTCqnoY-Y=.3b49c999-b5bd-4852-8ea4-bee3748c5667@github.com>
Message-ID: <pdIeXMOxFF_kKvPieqI5v2j-l3PwOuHwr6Ux1F_4lTQ=.6c213981-aadb-4f16-b6e3-adc06ace7e10@github.com>

On Wed, 30 Nov 2022 15:45:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   deprecated api doc text
>
> src/java.management/share/classes/javax/management/loading/MLet.java line 165:
> 
>> 163:  * to load classes that could not be found in the loaded jar files.
>> 164:  *
>> 165:  * @deprecated This API is part of Management Applets (m-lets), which is a legacy feature that allows loading
> 
> I think `m-let` should be capital M.  ->  `M-let`.

JMX_1_4_specification.pdf has it as "m-let".  But the API docs often use class names or the MLET tag so don't use the "m-let" form much, if at all.  But for a written text, I think it's correct as it is. 8-)

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 16:56:23 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 16:56:23 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <fuc6t-ZOIKTb_hv0HNBExZHIM0eh97jdNqKSLwSE6Xo=.a1404edc-c760-446e-946f-43167017f499@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <riu2zSiAIBd3Tw5Qm2zDjDLE6qR0IEE9PK9k0AtBwzE=.ed4be1b2-9b1d-46a4-b653-ec7ce1f54a1d@github.com>
 <fuc6t-ZOIKTb_hv0HNBExZHIM0eh97jdNqKSLwSE6Xo=.a1404edc-c760-446e-946f-43167017f499@github.com>
Message-ID: <3FHzBgGrbNsXw_-0AVjsVEu9F7Dozk7MS-iKniSNlwo=.86a55a56-0925-4d66-adff-63ad340d38c3@github.com>

On Wed, 30 Nov 2022 16:08:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> src/java.management/share/classes/javax/management/loading/MLetObjectInputStream.java line 43:
>> 
>>> 41: class MLetObjectInputStream extends ObjectInputStream {
>>> 42: 
>>> 43:     @SuppressWarnings("removal")
>> 
>> Shouldn't `MLetObjectInputStream` be deprecated for removal too? I mean - if MLet was removed - would we need to keep that class? If it were deprecated for removal too then I suspect that there would be no need to suppress the warning here (and below).
>
> It's not public so not part of the API, but you may be right that it would reduce the number of places where the warning needs to be suppressed.

I tested making the class MLetParser itself @Deprecated in the same way, and it still needs a @SuppressWarnings annotation on the parse(url) method, or it produces 3 warnings regarding use of MLetContent.
I don't mind adding the deprecation note to these two classes to make it clear that these non-public classes are also on the way out.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 17:02:45 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 17:02:45 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v3]
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <57tCMPyMZXEaZS0mD_NQ-H_XBkY2FyPVDtxufVCG--E=.6768ebb8-bfcb-4814-bb98-361cc5700cbb@github.com>

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  Deprecated annotation on the package-private classes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11430/files
  - new: https://git.openjdk.org/jdk/pull/11430/files/55c7a188..8fc74d51

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=01-02

  Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/11430.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11430/head:pull/11430

PR: https://git.openjdk.org/jdk/pull/11430

From rriggs at openjdk.org  Wed Nov 30 17:06:40 2022
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 30 Nov 2022 17:06:40 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <pdIeXMOxFF_kKvPieqI5v2j-l3PwOuHwr6Ux1F_4lTQ=.6c213981-aadb-4f16-b6e3-adc06ace7e10@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
 <CjrfDA3ZMAbdnONHeueM1Ibdg1cQeSF6y_nTCqnoY-Y=.3b49c999-b5bd-4852-8ea4-bee3748c5667@github.com>
 <pdIeXMOxFF_kKvPieqI5v2j-l3PwOuHwr6Ux1F_4lTQ=.6c213981-aadb-4f16-b6e3-adc06ace7e10@github.com>
Message-ID: <TB4LadipJvuwKZKL__miC4CTSvUh22Ic1CsuMKJP240=.76c16de4-e855-4940-bf07-3b2560524961@github.com>

On Wed, 30 Nov 2022 16:41:16 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> src/java.management/share/classes/javax/management/loading/MLet.java line 165:
>> 
>>> 163:  * to load classes that could not be found in the loaded jar files.
>>> 164:  *
>>> 165:  * @deprecated This API is part of Management Applets (m-lets), which is a legacy feature that allows loading
>> 
>> I think `m-let` should be capital M.  ->  `M-let`.
>
> JMX_1_4_specification.pdf has it as "m-let".  But the API docs often use class names or the MLET tag so don't use the "m-let" form much, if at all.  But for a written text, I think it's correct as it is. 8-)

ok, I think M-let is more readable, but fine as is.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 17:02:47 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 17:02:47 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v2]
In-Reply-To: <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <DnvFmvnwYZ367BYL5A01cob-gH8XizKJenNBYXt0P4Y=.6b6e7692-f5cb-493a-af2d-2b1efbcb103b@github.com>
Message-ID: <Pc1Gx1w_ppQw6HM52TQKbXAeGk0GysueHUoAK2bL_vc=.71e536d7-c25b-47ca-a45b-e092fb806dba@github.com>

On Wed, 30 Nov 2022 15:21:53 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
>> 
>> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
>> 
>> More details in bug, and CSR JDK-8297795
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   deprecated api doc text

Updated with additional Deprecated annotations on two non-public classes which would also be removed.
No deprecation tag doc update as there are no public API docs for these.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From dfuchs at openjdk.org  Wed Nov 30 17:29:57 2022
From: dfuchs at openjdk.org (Daniel Fuchs)
Date: Wed, 30 Nov 2022 17:29:57 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v3]
In-Reply-To: <57tCMPyMZXEaZS0mD_NQ-H_XBkY2FyPVDtxufVCG--E=.6768ebb8-bfcb-4814-bb98-361cc5700cbb@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <57tCMPyMZXEaZS0mD_NQ-H_XBkY2FyPVDtxufVCG--E=.6768ebb8-bfcb-4814-bb98-361cc5700cbb@github.com>
Message-ID: <VbcWWjmnhV95Cwe4OloiTgAP_3aQ1Vg7uSLRzRv2xQo=.52de25d9-1ebe-4a4c-bafe-0889d7bddbd2@github.com>

On Wed, 30 Nov 2022 17:02:45 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
>> 
>> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
>> 
>> More details in bug, and CSR JDK-8297795
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Deprecated annotation on the package-private classes

src/java.management/share/classes/javax/management/loading/MLetParser.java line 254:

> 252:      * Parse the document pointed by the URL urlname
> 253:      */
> 254:     @SuppressWarnings({"deprecation", "removal"})

You might have to keep "removal", but I suspect "deprecation" should no longer be necessary, now that this class is deprecated (though I might be wrong).

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 20:31:19 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 20:31:19 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v3]
In-Reply-To: <VbcWWjmnhV95Cwe4OloiTgAP_3aQ1Vg7uSLRzRv2xQo=.52de25d9-1ebe-4a4c-bafe-0889d7bddbd2@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
 <57tCMPyMZXEaZS0mD_NQ-H_XBkY2FyPVDtxufVCG--E=.6768ebb8-bfcb-4814-bb98-361cc5700cbb@github.com>
 <VbcWWjmnhV95Cwe4OloiTgAP_3aQ1Vg7uSLRzRv2xQo=.52de25d9-1ebe-4a4c-bafe-0889d7bddbd2@github.com>
Message-ID: <S710cO80pb_5jg94LhGcFZ2kP6EHsQ_Qe1DCMGjETTs=.e2ad7fca-2db9-47f0-b9bc-962743db567a@github.com>

On Wed, 30 Nov 2022 17:27:05 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Deprecated annotation on the package-private classes
>
> src/java.management/share/classes/javax/management/loading/MLetParser.java line 254:
> 
>> 252:      * Parse the document pointed by the URL urlname
>> 253:      */
>> 254:     @SuppressWarnings({"deprecation", "removal"})
> 
> You might have to keep "removal", but I suspect "deprecation" should no longer be necessary, now that this class is deprecated (though I might be wrong).

OK this took me a few rebuilds to figure out:

Before these changes, MLetParser needs the deprecation suppressions, for URL.  If you remove that suppression, and you get warnings.

When I make MLetParser itself deprecated for removal, it no longer needs the deprecation suppression for URL, but does need suppression of e.g. MLet which is tagged for removal.

i.e. in a class marked for removal, we warn you for using other classes marked for removal, but not for using others only deprecated (as presumably the removal will happen before the simply deprecated class is removed).

So yes we can remove "deprecation" from that line, and only have "removal".  It's fine either way.  I can take it out as you've mentioned it.

-------------

PR: https://git.openjdk.org/jdk/pull/11430

From kevinw at openjdk.org  Wed Nov 30 20:37:38 2022
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 30 Nov 2022 20:37:38 GMT
Subject: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for
 Removal [v4]
In-Reply-To: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
References: <Ji8low12YtN5iTMjtD6MZPudtgOD8QvtBmM4eqHSY5o=.f384446e-574c-48c3-ab4d-5a719ec0a528@github.com>
Message-ID: <zvCGsvRm9viurR0SArmAefcta0gT62sP9HUZCa31-08=.16c77894-c174-4bc9-bbc4-b01c72c99b2b@github.com>

> Deprecate the Java Management Extension (JMX) Management Applet (m-let) feature for removal.
> 
> This deprecation will have no impact on users of other JMX features, the JDK's built-in instrumentation, or any of the observability tools.
> 
> More details in bug, and CSR JDK-8297795

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  unnecessary Suppression nit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11430/files
  - new: https://git.openjdk.org/jdk/pull/11430/files/8fc74d51..eab7dc65

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11430&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11430.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11430/head:pull/11430

PR: https://git.openjdk.org/jdk/pull/11430