jmx-dev RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v28]

[Paul Hohensee]

On Mon, 29 May 2023 02:02:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 100 commits:
>> 
>>  - 8304074: Remove extra file
>>  - 8304074: Add getTotalAllocatedBytes high water mark
>>  - Merge branch 'master' into 8304074
>>  - 8304074: Refactor test exception handling
>>  - Merge master
>>  - Merge master
>>  - 8304074: Change UnsupportedOperationException in javadoc comment to {@code UnsupportedOperationException}
>>  - 8306507: [linux] Print number of memory mappings in error reports
>>    
>>    Reviewed-by: adinn, sgehwolf
>>  - 8300086: Replace NULL with nullptr in share/c1/
>>    
>>    Reviewed-by: thartmann, chagedorn
>>  - 8308465: Reduce memory accesses in AArch64 MD5 intrinsic
>>    
>>    Reviewed-by: aph, phh
>>  - ... and 90 more: https://git.openjdk.org/jdk/compare/77c5adb0...5f2f86bb
>
> test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 305:
> 
>> 303:     }
>> 304: 
>> 305:     private static void reportUnexpected(Exception e, String reason) {
> 
> nit: 'when' or 'where' seems a more appropriate name than 'reason'

Changed to "when".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1209483911