From duke at openjdk.org  Fri Dec  6 17:17:50 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Fri, 6 Dec 2024 17:17:50 GMT
Subject: jmx-dev RFR: 8345684: Prevent NPE in
 OperatingSystemImpl#isCpuSetSameAsHostCpuSet
Message-ID: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>

The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.

-------------

Commit messages:
 - 8345684: Prevent NPE in OperatingSystemImpl#isCpuSetSameAsHostCpuSet

Changes: https://git.openjdk.org/jdk/pull/22611/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22611&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8345684
  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22611.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22611/head:pull/22611

PR: https://git.openjdk.org/jdk/pull/22611

From rriggs at openjdk.org  Fri Dec  6 17:47:37 2024
From: rriggs at openjdk.org (Roger Riggs)
Date: Fri, 6 Dec 2024 17:47:37 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE
In-Reply-To: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
Message-ID: <eQnJ9cgljxgy-6z4b8FZUaK41LHbapGvyyu3H0DRibg=.a86f8576-6492-4401-8dea-8272474fde43@github.com>

On Fri, 6 Dec 2024 17:05:42 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.

src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 278:

> 276:     private boolean isCpuSetSameAsHostCpuSet() {
> 277:         if (containerMetrics != null) {
> 278:             int[] cpuSetCpus = containerMetrics.getCpuSetCpus();

Might be worth a comment about the volatility of getCpuSetCpus() to head off someone changing it back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22611#discussion_r1873771463

From duke at openjdk.org  Fri Dec  6 18:02:53 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Fri, 6 Dec 2024 18:02:53 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
Message-ID: <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>

> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.

Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:

  Add comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22611/files
  - new: https://git.openjdk.org/jdk/pull/22611/files/f7a442b3..30d1b03b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22611&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22611&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22611.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22611/head:pull/22611

PR: https://git.openjdk.org/jdk/pull/22611

From duke at openjdk.org  Fri Dec  6 18:02:54 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Fri, 6 Dec 2024 18:02:54 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <eQnJ9cgljxgy-6z4b8FZUaK41LHbapGvyyu3H0DRibg=.a86f8576-6492-4401-8dea-8272474fde43@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <eQnJ9cgljxgy-6z4b8FZUaK41LHbapGvyyu3H0DRibg=.a86f8576-6492-4401-8dea-8272474fde43@github.com>
Message-ID: <0WWkp1KLx2eVKfbENtoFYncVxfvWKtGFk5Q8crhSXWs=.0e904b21-050e-4220-ad3f-849b8ed2b2ba@github.com>

On Fri, 6 Dec 2024 17:45:17 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 278:
> 
>> 276:     private boolean isCpuSetSameAsHostCpuSet() {
>> 277:         if (containerMetrics != null) {
>> 278:             int[] cpuSetCpus = containerMetrics.getCpuSetCpus();
> 
> Might be worth a comment about the volatility of getCpuSetCpus() to head off someone changing it back.

I added a comment explaining both the volatility and the potential cost.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22611#discussion_r1873792776

From dholmes at openjdk.org  Mon Dec  9 04:39:38 2024
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 9 Dec 2024 04:39:38 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
Message-ID: <ReRmrfi2CTJ2qH1AOs6bl9E6buhr1vy6q6g63uQtmDA=.8d584fba-e507-4e39-a7f9-80bfbc6acf86@github.com>

On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment

LGTM.

Aside: from a Java API design perspective I think these container API's should be returning empty arrays not null

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22611#pullrequestreview-2487712607

From kevinw at openjdk.org  Mon Dec  9 09:04:37 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 9 Dec 2024 09:04:37 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
Message-ID: <6QVUUCx4lN8OQtLHhtTW9Ey71poRcxB1wYTxEimBbwg=.9fb698f4-8cbc-4a92-bd99-75483904bb60@github.com>

On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment

Looks good, thanks 8-)

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22611#pullrequestreview-2488163974

From duke at openjdk.org  Mon Dec  9 09:31:37 2024
From: duke at openjdk.org (duke)
Date: Mon, 9 Dec 2024 09:31:37 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
Message-ID: <O3Gvn-uOazHaVx9ovPgpWBT6AnrncEP11VGr7siNBUU=.38188aa2-e097-4351-9b93-8903b7b178be@github.com>

On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment

@fmeum 
Your change (at version 30d1b03b5ef6d4c1de72ef02ce8a94f98eec3a66) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527385393

From kevinw at openjdk.org  Mon Dec  9 09:45:37 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 9 Dec 2024 09:45:37 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v2]
In-Reply-To: <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <HzIumbGan-o104heXhYGkbu1PVPYxpbqQ3K66CAjhZc=.270f63c8-71dd-4eae-8440-605ee9055549@github.com>
Message-ID: <ODXrgsOlOx92gVnMyPxd-yi9g7BteEk0YDNbAwQ2T7g=.b809381d-9d8e-4999-b3aa-2d58d947fa20@github.com>

On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment

Hi, 
This looks fine, I'm sure it's ok to proceed without waiting for a re-review from Roger about the comment.

It would be good to see the "Checks" tab show more than just jcheck.
Looks like this needs to be enabled in the personal fork.
https://wiki.openjdk.org/display/SKARA/Testing

Then we get some basic builds and tests done for us, and can go ahead with (even more) confidence!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527418181

From duke at openjdk.org  Mon Dec  9 10:07:14 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Mon, 9 Dec 2024 10:07:14 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
Message-ID: <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>

> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.

Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:

  Empty commit to trigger CI checks

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22611/files
  - new: https://git.openjdk.org/jdk/pull/22611/files/30d1b03b..0364f6b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22611&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22611&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22611.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22611/head:pull/22611

PR: https://git.openjdk.org/jdk/pull/22611

From kevinw at openjdk.org  Mon Dec  9 10:35:38 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 9 Dec 2024 10:35:38 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
Message-ID: <KRLF1Sq1wNho50yu53B8CRMeJK1q-kqWYZSNY9w5MV8=.9d6caecc-149f-48b1-91a6-63f4063f92dd@github.com>

On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty commit to trigger CI checks

That's great.  As the sponsor label has gone, when these few tests finish I think you'll need to say /integrate again then I can sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527536154

From sgehwolf at openjdk.org  Mon Dec  9 10:49:38 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 9 Dec 2024 10:49:38 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
Message-ID: <w1YVIIckcg0nkGzgmlgHLNoVLwBKEmufodjxcBLbnh0=.b813d0f3-6fe0-4ede-a5fa-39819f513c24@github.com>

On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty commit to trigger CI checks

LGTM

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22611#pullrequestreview-2488428790

From duke at openjdk.org  Mon Dec  9 11:54:38 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Mon, 9 Dec 2024 11:54:38 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
Message-ID: <w_h-Z1zAUh-hOwrwPBPNKsax1bUlL-KYYCWmE4LtdxY=.a905a08b-d97a-4d83-9e0f-ff2c5b30bdf3@github.com>

On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty commit to trigger CI checks

`test (hs/tier1 compiler not-xcomp)` fails on all platforms, is this expected?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527706075

From kevinw at openjdk.org  Mon Dec  9 12:10:38 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 9 Dec 2024 12:10:38 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
Message-ID: <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>

On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Empty commit to trigger CI checks

I think we can consider that failure some annoying noise.  It's not expected, but this Java-only change isn't causing it, other builds are fine, we should proceed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527739227

From duke at openjdk.org  Mon Dec  9 12:17:43 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Mon, 9 Dec 2024 12:17:43 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
 <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
Message-ID: <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>

On Mon, 9 Dec 2024 12:07:33 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Empty commit to trigger CI checks
>
> I think we can consider that failure some annoying noise.  It's not expected, but this Java-only change isn't causing it, other builds are fine, we should proceed.

@kevinjwalls Thanks! Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527763061

From duke at openjdk.org  Mon Dec  9 12:17:44 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Mon, 9 Dec 2024 12:17:44 GMT
Subject: jmx-dev Integrated: 8345684:
 OperatingSystemMXBean.getSystemCpuLoad() throws NPE
In-Reply-To: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
Message-ID: <6XFbbLsKn_7bGo5nqYJ9H9RgBdbT8kf-o7ot-xV_6CM=.e479cd97-642e-4979-9420-1f16da43c3b5@github.com>

On Fri, 6 Dec 2024 17:05:42 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.

This pull request has now been integrated.

Changeset: d7ef3ac0
Author:    Fabian Meumertzheim <fabian at meumertzhe.im>
Committer: Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d7ef3ac0b7e677c4901c69ad4361b5de8408e8d3
Stats:     7 lines in 1 file changed: 5 ins; 0 del; 2 mod

8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE

Reviewed-by: dholmes, kevinw, sgehwolf

-------------

PR: https://git.openjdk.org/jdk/pull/22611

From sgehwolf at openjdk.org  Mon Dec  9 12:29:48 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 9 Dec 2024 12:29:48 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
 <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
 <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>
Message-ID: <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>

On Mon, 9 Dec 2024 12:14:32 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:

> Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?

Please see https://github.com/openjdk/jdk21u-dev?tab=readme-ov-file#welcome-to-openjdk-21-updates for the process.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527790319

From duke at openjdk.org  Mon Dec  9 12:36:46 2024
From: duke at openjdk.org (Fabian Meumertzheim)
Date: Mon, 9 Dec 2024 12:36:46 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
 <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
 <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>
 <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>
Message-ID: <OdgHlaGgt5sQCYIbFq-GsMbUDH7kU6m23n0CW82ovTw=.c76255b8-9449-4f5d-a3ab-a32a3b8fb774@github.com>

On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @kevinjwalls Thanks! Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?
>
>> Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?
> 
> Please see https://github.com/openjdk/jdk21u-dev?tab=readme-ov-file#welcome-to-openjdk-21-updates for the process.

@jerboaa It looks like I would need to be at least an *Author* to follow these instructions. Since this is my second merged PR to the OpenJDK, could I become one?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527806218

From ihse at openjdk.org  Mon Dec  9 12:52:16 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 9 Dec 2024 12:52:16 GMT
Subject: jmx-dev RFR: 8345800: Update copyright year to 2024 for
 serviceability in files where it was missed
Message-ID: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>

Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed. 

I have located these modified files using:

git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list

and then run a script to update the copyright year to 2024 on these files.

I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.

-------------

Commit messages:
 - 8345800: Update copyright year to 2024 for serviceability in files where it was missed

Changes: https://git.openjdk.org/jdk/pull/22641/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22641&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8345800
  Stats: 35 lines in 35 files changed: 0 ins; 0 del; 35 mod
  Patch: https://git.openjdk.org/jdk/pull/22641.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22641/head:pull/22641

PR: https://git.openjdk.org/jdk/pull/22641

From sgehwolf at openjdk.org  Mon Dec  9 13:02:44 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 9 Dec 2024 13:02:44 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
 <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
 <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>
 <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>
Message-ID: <FYBI7Jz5WtQqmdW_NO6cBkfU0RfZlaM_FrEzwKWNxAA=.e5dbea1d-2cd5-415e-9dcb-045278acb299@github.com>

On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @kevinjwalls Thanks! Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?
>
>> Apologies in advance if this is not the right process, but could this be cherry-picked into JDK 21?
> 
> Please see https://github.com/openjdk/jdk21u-dev?tab=readme-ov-file#welcome-to-openjdk-21-updates for the process.

> @jerboaa It looks like I would need to be at least an _Author_ to follow these instructions. Since this is my second merged PR to the OpenJDK, could I become one?

For the skara bot command, yes. For manual contribution, no. See https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527863019

From sgehwolf at openjdk.org  Mon Dec  9 13:05:44 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 9 Dec 2024 13:05:44 GMT
Subject: jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad()
 throws NPE [v3]
In-Reply-To: <FYBI7Jz5WtQqmdW_NO6cBkfU0RfZlaM_FrEzwKWNxAA=.e5dbea1d-2cd5-415e-9dcb-045278acb299@github.com>
References: <rQPCjO4-FGHvQz8NJ2rlTNbp3XfrxbH7SOJ5aHnDSNI=.33109496-d70a-45b0-b733-dae684b5c5a5@github.com>
 <NfkLmJuUXsyLU1GQJwreiXEg_1l7wzsJpvcatcCAhbk=.ac687ad3-c64b-41df-8f18-db27cd768249@github.com>
 <Pzf8lrBR5HUA56AvmBWywML4NDTiTN-7DIW8wPE9qqA=.e59bc8a4-546c-4efa-9776-39087c682ed8@github.com>
 <A1AHx4beBeLLYVEgzX8JyTAx-GqPUjfU3Hb_08JL7u8=.2c0523eb-d72e-4c08-a02e-ff63692f0e9f@github.com>
 <Lb3Y6rZDVtQbyIB0To-JDJlufZG3SjwtOZojwdl3c9c=.60e94432-5745-4097-a952-8ab516519c1b@github.com>
 <FYBI7Jz5WtQqmdW_NO6cBkfU0RfZlaM_FrEzwKWNxAA=.e5dbea1d-2cd5-415e-9dcb-045278acb299@github.com>
Message-ID: <Fh5Z_IEV5s7lV-xc6-Ilmk0HU1Uf7FRX_pBXQRGp2i0=.1bf2fff2-9eef-48dc-ad17-f80f8d80f961@github.com>

On Mon, 9 Dec 2024 13:00:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Since this is my second merged PR to the OpenJDK, could I become one?

If you want to be, the process for becoming OpenJDK author is described here:
https://openjdk.org/projects/#project-author

The relevant project is `jdk`:
https://openjdk.org/census#jdk

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22611#issuecomment-2527868999

From dholmes at openjdk.org  Wed Dec 11 04:57:41 2024
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 11 Dec 2024 04:57:41 GMT
Subject: jmx-dev RFR: 8345800: Update copyright year to 2024 for
 serviceability in files where it was missed
In-Reply-To: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
References: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
Message-ID: <-O63pJFv2OIGn8Olif3wn0o4uZvOjXJM21NSLs2L-AY=.5450b9d6-1b93-4985-b39b-11f0d6b3987a@github.com>

On Mon, 9 Dec 2024 12:47:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed. 
> 
> I have located these modified files using:
> 
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
> 
> and then run a script to update the copyright year to 2024 on these files.
> 
> I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.

Looks fine. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22641#pullrequestreview-2494302930

From cjplummer at openjdk.org  Wed Dec 11 05:17:37 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Wed, 11 Dec 2024 05:17:37 GMT
Subject: jmx-dev RFR: 8345800: Update copyright year to 2024 for
 serviceability in files where it was missed
In-Reply-To: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
References: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
Message-ID: <j6LNBRZirS4dnsX1liqzNwlY0HjyBcm0oWUqXrY7WGs=.1cb1b45b-02fb-4463-a5ae-ab08fc9b4793@github.com>

On Mon, 9 Dec 2024 12:47:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed. 
> 
> I have located these modified files using:
> 
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
> 
> and then run a script to update the copyright year to 2024 on these files.
> 
> I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22641#pullrequestreview-2494338627

From ihse at openjdk.org  Wed Dec 11 10:42:41 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 11 Dec 2024 10:42:41 GMT
Subject: jmx-dev Integrated: 8345800: Update copyright year to 2024 for
 serviceability in files where it was missed
In-Reply-To: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
References: <lExmFfuklP6QLVH5CDs9DL8CM74aOAHw_aKZhdFfiNo=.39514bbd-2129-4eb1-b22f-5bbbb744eead@github.com>
Message-ID: <8l27FhFflmkDUv3akafFRxz3alMFavBidxojAo29yiY=.7a61e8af-206a-4418-b2ab-d09057329018@github.com>

On Mon, 9 Dec 2024 12:47:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed. 
> 
> I have located these modified files using:
> 
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
> 
> and then run a script to update the copyright year to 2024 on these files.
> 
> I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.

This pull request has now been integrated.

Changeset: c9ec2716
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c9ec2716a5486e6304caa863d00fe2f5ef975602
Stats:     35 lines in 35 files changed: 0 ins; 0 del; 35 mod

8345800: Update copyright year to 2024 for serviceability in files where it was missed

Reviewed-by: dholmes, cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/22641

From kevinw at openjdk.org  Wed Dec 11 12:25:15 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 11 Dec 2024 12:25:15 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class
Message-ID: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>

A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).

While here, there are a few imports of Util that are unnecessary.

No changes to the module visibility/exports.

-------------

Commit messages:
 - unused imports
 - 8345984: Remove redundant checkXXX methods from java.management Util class

Changes: https://git.openjdk.org/jdk/pull/22680/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22680&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8345984
  Stats: 15 lines in 4 files changed: 0 ins; 15 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/22680.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22680/head:pull/22680

PR: https://git.openjdk.org/jdk/pull/22680

From alanb at openjdk.org  Wed Dec 11 12:58:38 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 11 Dec 2024 12:58:38 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class
In-Reply-To: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
Message-ID: <i47QI4mC__82sZ40jBs84Zi1Am8eHfPnQn_i1rcTOg0=.cab273af-7419-4f8a-a44b-ff9bbc245038@github.com>

On Wed, 11 Dec 2024 12:17:55 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
> 
> While here, there are a few imports of Util that are unnecessary.
> 
> No changes to the module visibility/exports.

This looks okay, you might have to bump the copyright on a few files.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22680#pullrequestreview-2495587969

From kevinw at openjdk.org  Wed Dec 11 12:58:39 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 11 Dec 2024 12:58:39 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class
In-Reply-To: <i47QI4mC__82sZ40jBs84Zi1Am8eHfPnQn_i1rcTOg0=.cab273af-7419-4f8a-a44b-ff9bbc245038@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <i47QI4mC__82sZ40jBs84Zi1Am8eHfPnQn_i1rcTOg0=.cab273af-7419-4f8a-a44b-ff9bbc245038@github.com>
Message-ID: <wRJ5imA5D35s9LqM1OfbmpzNzDeuCh85O8kOKcVvpfY=.df61b560-6831-403b-9eca-ace9fc748960@github.com>

On Wed, 11 Dec 2024 12:53:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> This looks okay, you might have to bump the copyright on a few files.

Thanks, yes I think the GcInfoBuilder.java file, will update.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22680#issuecomment-2535917919

From kevinw at openjdk.org  Wed Dec 11 13:04:51 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 11 Dec 2024 13:04:51 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
Message-ID: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>

> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
> 
> While here, there are a few imports of Util that are unnecessary.
> 
> No changes to the module visibility/exports.

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  (C)

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22680/files
  - new: https://git.openjdk.org/jdk/pull/22680/files/b27b6426..4b2872db

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22680&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22680&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22680.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22680/head:pull/22680

PR: https://git.openjdk.org/jdk/pull/22680

From alanb at openjdk.org  Wed Dec 11 13:11:41 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Wed, 11 Dec 2024 13:11:41 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <ny1jo3qGZyW-H1jp8KHBYH82uwE6lbdVISLfrlsMQ18=.6f2bbf4d-ae47-4847-b3cb-aaf70c857fc6@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22680#pullrequestreview-2495624850

From mchung at openjdk.org  Wed Dec 11 17:21:17 2024
From: mchung at openjdk.org (Mandy Chung)
Date: Wed, 11 Dec 2024 17:21:17 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <E-PGS25M63eR2g49rY9vJGHRvmytuSUKsQlqavYYRe8=.d15cdc2c-f631-4938-a797-21cb693e9268@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

LGTM

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22680#pullrequestreview-2496338165

From kevinw at openjdk.org  Wed Dec 11 17:27:15 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 11 Dec 2024 17:27:15 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <7AaT3ON_oYGJ-10XYXTfo-42362PgsKEBKqBJgsWjO0=.b1189219-481b-40f4-9cc3-638e78467ae7@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

Thanks Alan and Mandy!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22680#issuecomment-2536614757

From cjplummer at openjdk.org  Wed Dec 11 18:51:13 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Wed, 11 Dec 2024 18:51:13 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <b6pX0CAKjIHNPsdovohcoCAh0_5KtwBs_7YA_CG5rPs=.c45f3871-e384-411e-a3f4-6ea472814187@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22680#pullrequestreview-2496559877

From sspitsyn at openjdk.org  Wed Dec 11 19:28:53 2024
From: sspitsyn at openjdk.org (Serguei Spitsyn)
Date: Wed, 11 Dec 2024 19:28:53 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <eSlltR60g1SGxxsfFOMA09u5xRZcP80yo5AbqUGooiQ=.82870381-f2b4-4bb0-8baf-bea9cd4f4bd9@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

Marked as reviewed by sspitsyn (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22680#pullrequestreview-2496643428

From kevinw at openjdk.org  Thu Dec 12 09:18:44 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Thu, 12 Dec 2024 09:18:44 GMT
Subject: jmx-dev RFR: 8345984: Remove redundant checkXXX methods from
 java.management Util class [v2]
In-Reply-To: <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
 <8lCtMh0ZXWX_SyumKbdZ9g4rFk6ioGY8KCZkX4iurHs=.52cdf672-781d-43c8-9201-db120ee47a75@github.com>
Message-ID: <LYE30K4fUmTkno0dwt_5Ix4x_9NADIipcNHBoeFHD2s=.0dcf6f0c-f1a8-4e1d-8e58-272dab4d07e2@github.com>

On Wed, 11 Dec 2024 13:04:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
>> 
>> While here, there are a few imports of Util that are unnecessary.
>> 
>> No changes to the module visibility/exports.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   (C)

Thanks Chris and Serguei!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22680#issuecomment-2538298227

From kevinw at openjdk.org  Thu Dec 12 09:18:45 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Thu, 12 Dec 2024 09:18:45 GMT
Subject: jmx-dev Integrated: 8345984: Remove redundant checkXXX methods from
 java.management Util class
In-Reply-To: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
References: <AXrlP1kUjG1Wh4RDNa78_l757f-flcbIWwmatxnRViY=.0308313b-6fb4-4bf4-aebb-51a5dec60f79@github.com>
Message-ID: <b3DIm3Jso3YKeR63JE1beJEC0BsahFO4Y1GvIbp9zVA=.1c043e4b-7f31-4908-b0e9-aab9710236c2@github.com>

On Wed, 11 Dec 2024 12:17:55 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> A post-SecurityManager removal cleanup task, to remove checkAccess(), checkMonitorAccess() and checkControlAccess() from src/java.management/share/classes/sun/management/Util.java (methods are already no-ops).
> 
> While here, there are a few imports of Util that are unnecessary.
> 
> No changes to the module visibility/exports.

This pull request has now been integrated.

Changeset: 3f2556b8
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3f2556b86079fbdba848b1ac16b62a376386999b
Stats:     16 lines in 4 files changed: 0 ins; 15 del; 1 mod

8345984: Remove redundant checkXXX methods from java.management Util class

Reviewed-by: alanb, mchung, cjplummer, sspitsyn

-------------

PR: https://git.openjdk.org/jdk/pull/22680

From kevinw at openjdk.org  Fri Dec 13 19:51:09 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Fri, 13 Dec 2024 19:51:09 GMT
Subject: jmx-dev RFR: 8241865: sun/management/jdp tests fail (Timed out
 waiting for JDP packet)
Message-ID: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>

This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".

Forcing it to require any other OS version looks good in my testing.

-------------

Commit messages:
 - remove uncalled misspelled method
 - (C)
 - update
 - update
 - 8241865: sun/management/jdp tests fail (Timed out waiting for JDP packet)

Changes: https://git.openjdk.org/jdk/pull/22742/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22742&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8241865
  Stats: 40 lines in 10 files changed: 7 ins; 7 del; 26 mod
  Patch: https://git.openjdk.org/jdk/pull/22742.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22742/head:pull/22742

PR: https://git.openjdk.org/jdk/pull/22742

From kevinw at openjdk.org  Fri Dec 13 19:51:09 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Fri, 13 Dec 2024 19:51:09 GMT
Subject: jmx-dev RFR: 8241865: sun/management/jdp tests fail (Timed out
 waiting for JDP packet)
In-Reply-To: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
References: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
Message-ID: <Umysv5AlUuJeG0a6A1KEr6lxIwUYyrdd9Gkg_SVFrDc=.4d89debd-b04b-41c5-90b9-81aa7967b3ff@github.com>

On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".
> 
> Forcing it to require any other OS version looks good in my testing.

There was a Linux x64 failure a few years back, but since un-problemlisting in August 2024, macos aarch64 is where we are seeing failures.  A batch of 20 run will generally see a few failures on that platform and nowhere else.

I did some experiments with other fixes such as long timeouts, retrying the test, pausing and retrying the test.
But the OSX 15.0.1 failure is not solved by any of these.  Requiring any other OS version seems better than problemlisting, and means we do run this test on multiple other MacOSX aarch64 versions.

While here:

Some typos and formatting changes.

When handling SocketTimeoutException, don't capitalise the method as "onSocketTimeOut()", make the "Timeout" case consistent (which made my searching easier).

Remove the ' quotes from the loggers, that looks strange in the logs, probably unintentional.  Output is now like:
2024-12-12 18:39:50 FINE    Pause in between packets is: 1 seconds.
2024-12-12 18:39:50 FINE    Timeout set to 20 seconds.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22742#issuecomment-2542168289

From cjplummer at openjdk.org  Fri Dec 13 20:42:35 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Fri, 13 Dec 2024 20:42:35 GMT
Subject: jmx-dev RFR: 8241865: sun/management/jdp tests fail (Timed out
 waiting for JDP packet)
In-Reply-To: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
References: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
Message-ID: <D5P6UjLrDfQ1FhH58pJNJrTNBJERsnt-bvtfmxWkeU0=.74e9c5c6-9c7a-4200-b0c7-986687766cbd@github.com>

On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".
> 
> Forcing it to require any other OS version looks good in my testing.

test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33:

> 31:  * @test JdpDefaultsTest
> 32:  * @summary Assert that we can read JDP packets from a multicast socket connection, on default IP and port.
> 33:  * @requires os.version != "Mac OS X 15.0.1 (aarch64)"

Unless there is a known reason why this test cannot run on this platform, this is probably not the appropriate fix here. I'd suggest keeping the CR open and problem listing for macosx-aarch64.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22742#discussion_r1884519109

From kevinw at openjdk.org  Fri Dec 13 22:40:37 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Fri, 13 Dec 2024 22:40:37 GMT
Subject: jmx-dev RFR: 8241865: sun/management/jdp tests fail (Timed out
 waiting for JDP packet)
In-Reply-To: <D5P6UjLrDfQ1FhH58pJNJrTNBJERsnt-bvtfmxWkeU0=.74e9c5c6-9c7a-4200-b0c7-986687766cbd@github.com>
References: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
 <D5P6UjLrDfQ1FhH58pJNJrTNBJERsnt-bvtfmxWkeU0=.74e9c5c6-9c7a-4200-b0c7-986687766cbd@github.com>
Message-ID: <RU6a9E2fMU6bpHRtA-3y1Nhy7Z4ol_OYXKn_0w0C2oU=.4841d82e-6359-4329-85a3-081423e3c185@github.com>

On Fri, 13 Dec 2024 20:40:03 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".
>> 
>> Forcing it to require any other OS version looks good in my testing.
>
> test/jdk/sun/management/jdp/JdpDefaultsTest.java line 33:
> 
>> 31:  * @test JdpDefaultsTest
>> 32:  * @summary Assert that we can read JDP packets from a multicast socket connection, on default IP and port.
>> 33:  * @requires os.version != "Mac OS X 15.0.1 (aarch64)"
> 
> Unless there is a known reason why this test cannot run on this platform, this is probably not the appropriate fix here. I'd suggest keeping the CR open and problem listing for macosx-aarch64.

Ok, I was thinking about debating that after many failures on 15.0.1 and nothing else... But just now we see one on "Mac OS X 12.7.1 (aarch64)" so problemlisting for macosx-aarch64 generally now seems right! (will update)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22742#discussion_r1884615620

From kevinw at openjdk.org  Mon Dec 16 11:30:39 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 16 Dec 2024 11:30:39 GMT
Subject: jmx-dev RFR: 8241865: sun/management/jdp tests fail (Timed out
 waiting for JDP packet) (macosx-aarch64)
In-Reply-To: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
References: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
Message-ID: <rXDmnCAbJnPB3A9UIPMtqPw69dQkWMSWeoCmPNuYTTI=.095cdb0a-b7e9-4176-a751-3d540c3c228c@github.com>

On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".
> 
> Forcing it to require any other OS version looks good in my testing.

Closing this and following up with:

Problemlisting: https://github.com/openjdk/jdk/pull/22758

Other JDP test tidyups: https://github.com/openjdk/jdk/pull/22761

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22742#issuecomment-2545363247

From kevinw at openjdk.org  Mon Dec 16 11:30:40 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 16 Dec 2024 11:30:40 GMT
Subject: jmx-dev Withdrawn: 8241865: sun/management/jdp tests fail (Timed
 out waiting for JDP packet) (macosx-aarch64)
In-Reply-To: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
References: <h2gRp3uUntfTjenMjiH0L5iFJ2Cs3sacZCcZ4Y4uFJY=.958f23fd-0a0e-4542-9eed-88c34f85cf9e@github.com>
Message-ID: <-r4kxdjoROaxmQAcLaaMlSHE3zN9oikIDBtKaSG1Ba8=.e004c79c-4a68-4b69-a8cc-50eda8709422@github.com>

On Fri, 13 Dec 2024 18:58:12 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test has been noisy lately, and all the failures have been on "Mac OS X 15.0.1 (aarch64)".
> 
> Forcing it to require any other OS version looks good in my testing.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/22742

From kevinw at openjdk.org  Mon Dec 16 11:59:04 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 16 Dec 2024 11:59:04 GMT
Subject: jmx-dev RFR: 8346261: Cleanup in JDP tests
Message-ID: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>

Simple test update to fix some typos and formatting changes, seen while investigating and testing for JDK-8241865.

-------------

Commit messages:
 - 8346261: Cleanup in JDP tests

Changes: https://git.openjdk.org/jdk/pull/22761/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22761&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8346261
  Stats: 37 lines in 10 files changed: 5 ins; 7 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/22761.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22761/head:pull/22761

PR: https://git.openjdk.org/jdk/pull/22761

From cjplummer at openjdk.org  Mon Dec 16 16:40:40 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Mon, 16 Dec 2024 16:40:40 GMT
Subject: jmx-dev RFR: 8346261: Cleanup in JDP tests
In-Reply-To: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
References: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
Message-ID: <mRDRo1cXqREER8GlsglTJ9WiMfrQkD2xng-cxGJW66Y=.8a66fe93-26c4-454f-b3b5-5bf38d037d00@github.com>

On Mon, 16 Dec 2024 11:11:20 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Simple test update to fix some typos and formatting changes, seen while investigating and testing for JDK-8241865.

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22761#pullrequestreview-2506724102

From kevinw at openjdk.org  Mon Dec 16 17:20:43 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 16 Dec 2024 17:20:43 GMT
Subject: jmx-dev RFR: 8346261: Cleanup in JDP tests
In-Reply-To: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
References: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
Message-ID: <aRBwZXcrOYd50Gu1yDb-PJJFC9ML-TYJX8Cu4ESwF2U=.8ae76bdc-3e6b-467e-a30c-926e7b3ad0b9@github.com>

On Mon, 16 Dec 2024 11:11:20 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Simple test update to fix some typos and formatting changes, seen while investigating and testing for JDK-8241865.

Thanks again!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22761#issuecomment-2546199952

From kevinw at openjdk.org  Mon Dec 16 17:20:44 2024
From: kevinw at openjdk.org (Kevin Walls)
Date: Mon, 16 Dec 2024 17:20:44 GMT
Subject: jmx-dev Integrated: 8346261: Cleanup in JDP tests
In-Reply-To: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
References: <49OadIoWQUQf1OpjnCaWWa8vKU0iEOtNoVI2Nmm0RGU=.95c82dc7-7976-4f0d-8745-dddc39436c00@github.com>
Message-ID: <s0S1YdAQSdQY_6bP6UGlHczunxpRr1ImbYEhEzU9vx4=.4a9156fa-ea83-444b-9898-95e1f18b063c@github.com>

On Mon, 16 Dec 2024 11:11:20 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Simple test update to fix some typos and formatting changes, seen while investigating and testing for JDK-8241865.

This pull request has now been integrated.

Changeset: 57adf64a
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/57adf64ab4e50fd1739eb8ed14331d49f943b5e5
Stats:     37 lines in 10 files changed: 5 ins; 7 del; 25 mod

8346261: Cleanup in JDP tests

Reviewed-by: cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/22761