jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v2]

[Fabian Meumertzheim]

On Fri, 6 Dec 2024 17:45:17 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java line 278:
> 
>> 276:     private boolean isCpuSetSameAsHostCpuSet() {
>> 277:         if (containerMetrics != null) {
>> 278:             int[] cpuSetCpus = containerMetrics.getCpuSetCpus();
> 
> Might be worth a comment about the volatility of getCpuSetCpus() to head off someone changing it back.

I added a comment explaining both the volatility and the potential cost.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22611#discussion_r1873792776