jmx-dev RFR: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE [v2]
David Holmes
dholmes at openjdk.org
Mon Dec 9 04:39:38 UTC 2024
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim <duke at openjdk.org> wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision:
>
> Add comment
LGTM.
Aside: from a Java API design perspective I think these container API's should be returning empty arrays not null
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22611#pullrequestreview-2487712607
More information about the jmx-dev
mailing list