jmx-dev RFR: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature [v3]
Kevin Walls
kevinw at openjdk.org
Wed Jan 10 15:18:25 UTC 2024
On Wed, 10 Jan 2024 13:55:51 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unnecessary MLET_ Properties
>
> test/jdk/javax/management/Introspector/ClassLeakTest.java line 55:
>
>> 53: ObjectName testName = new ObjectName("x:name=Test");
>> 54: Test mbean = new Test();
>> 55: mbs.registerMBean(mbean, testName);
>
> I suspect this test should first register an MBean which is a ClassLoader implementing PrivateClassLoader, through which the TestMBean would be loaded in order to preserve the semantics of the test.
>
> In other words, replace the MLet with a regular MBean that extends URLClassLoader and implements PrivateClassLoader and do the same thing than the original test was doing.
I didn't see great value in it, as we no longer provide an MBean which is a ClassLoader.
Having a test MBean that extends URLClassLoader, and calling its loadClass()... is basically testing URLClassLoader? 8-)
Implementing PrivateClassLoader affects ClassLoaderRepository behaviour, but that's not tested here.
If you think this has value, we can do it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16363#discussion_r1447525897
More information about the jmx-dev
mailing list