jmx-dev RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name

Chris Plummer cjplummer at openjdk.org
Thu Jul 11 15:25:55 UTC 2024


On Thu, 11 Jul 2024 14:51:18 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Follow-on from JDK-8207908.
> 
> Two tests are broken by that change:
> sun/management/jmxremote/startstop/JMXStartStopTest.java	
> sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java
> 
> These are additional tests which use jcmd and an application name pattern to find a process.
> They should use the PID to avoid finding a process from some other concurrent test invocation.
> So it's good to have the same kind of change applied here too.

test/jdk/sun/management/jmxremote/startstop/JMXStartStopTest.java line 351:

> 349:                     pid = p.pid();
> 350:                     jcmd = new ManagementAgentJcmd(p, verbose);
> 351: 

I don't think you want a blank line here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20138#discussion_r1674217138


More information about the jmx-dev mailing list