jmx-dev RFR: 8336257: Additional tests in jmxremote/startstop to match on PID not app name [v2]

Daniel D. Daugherty dcubed at openjdk.org
Thu Jul 11 20:34:58 UTC 2024


On Thu, 11 Jul 2024 15:38:29 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Follow-on from JDK-8207908.
>> 
>> Two tests are broken by that change:
>> sun/management/jmxremote/startstop/JMXStartStopTest.java	
>> sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java
>> 
>> These are additional tests which use jcmd and an application name pattern to find a process.
>> They should use the PID to avoid finding a process from some other concurrent test invocation.
>> So it's good to have the same kind of change applied here too.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   line

The fix looks good to me. I presume it has been tested
with a Mach5 Tier3 job set.

@kevinjwalls - When do you expect to integrate this fix? It looks like
we're seeing 34 failures per Tier3 job set due to this issue.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20138#pullrequestreview-2172977359
PR Comment: https://git.openjdk.org/jdk/pull/20138#issuecomment-2223872373


More information about the jmx-dev mailing list