jmx-dev Integrated: 8373441: Remove DCmdFactory::_enabled
Ioi Lam
iklam at openjdk.org
Tue Dec 16 23:20:27 UTC 2025
On Fri, 12 Dec 2025 14:54:52 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The `DCmdFactory::_enabled` is always set to `true` and there doesn't seem to be a reason to set it to `false`.
>
> This PR removes this field and simplified the creation of `DCmdFactory` objects.
>
> The related `_hidden` field is also currently not used, but may be used in the future when deprecating DCmds, so we leave it unchanged.
>
> Note that now `jmm_GetDiagnosticCommandInfo()` always set `dcmdInfo::enabled` to `true` to be compatible with Java code.
This pull request has now been integrated.
Changeset: 3f077102
Author: Ioi Lam <iklam at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3f07710270dbe7268f21828dff20e2eb810b1e70
Stats: 102 lines in 7 files changed: 4 ins; 25 del; 73 mod
8373441: Remove DCmdFactory::_enabled
Reviewed-by: kevinw, fparain, jsjolen
-------------
PR: https://git.openjdk.org/jdk/pull/28794
More information about the jmx-dev
mailing list