jmx-dev RFR: 8345079: Simplify/cleanup Exception handling in RMIConnectionImpl [v3]

[Daniel Fuchs]

On Mon, 20 Jan 2025 20:21:48 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> This is a post-SecurityManager-removal cleanup, following-on from:
>> 
>> 8344394: Remove SecurityManager and related calls from java.management.rmi 
>> 
>> 
>> Remove mention of "privilege" in Exception handling in RMIConnectionImpl.
>> Remove wrapping of Exceptions in PrivilegedActionException.
>> 
>> The methods that invoke an operation handle expected Exceptions, but also need to handle SecurityException and RuntimeException, to avoid their default case of wrapping an Exception in an IOException to signal a problem.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   oops

Look good. As a matter of style you could further simplify to:


} catch (XException | YException | ZException ex) {
    throw ex;
} catch (Exception unexpected) {
     throw new IOException("Got unexpected server exception: " + unexpected, unexpected);
}


but that doesn't need to be in this changeset. Also it would be harder to review ;-)

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23072#pullrequestreview-2564842103