From kevinw at openjdk.org  Wed Jun 11 15:22:42 2025
From: kevinw at openjdk.org (Kevin Walls)
Date: Wed, 11 Jun 2025 15:22:42 GMT
Subject: jmx-dev RFR: 8358624: ImmutableDescriptor violates equals/hashCode
 contract after deserialization
Message-ID: <reyKSlJmZYqazfnPxUCK55oTUyXUIwt1B-eBYWDtpf8=.5b809f11-99a5-4817-815d-fd432d3d6fc6@github.com>

Hashcode needs to be reset to -1 to force its recalculation on next call, after deserialization.

The change in the readResolve() method is the fix for this problem.  While here I added similar lines in other methods that may update fields (although these are noted as not supported, they change a class named "immutable).

Added a test.  There is a test for serialization for this class, but I found it clearer to add the test for this specific recently discovered issue in its own test file.

-------------

Commit messages:
 - spelling
 - Exception name
 - whitespace
 - whitespace
 - 8358624: ImmutableDescriptor violates equals/hashCode contract after deserialization

Changes: https://git.openjdk.org/jdk/pull/25758/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25758&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8358624
  Stats: 82 lines in 2 files changed: 82 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25758.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25758/head:pull/25758

PR: https://git.openjdk.org/jdk/pull/25758

From kevinw at openjdk.org  Thu Jun 12 08:09:04 2025
From: kevinw at openjdk.org (Kevin Walls)
Date: Thu, 12 Jun 2025 08:09:04 GMT
Subject: jmx-dev RFR: 8351413: Remove XML interchange in
 java.management/javax/management/modelmbean/DescriptorSupport
Message-ID: <2rJne6yOnugYd-8O9FcZisLuyooQjTspKz0FUDfEYzw=.0c64bc01-3ffe-4f51-93c3-d81ed91ca325@github.com>

Removal of an obscure historical feature, following on from its deprecation for removal in:

8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal

-------------

Commit messages:
 - 8351413: Remove XML interchange in java.management/javax/management/modelmbean/DescriptorSupport

Changes: https://git.openjdk.org/jdk/pull/25697/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25697&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8351413
  Stats: 649 lines in 6 files changed: 0 ins; 644 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/25697.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25697/head:pull/25697

PR: https://git.openjdk.org/jdk/pull/25697

From sroy at openjdk.org  Thu Jun 12 16:07:09 2025
From: sroy at openjdk.org (Suchismith Roy)
Date: Thu, 12 Jun 2025 16:07:09 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
Message-ID: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>

JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)

c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)

This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.

Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.

Similarly for c2_globals.hpp &etc.

-------------

Commit messages:
 - Update c2_globals.hpp
 - c1 header
 - global headers

Changes: https://git.openjdk.org/jdk/pull/25773/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25773&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8348574
  Stats: 366 lines in 13 files changed: 2 ins; 360 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/25773.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25773/head:pull/25773

PR: https://git.openjdk.org/jdk/pull/25773

From mhaessig at openjdk.org  Thu Jun 12 16:53:30 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 12 Jun 2025 16:53:30 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
In-Reply-To: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
References: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
Message-ID: <SlD-5xgjDNawUTjiEnA3hum1jq3bXCdrOLCVfXFuNwk=.e0bd6eec-5f49-43c7-b152-fd4e9a1cfd6d@github.com>

On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)
> 
> c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)
> 
> This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.
> 
> Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.
> 
> Similarly for c2_globals.hpp &etc.

Thank you for working on this, @suchismith1993! Good to see the includes cleaned up.

This looks good to me, but I nevertheless kicked off some testing on our side. I will let you know how it went when the results are in.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25773#pullrequestreview-2921960450

From kbarrett at openjdk.org  Fri Jun 13 06:29:28 2025
From: kbarrett at openjdk.org (Kim Barrett)
Date: Fri, 13 Jun 2025 06:29:28 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
In-Reply-To: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
References: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
Message-ID: <wb2jgX5PIpkRu7SJGj4noJpsgWqtWE80L1binY_S4Yw=.ad836c4d-48f0-4f04-966e-138ab2d2418b@github.com>

On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)
> 
> c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)
> 
> This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.
> 
> Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.
> 
> Similarly for c2_globals.hpp &etc.

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25773#pullrequestreview-2923554527

From mhaessig at openjdk.org  Fri Jun 13 09:01:36 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Fri, 13 Jun 2025 09:01:36 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
In-Reply-To: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
References: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
Message-ID: <7iAduRwCTEhdlLrawIwYXAM4k5l5PRY7090XOYJeheE=.c279c29b-8316-4551-852c-d44bb8fe058a@github.com>

On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)
> 
> c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)
> 
> This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.
> 
> Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.
> 
> Similarly for c2_globals.hpp &etc.

Testing passed. Ship it!

-------------

Marked as reviewed by mhaessig (Author).

PR Review: https://git.openjdk.org/jdk/pull/25773#pullrequestreview-2923939477

From duke at openjdk.org  Fri Jun 13 09:17:30 2025
From: duke at openjdk.org (duke)
Date: Fri, 13 Jun 2025 09:17:30 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
In-Reply-To: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
References: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
Message-ID: <mMw3eJ099udlNfLFQP0jUmY1BUy2GYsVmXGmTYX1mDc=.ea38f68e-fcc0-48d2-850d-2ad81db0ecc2@github.com>

On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)
> 
> c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)
> 
> This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.
> 
> Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.
> 
> Similarly for c2_globals.hpp &etc.

@suchismith1993 
Your change (at version 993ee2632f0e7be6a6eb40d22a98c4e8d5da29e2) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25773#issuecomment-2969667508

From dcubed at openjdk.org  Fri Jun 13 16:14:46 2025
From: dcubed at openjdk.org (Daniel D. Daugherty)
Date: Fri, 13 Jun 2025 16:14:46 GMT
Subject: jmx-dev RFR: JDK-8348574 : Simplify c1/c2_globals inclusions
In-Reply-To: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
References: <JgBcVpl8EKJnGkaPv_XYNgxMozGngHOazef7s_Aepc0=.2a560ad9-b99d-46f4-ab43-409b405ca650@github.com>
Message-ID: <xVR85dKJNzZ2BtnAYUVBRJNf51OPHxgcGDkIz4Bbw0g=.4cd70809-f018-4524-b31e-0ad4f53741c1@github.com>

On Thu, 12 Jun 2025 08:32:56 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> JBS Issue : [JDK-8348574](https://bugs.openjdk.org/browse/JDK-8348574)
> 
> c1_globals.hpp includes c1_globals_pd.hpp. c1_globals_pd.hpp includes the corresponding CPU_HEADER and OS_HEADER files. All of the c1_globals_<os>.hpp files are essentially identical and basically empty. (They just include globalDefinitions.hpp and macros.hpp, and provide nothing additional.)
> 
> This could be simplified by having c1_globals.hpp do the CPU_HEADER inclusion directly, and remove c1_globals_pd.hpp and all c1_globals_<os>.hpp files.
> 
> Even if there are some non-vacuous c1_globals_<os>.hpp files in the future, c1_globals_pd.hpp seems unwarranted; just add the OS_HEADER include directly in c1_globals.hpp. The c1_globals_pd.hpp files really don't seem worth the extra indirection.
> 
> Similarly for c2_globals.hpp &etc.

(Gotta love it when you typo a lable^H^H^H^H^H label).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25773#issuecomment-2970862022