jmx-dev RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

Leonid Mesnik lmesnik at openjdk.org
Thu May 1 15:52:48 UTC 2025


On Thu, 1 May 2025 10:07:04 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Thanks Leonid, yes we could do it like that.  There have to be a load of ways we could arrange this.  Yes, it could be a little simpler that what we have now, although it's not _that_ complicated now...
>
> I do like having the Exception created at the point where we recognise there's a problem.  While the message could hard-code in the -1 in the Windows case, it must be also good to use the same expression to build the message, right next to each other.
> I also like keeping the existing Exception wording, there isn't a real need to change it.
> It's still a tiny little test routine and on future failure on Windows, it should be clear that we didn't receive any good values.
> On balance would you be OK if we leave as it stands?

sure, let left it as it is. 
Let return to this once 2019 is going to be EOL and remove all this stuff:
Looks good for me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24961#discussion_r2070435139


More information about the jmx-dev mailing list