[PATCH] 7901019: jol estimates do not take AllocationStyle into the account

[Aleksey Shipilev]

Nope, the attachment is still striped.

-Aleksey

On 01/25/2016 12:24 PM, Тимур Гибадуллин wrote:
> Ok, re-sent patch via apple’s mail client.
> 
> 
> 
> 
>> 22 янв. 2016 г., в 13:21, Aleksey Shipilev <aleksey.shipilev at oracle.com> написал(а):
>>
>> Hi Timur,
>>
>> The list is stripping the unknown attachments. The attachment should be
>> one of the following MIME types:
>> text/plain
>> text/x-diff
>> text/x-patch
>>
>> You can re-send directly to me if you want to know what's the MIME type
>> for your current attachment.
>>
>> Cheers,
>> -Aleksey
>>
>> On 01/21/2016 03:01 AM, Timur Gibadullin wrote:
>>> Sorry, forgot to attach the patch.
>>>
>>> 2016-01-21 2:44 GMT+03:00 Timur Gibadullin <timur.gbd at gmail.com>:
>>>
>>>> Hi! Thanks for the jol, which is such a handy tool. I'd like to improve it
>>>> and propose patch. I am trying to solve a bug with hotspot layouter, which
>>>> is described in the issue
>>>> <https://bugs.openjdk.java.net/browse/CODETOOLS-7901019> in the bug
>>>> database. And this is my first attempt to solve it, I prepared a patch (sending
>>>> as attahced to this mail). In the patch I followed Aleksey's comment from
>>>> the issue and added fieldAllocationStyle option to the HotspotLayouter and changed
>>>> HotspotLayouter's layout, now it emulates layout_fields method of the ClassFileParser
>>>> from Hotspot, actually, I ported this method from the Hotspot, refactored
>>>> it and dropped some unnecessary for the jol parts. Also I made little
>>>> additions to FieldData and ClassData classes, they are required by the new layout
>>>> method, and added a new example, which is called JOLSample_26_Hotspot.
>>>> Please, share your thoughts and give me any feedback and comments about my
>>>> patch.
>>>>
>>>>
>>>> --
>>>> Best regards, Timur Gibadullin
>>>>
>>>
>>>
>>>
>>
>>
>