From shade at redhat.com  Thu Jan 17 18:48:09 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 17 Jan 2019 18:48:09 +0000
Subject: hg: code-tools/jol: 3 new changesets
Message-ID: <201901171848.x0HImAcP023176@aojmv0008.oracle.com>

Changeset: fae3dfa61b12
Author:    shade
Date:      2019-01-17 19:34 +0100
URL:       http://hg.openjdk.java.net/code-tools/jol/rev/fae3dfa61b12

7902366: JOL should bump source/target to 7

! jol-cli/pom.xml
! jol-cli/src/main/java/org/openjdk/jol/Main.java
! jol-cli/src/main/java/org/openjdk/jol/OptionFormatter.java
! jol-cli/src/main/java/org/openjdk/jol/operations/HeapDumpStats.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectExternals.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectFootprint.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectIdealPacking.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectInternals.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectShapes.java
! jol-cli/src/main/java/org/openjdk/jol/operations/StringCompress.java
! jol-core/pom.xml
! jol-core/src/main/java/org/openjdk/jol/heap/HeapDumpReader.java
! jol-core/src/main/java/org/openjdk/jol/info/ClassData.java
! jol-core/src/main/java/org/openjdk/jol/info/GraphLayout.java
! jol-core/src/main/java/org/openjdk/jol/info/GraphWalker.java
! jol-core/src/main/java/org/openjdk/jol/layouters/CurrentLayouter.java
! jol-core/src/main/java/org/openjdk/jol/layouters/FieldAllocationType.java
! jol-core/src/main/java/org/openjdk/jol/layouters/HotSpotLayouter.java
! jol-core/src/main/java/org/openjdk/jol/layouters/RawLayouter.java
! jol-core/src/main/java/org/openjdk/jol/util/ClassUtils.java
! jol-core/src/main/java/org/openjdk/jol/util/Multiset.java
! jol-core/src/main/java/org/openjdk/jol/vm/ContendedSupport.java
! jol-core/src/main/java/org/openjdk/jol/vm/VM.java
! jol-core/src/main/java/org/openjdk/jol/vm/sa/AttachMain.java
! jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java
! jol-core/src/test/java/org/openjdk/jol/info/GraphLayoutExhaustionTests.java
! jol-core/src/test/java/org/openjdk/jol/jvms/DoubleInnerTest.java
! jol-core/src/test/java/org/openjdk/jol/layouters/HotspotLayouterRealTest.java
! jol-core/src/test/java/org/openjdk/jol/util/ByteClassLoader.java
! jol-samples/pom.xml
! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_16_AL_LL.java
! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_18_Layouts.java
! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_22_Compaction.java
! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_24_Colocation.java
! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_24_Difference.java
! pom.xml

Changeset: 01ad2c7891c9
Author:    shade
Date:      2019-01-17 19:34 +0100
URL:       http://hg.openjdk.java.net/code-tools/jol/rev/01ad2c7891c9

7902367: JOL should use upgraded plugins to be compatible with JDK 11, 12, 13

! pom.xml

Changeset: bf211aec9c07
Author:    shade
Date:      2019-01-17 19:34 +0100
URL:       http://hg.openjdk.java.net/code-tools/jol/rev/bf211aec9c07

7902368: JOL should be buildable with JDK 11, 12, 13

! jol-cli/pom.xml
! jol-core/pom.xml
! jol-core/src/main/java/org/openjdk/jol/info/ClassData.java
! jol-core/src/main/java/org/openjdk/jol/info/GraphLayout.java
! jol-core/src/main/java/org/openjdk/jol/util/ClassUtils.java
! jol-samples/pom.xml


From shade at redhat.com  Thu Jan 24 20:14:27 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 24 Jan 2019 21:14:27 +0100
Subject: JOL is hanging when running from module path
In-Reply-To: <bbab40bf-ce8e-0c21-0f99-ae3aff5e32a4@redhat.com>
References: <CAF2POUfxiWnSqpmO+5wcoOMRHfefWswQd90UQFJv5jVEj3cmNg@mail.gmail.com>
 <707bd607-367a-ed1e-2ec6-302252e80475@redhat.com>
 <bbab40bf-ce8e-0c21-0f99-ae3aff5e32a4@redhat.com>
Message-ID: <97e06268-7ba1-eb43-d5ba-a3ae9d0d91b0@redhat.com>

On 1/23/18 12:34 PM, Aleksey Shipilev wrote:
>> If the empty classpath is the problem, this should be the fix?
>>
>> $ hg diff
>> diff -r 03064c057dc9 jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java
>> --- a/jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java	Fri Sep 22
>> 17:29:25 2017 +0200
>> +++ b/jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java	Mon Nov 13
>> 11:25:52 2017 +0100
>> @@ -290,8 +290,10 @@
>>                  throw new IllegalStateException("Unhandled style: " + style);
>>          }
>>
>> -        args.add("-cp");
>> -        args.add(classPath);
>> +        if (!classPath.isEmpty()) {
>> +            args.add("-cp");
>> +            args.add(classPath);
>> +        }
>>          return args;
>>      }
>>
>> Can you try it?

This is pushed as:
  https://bugs.openjdk.java.net/browse/CODETOOLS-7902371

-Aleksey


From shade at redhat.com  Thu Jan 24 20:14:01 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 24 Jan 2019 20:14:01 +0000
Subject: hg: code-tools/jol: 7902371: JOL hangs with empty classpath
Message-ID: <201901242014.x0OKE1Kr004146@aojmv0008.oracle.com>

Changeset: 833f68a6ba34
Author:    shade
Date:      2019-01-24 21:09 +0100
URL:       http://hg.openjdk.java.net/code-tools/jol/rev/833f68a6ba34

7902371: JOL hangs with empty classpath

! jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java