From shade at openjdk.java.net  Fri Dec 10 16:13:51 2021
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 10 Dec 2021 16:13:51 GMT
Subject: RFR: CODETOOLS-7903075: JOL: Incorrect ClassLayout header/loss
 calculation for arrays
Message-ID: <hXn2bMDhtX3QT8Jgy3oV15waAuhgargm3TxBNeskOas=.dd62c732-7018-414c-a7d8-d2084fa1ef84@github.com>

See the bug report.

-------------

Commit messages:
 - Fix

Changes: https://git.openjdk.java.net/jol/pull/20/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jol&pr=20&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903075
  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jol/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/jol pull/20/head:pull/20

PR: https://git.openjdk.java.net/jol/pull/20

From stuefe at openjdk.java.net  Fri Dec 10 16:47:27 2021
From: stuefe at openjdk.java.net (Thomas Stuefe)
Date: Fri, 10 Dec 2021 16:47:27 GMT
Subject: RFR: CODETOOLS-7903075: JOL: Incorrect ClassLayout header/loss
 calculation for arrays
In-Reply-To: <hXn2bMDhtX3QT8Jgy3oV15waAuhgargm3TxBNeskOas=.dd62c732-7018-414c-a7d8-d2084fa1ef84@github.com>
References: <hXn2bMDhtX3QT8Jgy3oV15waAuhgargm3TxBNeskOas=.dd62c732-7018-414c-a7d8-d2084fa1ef84@github.com>
Message-ID: <1Qol2QS-RIcU4pobpDaPHvIc_bZQn45rMDhZi3C1Ihc=.af22183b-5d63-4508-a086-d546a93da444@github.com>

On Fri, 10 Dec 2021 16:09:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug report.

Don't know the code but seems fine. Patch works, alignment gap is correctly shown and accounted:


3-byte array, compressed class pointers on:

[B object internals:
OFF  SZ   TYPE DESCRIPTION               VALUE
  0   8        (object header: mark)     0x0000000000000001 (non-biasable; age: 0)
  8   4        (object header: class)    0x00006328
 12   4        (array length)            3
 16   3   byte [B.<elements>             N/A
 19   5        (object alignment gap)    
Instance size: 24 bytes
Space losses: 0 bytes internal + 5 bytes external = 5 bytes total


3-byte array, compressed class pointers off:


[B object internals:
OFF  SZ   TYPE DESCRIPTION               VALUE
  0   8        (object header: mark)     0x0000000000000001 (non-biasable; age: 0)
  8   8        (object header: class)    0x00007ffb3d8007e0
 16   4        (array length)            3
 20   4        (alignment/padding gap)
 24   3   byte [B.<elements>             N/A
 27   5        (object alignment gap)
Instance size: 32 bytes
Space losses: 4 bytes internal + 5 bytes external = 9 bytes total

-------------

PR: https://git.openjdk.java.net/jol/pull/20

From duke at openjdk.java.net  Fri Dec 10 19:22:48 2021
From: duke at openjdk.java.net (duke)
Date: Fri, 10 Dec 2021 19:22:48 GMT
Subject: git: openjdk/jol: 7903075: JOL: Incorrect ClassLayout header/loss
 calculation for arrays
Message-ID: <0c6a51e8-b5dc-4159-b8ac-9fe891d839a0@openjdk.java.net>

Changeset: eb83245c
Author:    Aleksey Shipil?v <shade at redhat.com>
Committer: GitHub <noreply at github.com>
Date:      2021-12-10 20:22:23 +0000
URL:       https://git.openjdk.java.net/jol/commit/eb83245c0cc4d380d086336ac0d294126516a243

7903075: JOL: Incorrect ClassLayout header/loss calculation for arrays


! jol-core/src/main/java/org/openjdk/jol/info/ClassLayout.java


From shade at openjdk.java.net  Fri Dec 10 19:25:26 2021
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Fri, 10 Dec 2021 19:25:26 GMT
Subject: Withdrawn: CODETOOLS-7903075: JOL: Incorrect ClassLayout header/loss
 calculation for arrays
In-Reply-To: <hXn2bMDhtX3QT8Jgy3oV15waAuhgargm3TxBNeskOas=.dd62c732-7018-414c-a7d8-d2084fa1ef84@github.com>
References: <hXn2bMDhtX3QT8Jgy3oV15waAuhgargm3TxBNeskOas=.dd62c732-7018-414c-a7d8-d2084fa1ef84@github.com>
Message-ID: <74hp7ZOXm9UgBZzHY0MzxXL0fMhyPn-WHU-eTF-zwjg=.c399169f-4bf3-4fab-b759-df31db906d02@github.com>

On Fri, 10 Dec 2021 16:09:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the bug report.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jol/pull/20