RFR: CODETOOLS-7902930: JOL: Bring back GraphWalker visitors
Aleksey Shipilev
shade at openjdk.java.net
Wed May 12 05:36:59 UTC 2021
On Fri, 7 May 2021 15:22:27 GMT, Martin Junghanns <github.com+318788+s1ck at openjdk.org> wrote:
>> Hey @shipilev First of all: Thanks for this useful library. I wanted to switch from jol 0.10 to 0.15 in one of my projects because of some issues on openJDK 15. I discovered that the ability to register visitors had been removed at some point. The interface `org.openjdk.jol.info.GraphVisitor` is actually still around. I find that feature quite useful as it allows users to compute some custom statistics of the object graph. I tried to use the `GraphLayout` to access the GPRs, but it's all package-private.
>>
>> It would be nice if we could bring the feature back. Also, if you think the approach is not ideal, we can maybe figure out something else.
>>
>> Thanks for your time.
>
> I can share our usage pattern. We are interested in the `path` and the `size`. Maybe it helps when designing a different / faster visitor logic: https://github.com/neo4j/graph-data-science/blob/master/proc/catalog/src/main/java/org/neo4j/gds/catalog/GraphMemoryUsageProc.java#L98-L149
@s1ck, if you want to release it this week, please finish this up :) Otherwise, the release would slip until next week.
-------------
PR: https://git.openjdk.java.net/jol/pull/15
More information about the jol-dev
mailing list