RFR: CODETOOLS-7903262: JOL: GraphStatsWalker counts array elements incorrectly
Vladimir Plizga
duke at openjdk.org
Sat Aug 27 18:26:07 UTC 2022
On Thu, 25 Aug 2022 07:00:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> #### Observed behavior
>> Current `GraphStatsWalker` implementation does not count size and quantity of objects directly contained in arrays.
>>
>> #### Desired behavior
>> The `totalSize()` and `totalCount()` methods of a `GraphStats` instance should return the same values as the ones of `GraphLayout` instance built for the same object.
>>
>> #### Additional info
>> There is a [simple unit test](https://gist.github.com/Toparvion/adec9052ad23e85e54d72b5bfb5a1aa3) that can be used to reproduce current behavior without checking out the fix branch.
>
> Please also go to https://github.com/Toparvion/jol/actions -- and push the button that allows testing workflows to run.
@shipilev , thanks for suggestions!
I've enabled the workflows (all have run successfully) and signed the OCA, now the document is under review. Should I wait for it to finish or can post the `/signed` comment right now?
-------------
PR: https://git.openjdk.org/jol/pull/33
More information about the jol-dev
mailing list