RFR: some code clean.
Steafan Chou
duke at openjdk.java.net
Thu Jun 9 16:57:01 UTC 2022
On Tue, 7 Jun 2022 06:16:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> > > can anyone handle this, thanks
> >
> >
> > It's been two weeks and my OCA was processed,can anyone handle this yet?
>
> It is not processed yet: bots still have `oca`, `oca-verify` tags on the PR.
>
> > Making a person wait for a long time is a manifestation of disrespect to people.
>
> Let's see. Does this PR fixes a bug? Does not look like it. Does it improve performance considerably? Does not look like it. Does it improve readability by a lot? Does not look like it. Cleanups like these are by definition low-priority in most OSS projects, and they are processed when maintainers have time and goodwill to do so. Talking about disrespect does not contribute to goodwill, and therefore shrinks the chance a maintainer would spend time with the contribution. I understand it can be frustrating on a personal level, but I think having patience is paramount in OSS work.
>
> So, just wait for OCA to complete processing, and then we shall look at the code changes.
But I have received an email from you 6 days ago, the email has clearly stated that my OCA has been processed, but why does the robot still have such a label?
-------------
PR: https://git.openjdk.org/jol/pull/26
More information about the jol-dev
mailing list