RFR: 7903214: JOL: Complete some TODOs in VMOptions
Aleksey Shipilev
shade at openjdk.org
Wed Jun 22 09:19:15 UTC 2022
On Mon, 20 Jun 2022 08:43:15 GMT, Steafan Chou <duke at openjdk.org> wrote:
> I'm sorry about the last commit, I forgot to update my branch.
> I have updated the branch synchronously, please check the PR,thanks a lot.
Ah, now I remember why these are not printed. On 32-bit VMs, where the options are not available, it would print unnecessary noise:
# WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist
# WARNING: Unable to get compressed class pointersjava.lang.IllegalArgumentException: VM option "UseCompressedClassPointers" does not exist
# WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist
# WARNING: the compressed oops is unavailable
# Running 32-bit HotSpot VM.
# Objects are 8 bytes aligned.
# ref, bool, byte, char, shrt, int, flt, lng, dbl
# Field sizes: 4, 1, 1, 2, 2, 4, 4, 8, 8
# Array element sizes: 4, 1, 1, 2, 2, 4, 4, 8, 8
# Array base offsets: 12, 12, 12, 12, 12, 12, 12, 16, 16
...
These warnings cannot be reasonably fixed by users, so there is no point in printing them.
I suggest we just drop the `// TODO:` lines in this patch, and move on.
-------------
Changes requested by shade (Committer).
PR: https://git.openjdk.org/jol/pull/29
More information about the jol-dev
mailing list