From duke at openjdk.java.net  Tue May  3 08:51:42 2022
From: duke at openjdk.java.net (Ivan Ponomarev)
Date: Tue, 3 May 2022 08:51:42 GMT
Subject: RFR: make FieldLayout#data() public
In-Reply-To: <x9SW-1h4n52VARb4HT1KbgdJshfaDFR0ceVncLMSXe0=.9bb43b7f-d377-4423-97a2-643949013bdd@github.com>
References: <x9SW-1h4n52VARb4HT1KbgdJshfaDFR0ceVncLMSXe0=.9bb43b7f-d377-4423-97a2-643949013bdd@github.com>
Message-ID: <zV6IJb7cE6NEB1PdbmUkAqQs0-LdoxBHmXj1GVj6q-k=.2aa95e95-d920-452b-8dc0-8713dd521122@github.com>

On Tue, 9 Nov 2021 17:25:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> Can we have this property public? This is needed for https://github.com/atp-mipt/ljv visualizer: we can use JOL to get object fields in consistent order, but then we also need `FieldData` itself in order to get fields' values

superceded by https://github.com/openjdk/jol/pull/24

-------------

PR: https://git.openjdk.java.net/jol/pull/19

From duke at openjdk.java.net  Tue May  3 08:51:43 2022
From: duke at openjdk.java.net (Ivan Ponomarev)
Date: Tue, 3 May 2022 08:51:43 GMT
Subject: Withdrawn: make FieldLayout#data() public
In-Reply-To: <x9SW-1h4n52VARb4HT1KbgdJshfaDFR0ceVncLMSXe0=.9bb43b7f-d377-4423-97a2-643949013bdd@github.com>
References: <x9SW-1h4n52VARb4HT1KbgdJshfaDFR0ceVncLMSXe0=.9bb43b7f-d377-4423-97a2-643949013bdd@github.com>
Message-ID: <8gXq8NuQkG1BsdAE7W0iQY2_gGVK1cVeOu9uHI49e-0=.5f454411-d91b-464a-9622-2732a5be2545@github.com>

On Tue, 9 Nov 2021 17:25:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> Can we have this property public? This is needed for https://github.com/atp-mipt/ljv visualizer: we can use JOL to get object fields in consistent order, but then we also need `FieldData` itself in order to get fields' values

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jol/pull/19

From duke at openjdk.java.net  Wed May  4 19:57:14 2022
From: duke at openjdk.java.net (Ivan Ponomarev)
Date: Wed, 4 May 2022 19:57:14 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
Message-ID: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>

This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.

See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

-------------

Commit messages:
 - code cleanup
 - Move ljv inside jol (#2)
 - Merge remote-tracking branch 'upstream/master'
 - add ljv build
 - update dependencies and include ljv module
 - Merge remote-tracking branch 'ljv/master'
 - move ljv to subfolder
 - Bump maven-javadoc-plugin from 3.3.0 to 3.3.1 (#62)
 - Bump asciidoctorj-diagram from 2.1.2 to 2.2.1 (#60)
 - Bump junit-jupiter from 5.8.1 to 5.8.2 (#73)
 - ... and 83 more: https://git.openjdk.java.net/jol/compare/1b6d9fba...62672627

Changes: https://git.openjdk.java.net/jol/pull/24/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jol&pr=24&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903176
  Stats: 4039 lines in 62 files changed: 4032 ins; 4 del; 3 mod
  Patch: https://git.openjdk.java.net/jol/pull/24.diff
  Fetch: git fetch https://git.openjdk.java.net/jol pull/24/head:pull/24

PR: https://git.openjdk.java.net/jol/pull/24

From shade at openjdk.java.net  Wed May  4 19:57:16 2022
From: shade at openjdk.java.net (Aleksey Shipilev)
Date: Wed, 4 May 2022 19:57:16 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <9xlrNd1y7irAwO8F4NMjwUgyCeQWs3Ekwn11aMYm-bg=.bc0bc6dc-309c-4f58-b21e-8909e68bf444@github.com>

On Tue, 3 May 2022 08:47:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Thanks for contribution!

Before continuing with code review, there are some high-level things involved in this. I see there are multiple contributors for the incoming changesets. I believe all of them should have signed OCA on file, or their changesets should not be present in this PR (I see some were adding "slides" that are not present in this PR). Right, @robilad? 

You can use `/contributor add @<github-id>` to mark them as contributors, I'd expect OpenJDK bots would then block the PR until OCAs are present.

-------------

PR: https://git.openjdk.java.net/jol/pull/24

From duke at openjdk.java.net  Wed May  4 19:57:18 2022
From: duke at openjdk.java.net (Ivan Ponomarev)
Date: Wed, 4 May 2022 19:57:18 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <9xlrNd1y7irAwO8F4NMjwUgyCeQWs3Ekwn11aMYm-bg=.bc0bc6dc-309c-4f58-b21e-8909e68bf444@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <9xlrNd1y7irAwO8F4NMjwUgyCeQWs3Ekwn11aMYm-bg=.bc0bc6dc-309c-4f58-b21e-8909e68bf444@github.com>
Message-ID: <BuCAS8QSXe_ap1An5yDJtbStI9au2wiJ4hNiPHu4aEA=.c0be5b75-1663-43cb-9759-ed001789fd7c@github.com>

On Tue, 3 May 2022 09:13:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I believe all of them should have signed OCA

I will check with everyone personally, and as soon as they confirm they signed OCA, I will add them using `/contributor add`

-------------

PR: https://git.openjdk.java.net/jol/pull/24

From erikj at openjdk.java.net  Wed May  4 19:57:20 2022
From: erikj at openjdk.java.net (Erik Joelsson)
Date: Wed, 4 May 2022 19:57:20 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <t44kCjWWwbpG8m_O9HN2a5zsBk_SsKdVN4UHWsduhiA=.ecc7b2bd-51f3-4f4d-842f-45277ee769f4@github.com>

On Tue, 3 May 2022 08:47:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

The Skara bot is currently experiencing trouble processing this PR. CheckRun is throwing an exception. I'm still investigating. The reason seems to be that this is merging in commits that do not have a merge-base with the master branch. It's possible that you won't be able to integrate before I resolve this. Filed https://bugs.openjdk.java.net/browse/SKARA-1424.

-------------

PR: https://git.openjdk.java.net/jol/pull/24

From robilad at openjdk.java.net  Wed May  4 19:57:21 2022
From: robilad at openjdk.java.net (Dalibor Topic)
Date: Wed, 4 May 2022 19:57:21 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <5JZVgZ6iTNpnkI6siPrNUCA6dRId-JjIsfjSwrjiHM4=.69fcd27c-4bcb-4eda-adf7-d45de975d126@github.com>

On Tue, 3 May 2022 08:47:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Aleksey is correct that we need to have an OCA on file for each contributor involved.

-------------

PR: https://git.openjdk.java.net/jol/pull/24

From robilad at openjdk.java.net  Thu May  5 23:48:59 2022
From: robilad at openjdk.java.net (Dalibor Topic)
Date: Thu, 5 May 2022 23:48:59 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <40q0BA39UxI_oJ-evopmuoeP2NunP5TP0JVoP86BxWk=.e32a61bd-879d-4bdd-922d-f1beb375cc39@github.com>

On Tue, 3 May 2022 08:47:17 GMT, Ivan Ponomarev <duke at openjdk.java.net> wrote:

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

As another note, it's not sufficient that an OCA has been signed - it has to successfully be processed on our end, which means it shows up on the signatory listing at oca.opensource.Oracle.com.

-------------

PR: https://git.openjdk.java.net/jol/pull/24