RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]

Aleksey Shipilev shade at openjdk.org
Wed Oct 12 13:04:26 UTC 2022


On Sun, 2 Oct 2022 09:44:12 GMT, John Hamer <duke at openjdk.org> wrote:

>> Idea: can John send the reply to https://mail.openjdk.org/pipermail/jol-dev/2022-September/000464.html then?
>
> I'm happy for the GPL text to be removed. The original code is mine, and I am more than happy to have it included in JOL.

Thank you for chiming in, @JohnHamer-Glasgow! (And welcome to JOL!)

I have a suggestion to remove `Author` and `Created` lines from this file, because it does not match the style of other files in the project, and this might be lost by accident, or otherwise raise questions during the review. For example, if we ever divide/delete `LJV.java`, it would be hard to judge where these comments should go.

There is a tangential rule that we try to avoid `@author` javadoc tags, to be consistent with OpenJDK code style. I think John is now recorded as developer in project properties, which is cleaner, better, and gives John the credit for the entire project, not just single file.

-------------

PR: https://git.openjdk.org/jol/pull/24


More information about the jol-dev mailing list