RFR: CODETOOLS-7903176: Move LJV inside JOL
Aleksey Shipilev
shade at openjdk.org
Tue Oct 18 17:23:17 UTC 2022
On Mon, 26 Sep 2022 15:21:53 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:
>>> It seems that we managed to sort out everything with the OCA
>>
>> Nice, I checked the OCA signatories list, and all PR contributors seems to be accounted for.
>>
>> In this PR, I see the commits from two more people (@[OrangeFlag](https://github.com/atp-mipt/jol/commits?author=OrangeFlag) and @[gogagum](https://github.com/atp-mipt/jol/commits?author=gogagum) -- and who are not in PR contributor list. I see they have OCA on file, so that is not a problem for this PR, but maybe you want to credit them as well?
>>
>>> The code is linted and IMO ready for review
>>
>> I'll start reviewing it then! Thanks.
>
> @shipilev sorry for the inattention, hope everything is addressed now
One more thing, @inponomarev -- please merge from current JOL master to get test pipeline fixes. GitHub actions need to test this PR, maybe you need to go to your fork "Actions" tab and press the "Approve workflow" button there.
-------------
PR: https://git.openjdk.org/jol/pull/24
More information about the jol-dev
mailing list