From outsider.help.end at gmail.com  Fri Sep 23 03:57:02 2022
From: outsider.help.end at gmail.com (Jessica Park)
Date: Fri, 23 Sep 2022 12:57:02 +0900
Subject: Can I contain jol-core-0.2.jar in commercial SW?
Message-ID: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>

I cannot find this information.

1.
Is it possible to redistribute tools.jar in openJDK?
Can I contain jol-core-0.2.jar  in commercial SW?
I do not modify tools.jar

2.
How about other libraries in OpenJDK when they are not modified?

Please let me know as soon as possible.
It is so difficult.

Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jol-dev/attachments/20220923/aed8bfa7/attachment.htm>

From shade at redhat.com  Fri Sep 23 09:20:35 2022
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 23 Sep 2022 11:20:35 +0200
Subject: Can I contain jol-core-0.2.jar in commercial SW?
In-Reply-To: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>
References: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>
Message-ID: <31dd83db-3051-4453-d609-0253b9e069ca@redhat.com>

On 9/23/22 05:57, Jessica Park wrote:
> I cannot find this information.
> 
> 1.
> Is it possible to redistribute tools.jar in openJDK?
> Can I contain jol-core-0.2.jar? in commercial SW?
> I do not modify tools.jar

There is a LICENSE file, show it to your lawyer :)
   https://github.com/openjdk/jol/blob/master/LICENSE

> 2.
> How about?other libraries in OpenJDK when?they?are not modified?

Same answer as above.

-- 
Thanks,
-Aleksey


From outsider.help.end at gmail.com  Fri Sep 23 13:43:21 2022
From: outsider.help.end at gmail.com (Jessica Park)
Date: Fri, 23 Sep 2022 22:43:21 +0900
Subject: Fwd: Can I contain jol-core-0.2.jar in commercial SW?
In-Reply-To: <CAG=FQ75v7kuQvh3twxNMctBpDz0_m5FLx=+t-Z5mreTooR=WnQ@mail.gmail.com>
References: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>
 <31dd83db-3051-4453-d609-0253b9e069ca@redhat.com>
 <CAG=FQ75v7kuQvh3twxNMctBpDz0_m5FLx=+t-Z5mreTooR=WnQ@mail.gmail.com>
Message-ID: <CAG=FQ772RpBUg6JMyxyJX3XW+o+iArh-AE0tWHBv_bX10zmYqw@mail.gmail.com>

---------- Forwarded message ---------
????: Jessica Park <outsider.help.end at gmail.com>
Date: 2022? 9? 23? (?) ?? 10:42
Subject: Re: Can I contain jol-core-0.2.jar in commercial SW?
To: Aleksey Shipilev <shade at redhat.com>


I know it's license is GPL with classpath exception. But I read a document
that some libraries in Oracle JDK can not be redistributed.
If true, I have a question that jol in openJDK is also one of these kinds
of libraries.

Thank you.


2022? 9? 23? (?) ?? 6:20, Aleksey Shipilev <shade at redhat.com>?? ??:

> On 9/23/22 05:57, Jessica Park wrote:
> > I cannot find this information.
> >
> > 1.
> > Is it possible to redistribute tools.jar in openJDK?
> > Can I contain jol-core-0.2.jar  in commercial SW?
> > I do not modify tools.jar
>
> There is a LICENSE file, show it to your lawyer :)
>    https://github.com/openjdk/jol/blob/master/LICENSE
>
> > 2.
> > How about other libraries in OpenJDK when they are not modified?
>
> Same answer as above.
>
> --
> Thanks,
> -Aleksey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jol-dev/attachments/20220923/1d7fd3c5/attachment.htm>

From outsider.help.end at gmail.com  Fri Sep 23 13:44:34 2022
From: outsider.help.end at gmail.com (Jessica Park)
Date: Fri, 23 Sep 2022 22:44:34 +0900
Subject: Can I contain jol-core-0.2.jar in commercial SW?
In-Reply-To: <31dd83db-3051-4453-d609-0253b9e069ca@redhat.com>
References: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>
 <31dd83db-3051-4453-d609-0253b9e069ca@redhat.com>
Message-ID: <CAG=FQ75oE5czc62Q_tSL5SJuEh9K0VFpADtcU3Ev_qJtLQMwkA@mail.gmail.com>

I know it's license is GPL with classpath exception. But I read a document
that some libraries in Oracle JDK can not be redistributed.
If true, I have a question that jol in openJDK is also one of these kinds
of libraries.

Thank you.

2022? 9? 23? (?) ?? 6:20, Aleksey Shipilev <shade at redhat.com>?? ??:

> On 9/23/22 05:57, Jessica Park wrote:
> > I cannot find this information.
> >
> > 1.
> > Is it possible to redistribute tools.jar in openJDK?
> > Can I contain jol-core-0.2.jar  in commercial SW?
> > I do not modify tools.jar
>
> There is a LICENSE file, show it to your lawyer :)
>    https://github.com/openjdk/jol/blob/master/LICENSE
>
> > 2.
> > How about other libraries in OpenJDK when they are not modified?
>
> Same answer as above.
>
> --
> Thanks,
> -Aleksey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jol-dev/attachments/20220923/cb7a841e/attachment-0001.htm>

From shade at redhat.com  Fri Sep 23 16:14:49 2022
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 23 Sep 2022 18:14:49 +0200
Subject: Can I contain jol-core-0.2.jar in commercial SW?
In-Reply-To: <CAG=FQ75oE5czc62Q_tSL5SJuEh9K0VFpADtcU3Ev_qJtLQMwkA@mail.gmail.com>
References: <CAG=FQ77cz_9=hOp7QP3wdPyRZg5wEcugep+Muh=4ixZDr7O2GA@mail.gmail.com>
 <31dd83db-3051-4453-d609-0253b9e069ca@redhat.com>
 <CAG=FQ75oE5czc62Q_tSL5SJuEh9K0VFpADtcU3Ev_qJtLQMwkA@mail.gmail.com>
Message-ID: <7deef4a2-a727-e0b3-cc7a-b7d846e2144c@redhat.com>

On 9/23/22 15:44, Jessica Park wrote:
> I know it's license is GPL with classpath exception. But I read a document that some libraries in 
> Oracle JDK can not be redistributed.

This is not the Oracle JDK mailing list.

> If true, I have a question that jol in openJDK is also one of these kinds of libraries.

Same answer: show the license file to your lawyer :)

-- 
Thanks,
-Aleksey


From duke at openjdk.org  Sun Sep 25 07:08:38 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Sun, 25 Sep 2022 07:08:38 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <LmLfoc9vpJOTLKuEt0iJF6fJ-3tZC78RIDzfCHxY5Wo=.032b71c8-f3b3-4781-8e06-62ca84da3058@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <LmLfoc9vpJOTLKuEt0iJF6fJ-3tZC78RIDzfCHxY5Wo=.032b71c8-f3b3-4781-8e06-62ca84da3058@github.com>
Message-ID: <l3Ngfb2-_tpumCUpM8vVUMES0IIisGYH-8bg336bRhY=.6bd7f980-6d49-4902-aad7-12039580a4e8@github.com>

On Mon, 22 Aug 2022 08:45:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> jol-core/src/test/java/org/openjdk/jol/ljv/HashCodeCollision.java line 9:
>> 
>>> 7:  * @author Ilya Selivanov
>>> 8:  */
>>> 9: public class HashCodeCollision {
>> 
>> This file has a mix of identifier styles: `alphabet_list`, for example, should be `alphabetList`.
>
> There is also seem to be an easier way to generated hashcode collisions on Strings: just take any string, and add `Aa` and `BB` to it to produce different strings with the same hashcode:
> 
> 
> jshell> "seedAa".hashCode()
> $9 ==> -906232207
> 
> jshell> "seedBB".hashCode()
> $10 ==> -906232207
> 
> 
> Repeat if you need more strings like these.

reimplemented the class from scratch

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Sun Sep 25 07:31:41 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Sun, 25 Sep 2022 07:31:41 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
Message-ID: <0wg6sT8sATEdbhlR-5HxKBw8dGgpIlQcTHtXQdIzLns=.9922c016-9a64-461c-bb10-43e303ffadba@github.com>

On Mon, 22 Aug 2022 08:19:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright notice, lint
>
> jol-core/src/main/java/org/openjdk/jol/ljv/GraphvizVisualization.java line 55:
> 
>> 53:     public void diagramBegin() {
>> 54:         out.setLength(0); // Clearing String Builder before starting new DOT
>> 55:         out.append("digraph Java {\n")
> 
> Here and later, `\n` should actually be `System.lineSeparator()` to provide platform-independent line breaks. This would probably make golden test output platform-dependent, though? We can rehash this after the integration.

No it won't be a problem for Approvals tests, as far as I understand it can treat the line ending discrepancies correctly.
However I can notice `\n` in `OptionFormatter` and `ClassLayout`, so maybe postpone the line ending problem?

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Sun Sep 25 07:44:50 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Sun, 25 Sep 2022 07:44:50 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v3]
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <KHNFFwIgxSYmsAFzu1IeE_VGJ56NlnPpOGIeAoaUCiM=.de8cf782-4f81-408c-a17c-7c6d37033f4e@github.com>

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:

  minor changes (#5)
  
  * HashCodeCollision reimplementation
  * JDK headers fix
  *  LJV Github actions removed
  * other code review fixes
  
  Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>

-------------

Changes:
  - all: https://git.openjdk.org/jol/pull/24/files
  - new: https://git.openjdk.org/jol/pull/24/files/5001f98d..3a9feff0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jol&pr=24&range=02
 - incr: https://webrevs.openjdk.org/?repo=jol&pr=24&range=01-02

  Stats: 502 lines in 40 files changed: 371 ins; 68 del; 63 mod
  Patch: https://git.openjdk.org/jol/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/jol pull/24/head:pull/24

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Sun Sep 25 07:44:51 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Sun, 25 Sep 2022 07:44:51 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <lEXUsjL0xhOFhz5_wJbfQ9pG-29h9r_NnQiTY1Z0vfA=.0f3c34d5-2168-4f58-9041-35c4254ac12e@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <9xlrNd1y7irAwO8F4NMjwUgyCeQWs3Ekwn11aMYm-bg=.bc0bc6dc-309c-4f58-b21e-8909e68bf444@github.com>
 <aI27vwqpLkk2yqYP9eYzqeOkhTDqJ4OAmwUOTUZak4w=.a1743934-48da-4770-85ce-7e487aa4f0d6@github.com>
 <lEXUsjL0xhOFhz5_wJbfQ9pG-29h9r_NnQiTY1Z0vfA=.0f3c34d5-2168-4f58-9041-35c4254ac12e@github.com>
Message-ID: <R0GecsvbuZ6gIERxXU5N9-vIDquU9uh1jKpmWE99TGg=.f66bb738-f639-46db-8a7d-a6a70f16b097@github.com>

On Mon, 22 Aug 2022 07:53:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi @shipilev ! 
>> 
>> It seems that we managed to sort out everything with the OCA 
>> 
>> The code is linted and IMO ready for review
>
>> It seems that we managed to sort out everything with the OCA
> 
> Nice, I checked the OCA signatories list, and all PR contributors seems to be accounted for.
> 
> In this PR, I see the commits from two more people (@[OrangeFlag](https://github.com/atp-mipt/jol/commits?author=OrangeFlag) and @[gogagum](https://github.com/atp-mipt/jol/commits?author=gogagum) -- and who are not in PR contributor list. I see they have OCA on file, so that is not a problem for this PR, but maybe you want to credit them as well?
> 
>> The code is linted and IMO ready for review
> 
> I'll start reviewing it then! Thanks.

Hi @shipilev review comments are addressed, please check when you have time. Thank you!

-------------

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Mon Sep 26 08:57:04 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 26 Sep 2022 08:57:04 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <0wg6sT8sATEdbhlR-5HxKBw8dGgpIlQcTHtXQdIzLns=.9922c016-9a64-461c-bb10-43e303ffadba@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <0wg6sT8sATEdbhlR-5HxKBw8dGgpIlQcTHtXQdIzLns=.9922c016-9a64-461c-bb10-43e303ffadba@github.com>
Message-ID: <Dfw-TgmpZVR2f5wIGfasYsyG89e6IZKHDFxvI45UvU0=.64626388-075d-4ae9-8b35-dd4c22a0c0e6@github.com>

On Sun, 25 Sep 2022 07:27:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> jol-core/src/main/java/org/openjdk/jol/ljv/GraphvizVisualization.java line 55:
>> 
>>> 53:     public void diagramBegin() {
>>> 54:         out.setLength(0); // Clearing String Builder before starting new DOT
>>> 55:         out.append("digraph Java {\n")
>> 
>> Here and later, `\n` should actually be `System.lineSeparator()` to provide platform-independent line breaks. This would probably make golden test output platform-dependent, though? We can rehash this after the integration.
>
> No it won't be a problem for Approvals tests, as far as I understand it can treat the line ending discrepancies correctly.
> However I can notice `\n` in `OptionFormatter` and `ClassLayout`, so maybe postpone the line ending problem?

Okay, sounds fine.

-------------

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Mon Sep 26 10:16:39 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 26 Sep 2022 10:16:39 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v3]
In-Reply-To: <KHNFFwIgxSYmsAFzu1IeE_VGJ56NlnPpOGIeAoaUCiM=.de8cf782-4f81-408c-a17c-7c6d37033f4e@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <KHNFFwIgxSYmsAFzu1IeE_VGJ56NlnPpOGIeAoaUCiM=.de8cf782-4f81-408c-a17c-7c6d37033f4e@github.com>
Message-ID: <wl4qsW_GxS8vHagL7PRSuM1OnhHbIzi6RU_xvggczVA=.8b1da0e3-ebb3-4e0f-808e-3be616c34df2@github.com>

On Sun, 25 Sep 2022 07:44:50 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor changes (#5)
>   
>   * HashCodeCollision reimplementation
>   * JDK headers fix
>   *  LJV Github actions removed
>   * other code review fixes
>   
>   Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>

There is a bunch of comments that was not addressed since last review, unfortunately.

-------------

Changes requested by shade (Committer).

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Mon Sep 26 10:16:40 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 26 Sep 2022 10:16:40 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
Message-ID: <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>

On Mon, 22 Aug 2022 08:26:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright notice, lint
>
> jol-core/src/main/java/org/openjdk/jol/ljv/Introspection.java line 32:
> 
>> 30: import java.util.List;
>> 31: 
>> 32: public interface Introspection {
> 
> Now that LJV is in JOL, can we "just" use its internals to introspect stuff, without doing LJV-specific walk? What's the plan here?

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/IntrospectionWithReflectionAPI.java line 54:
> 
>> 52:         }
>> 53: 
>> 54:         // ?? ??????????????, ??????? ??????? ?? ???? ?????? ??? ??? ??? ???.
> 
> Russian comment :)

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/LJV.java line 44:
> 
>> 42: //-   You should have received a copy of the GNU General Public License along
>> 43: //-   with this program; if not, write to the Free Software Foundation, Inc.,
>> 44: //-   59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
> 
> Wait a second, what's this? Does this file borrow some external code?

This comment is still not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/Quote.java line 53:
> 
>> 51:                 sb.append(c);
>> 52:             else
>> 53:                 sb.append("\\\\0u").append(Integer.toHexString(c));
> 
> Braces, please.

This comment was not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/pom.xml line 1:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
> 
> Weird to see this `pom.xml` in sources. Do you mean to merge parts of it into `jol-core/pom.xml`?

This comment was not addressed.

> jol-core/src/main/java/org/openjdk/jol/ljv/provider/ArrayElementAttributeProvider.java line 27:
> 
>> 25: package org.openjdk.jol.ljv.provider;
>> 26: 
>> 27: //@FunctionalInterface
> 
> Leftover comment.

This comment was not addressed.

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Mon Sep 26 13:57:35 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Mon, 26 Sep 2022 13:57:35 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
Message-ID: <jmOdCcSaJG5wWfCw9c8n2T5CEnorVOUI_FE7z78I4lg=.83c55648-5162-4fa0-9587-dcc9b69c893e@github.com>

On Mon, 26 Sep 2022 10:07:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> jol-core/src/main/java/org/openjdk/jol/ljv/Introspection.java line 32:
>> 
>>> 30: import java.util.List;
>>> 31: 
>>> 32: public interface Introspection {
>> 
>> Now that LJV is in JOL, can we "just" use its internals to introspect stuff, without doing LJV-specific walk? What's the plan here?
>
> This comment is still not addressed.

Well, the situation here is following: we tried to use JOL internals to walk through the graph, but it turned out to be impossible without substantial changes in JOL. So we decided to merge LJV as an addition to JOL and then refactor.

The plan is to bring LJV as is, and then substitute its graph walking logic with JOL's (maybe in Spring 2023 when I have fresh students).

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Mon Sep 26 15:04:46 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Mon, 26 Sep 2022 15:04:46 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
Message-ID: <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>

On Mon, 26 Sep 2022 10:09:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> jol-core/src/main/java/org/openjdk/jol/ljv/LJV.java line 44:
>> 
>>> 42: //-   You should have received a copy of the GNU General Public License along
>>> 43: //-   with this program; if not, write to the Free Software Foundation, Inc.,
>>> 44: //-   59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
>> 
>> Wait a second, what's this? Does this file borrow some external code?
>
> This comment is still not addressed.

It's not external code. 

The first version of LJV was created by John Hamer in 2003 (before Maven Central and GitHub) and released under GNU GPL. This comment is from the 2003 version of LJV (the code was heavily modified since then) .  I'm exchanging emails with John, he approves what we're doing. John signed the OCA and was added to contributors of this PR.

Is it OK if we remove GPL header (we have GPL header from Oracle) and leave `//-Author` and `//-Created` for historical reasons?

>> jol-core/src/main/java/org/openjdk/jol/ljv/pom.xml line 1:
>> 
>>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 
>> Weird to see this `pom.xml` in sources. Do you mean to merge parts of it into `jol-core/pom.xml`?
>
> This comment was not addressed.

Oops it's here by mistake, obviously

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Mon Sep 26 15:25:10 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Mon, 26 Sep 2022 15:25:10 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v4]
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <fwVL-8oW1zm_mTbzy291jZZsgkJd1s_Flp-Bm59lWXs=.78ddcf86-81de-4457-9da1-67cb7b9906c5@github.com>

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Ivan Ponomarev has updated the pull request incrementally with one additional commit since the last revision:

  leftover comments + braces (#6)
  
  * leftover comments + braces
  
  * remove leftover pom.xml
  
  * remove extra copyright comments
  
  Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>

-------------

Changes:
  - all: https://git.openjdk.org/jol/pull/24/files
  - new: https://git.openjdk.org/jol/pull/24/files/3a9feff0..00a0ac71

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jol&pr=24&range=03
 - incr: https://webrevs.openjdk.org/?repo=jol&pr=24&range=02-03

  Stats: 163 lines in 5 files changed: 3 ins; 154 del; 6 mod
  Patch: https://git.openjdk.org/jol/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/jol pull/24/head:pull/24

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Mon Sep 26 15:25:11 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Mon, 26 Sep 2022 15:25:11 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <lEXUsjL0xhOFhz5_wJbfQ9pG-29h9r_NnQiTY1Z0vfA=.0f3c34d5-2168-4f58-9041-35c4254ac12e@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <9xlrNd1y7irAwO8F4NMjwUgyCeQWs3Ekwn11aMYm-bg=.bc0bc6dc-309c-4f58-b21e-8909e68bf444@github.com>
 <aI27vwqpLkk2yqYP9eYzqeOkhTDqJ4OAmwUOTUZak4w=.a1743934-48da-4770-85ce-7e487aa4f0d6@github.com>
 <lEXUsjL0xhOFhz5_wJbfQ9pG-29h9r_NnQiTY1Z0vfA=.0f3c34d5-2168-4f58-9041-35c4254ac12e@github.com>
Message-ID: <L0heUypf--Feg-rPl9b7hZJ0QN0xI_YP28Z5nDiHADA=.864049f1-becb-4c28-8ef3-5d8973058a9b@github.com>

On Mon, 22 Aug 2022 07:53:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi @shipilev ! 
>> 
>> It seems that we managed to sort out everything with the OCA 
>> 
>> The code is linted and IMO ready for review
>
>> It seems that we managed to sort out everything with the OCA
> 
> Nice, I checked the OCA signatories list, and all PR contributors seems to be accounted for.
> 
> In this PR, I see the commits from two more people (@[OrangeFlag](https://github.com/atp-mipt/jol/commits?author=OrangeFlag) and @[gogagum](https://github.com/atp-mipt/jol/commits?author=gogagum) -- and who are not in PR contributor list. I see they have OCA on file, so that is not a problem for this PR, but maybe you want to credit them as well?
> 
>> The code is linted and IMO ready for review
> 
> I'll start reviewing it then! Thanks.

@shipilev sorry for the inattention, hope everything is addressed now

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Mon Sep 26 15:50:13 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Mon, 26 Sep 2022 15:50:13 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v5]
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <A_Vme2S72t85igX1JT390IxKSap8ZQ-THyf8InhDjLU=.42d7238d-d524-482a-a952-ed5d0db02cf5@github.com>

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Ivan Ponomarev has updated the pull request incrementally with two additional commits since the last revision:

 - Merge pull request #7 from atp-mipt/jchekProblems
   
   jcheck Whitespace error fix
 - jcheck Whitespace error fix

-------------

Changes:
  - all: https://git.openjdk.org/jol/pull/24/files
  - new: https://git.openjdk.org/jol/pull/24/files/00a0ac71..4d44d66e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jol&pr=24&range=04
 - incr: https://webrevs.openjdk.org/?repo=jol&pr=24&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jol/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/jol pull/24/head:pull/24

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Tue Sep 27 11:25:39 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 27 Sep 2022 11:25:39 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <jmOdCcSaJG5wWfCw9c8n2T5CEnorVOUI_FE7z78I4lg=.83c55648-5162-4fa0-9587-dcc9b69c893e@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
 <jmOdCcSaJG5wWfCw9c8n2T5CEnorVOUI_FE7z78I4lg=.83c55648-5162-4fa0-9587-dcc9b69c893e@github.com>
Message-ID: <9vnPdXxEdBG2D4GSL35D4995YCAxgFwdsEllheZafIA=.ec91c8d8-953f-4fc0-81d6-61f4bff712c0@github.com>

On Mon, 26 Sep 2022 13:53:49 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This comment is still not addressed.
>
> Well, the situation here is following: we tried to use JOL internals to walk through the graph, but it turned out to be impossible without substantial changes in JOL. So we decided to merge LJV as an addition to JOL and then refactor.
> 
> The plan is to bring LJV as is, and then substitute its graph walking logic with JOL's (maybe in Spring 2023 when I have fresh students).

All right. This would be fine if we have enough test to cover this refactoring. I might get a stab at it after the integration.

-------------

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Tue Sep 27 11:32:42 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 27 Sep 2022 11:32:42 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
 <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>
Message-ID: <NFrET5GIU-5L4We-5nLEe0NCL0u0JnlU-Hp97j0tJGo=.901f3eb7-fe78-4b0b-b507-12527d44db3e@github.com>

On Mon, 26 Sep 2022 14:51:52 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This comment is still not addressed.
>
> It's not external code. 
> 
> The first version of LJV was created by John Hamer in 2003 (before Maven Central and GitHub) and released under GNU GPL. This comment is from the 2003 version of LJV (the code was heavily modified since then) .  I'm exchanging emails with John, he approves what we're doing. John signed the OCA and was added to contributors of this PR.
> 
> Is it OK if we remove GPL header (we have GPL header from Oracle) and leave `//-Author` and `//-Created` for historical reasons?

I cannot advise on what you should do here. I see the current PR already does what you suggest, which I presume what John approves? Anyhow, I think we need to ask @robilad for guidance here.

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Wed Sep 28 16:45:36 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Wed, 28 Sep 2022 16:45:36 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <NFrET5GIU-5L4We-5nLEe0NCL0u0JnlU-Hp97j0tJGo=.901f3eb7-fe78-4b0b-b507-12527d44db3e@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
 <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>
 <NFrET5GIU-5L4We-5nLEe0NCL0u0JnlU-Hp97j0tJGo=.901f3eb7-fe78-4b0b-b507-12527d44db3e@github.com>
Message-ID: <SeyAW8-Ju-IWOq2Aie7sgJX-fDGjpbiCdn1jtCXOqdY=.29d60cc0-8258-4998-b2ed-acd5dbfb3a59@github.com>

On Tue, 27 Sep 2022 11:29:18 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> It's not external code. 
>> 
>> The first version of LJV was created by John Hamer in 2003 (before Maven Central and GitHub) and released under GNU GPL. This comment is from the 2003 version of LJV (the code was heavily modified since then) .  I'm exchanging emails with John, he approves what we're doing. John signed the OCA and was added to contributors of this PR.
>> 
>> Is it OK if we remove GPL header (we have GPL header from Oracle) and leave `//-Author` and `//-Created` for historical reasons?
>
> I cannot advise on what you should do here. I see the current PR already does what you suggest, which I presume what John approves? Anyhow, I think we need to ask @robilad for guidance here.

Yes, John approves indeed. He's not at GitHub, but he's available via email and he approves the whole idea and he's glad that his idea revived.

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Thu Sep 29 10:44:41 2022
From: duke at openjdk.org (Ivan Ponomarev)
Date: Thu, 29 Sep 2022 10:44:41 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <SeyAW8-Ju-IWOq2Aie7sgJX-fDGjpbiCdn1jtCXOqdY=.29d60cc0-8258-4998-b2ed-acd5dbfb3a59@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
 <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>
 <NFrET5GIU-5L4We-5nLEe0NCL0u0JnlU-Hp97j0tJGo=.901f3eb7-fe78-4b0b-b507-12527d44db3e@github.com>
 <SeyAW8-Ju-IWOq2Aie7sgJX-fDGjpbiCdn1jtCXOqdY=.29d60cc0-8258-4998-b2ed-acd5dbfb3a59@github.com>
Message-ID: <r2DblxcGzwF2WOlz2r4tfABAoNHtOToD7J5_eL3-kH0=.3af62a2e-bcac-4a8b-879e-609ed6b94ac5@github.com>

On Wed, 28 Sep 2022 16:41:59 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> I cannot advise on what you should do here. I see the current PR already does what you suggest, which I presume what John approves? Anyhow, I think we need to ask @robilad for guidance here.
>
> Yes, John approves indeed. He's not at GitHub, but he's available via email and he approves the whole idea and he's glad that his idea revived.

Yes, John indeed approves the whole idea, and he signed OCA on his own.
He's not on GitHub, but he's available via email.

-------------

PR: https://git.openjdk.org/jol/pull/24

From shade at openjdk.org  Thu Sep 29 10:48:33 2022
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 29 Sep 2022 10:48:33 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]
In-Reply-To: <r2DblxcGzwF2WOlz2r4tfABAoNHtOToD7J5_eL3-kH0=.3af62a2e-bcac-4a8b-879e-609ed6b94ac5@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <nwabVvJkbP8M6YokuRH61bitYWfWGAPSa5p7apCsKxk=.1b30264f-0e9c-4e66-a3ef-cfd9711146d7@github.com>
 <LPlJd-l8YM11dvkyK0oCUpTOFZJUeZXh1bpGazS6jkU=.e9c8aa04-8fba-4a2e-bb68-2a6093398b78@github.com>
 <Z2ZvXH9T5-vY2TL3g5TStCLU0MDbjNxHCvJk5nfyoGY=.e6e225e7-7732-41bd-8139-e45e4b78924d@github.com>
 <_0fDDdBGH0x5UUI9fnk_YEGHyZkV0VsiixwHZE18s8A=.dc26c851-0b81-4547-a27c-d15cc7ac7551@github.com>
 <NFrET5GIU-5L4We-5nLEe0NCL0u0JnlU-Hp97j0tJGo=.901f3eb7-fe78-4b0b-b507-12527d44db3e@github.com>
 <SeyAW8-Ju-IWOq2Aie7sgJX-fDGjpbiCdn1jtCXOqdY=.29d60cc0-8258-4998-b2ed-acd5dbfb3a59@github.com>
 <r2DblxcGzwF2WOlz2r4tfABAoNHtOToD7J5_eL3-kH0=.3af62a2e-bcac-4a8b-879e-609ed6b94ac5@github.com>
Message-ID: <7y8viv04-M1IVLe7w4ea1RzRaAaBJ8i-kyXICzRbotw=.5193b836-860b-4087-a2c2-8d101e25c4de@github.com>

On Thu, 29 Sep 2022 06:51:28 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> Yes, John approves indeed. He's not at GitHub, but he's available via email and he approves the whole idea and he's glad that his idea revived.
>
> Yes, John indeed approves the whole idea, and he signed OCA on his own.
> He's not on GitHub, but he's available via email.

Idea: can John send the reply to https://mail.openjdk.org/pipermail/jol-dev/2022-September/000464.html then?

-------------

PR: https://git.openjdk.org/jol/pull/24