RFR: CODETOOLS-7903176: Move LJV inside JOL [v2]

[Ivan Ponomarev]

On Mon, 26 Sep 2022 10:09:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> jol-core/src/main/java/org/openjdk/jol/ljv/LJV.java line 44:
>> 
>>> 42: //-   You should have received a copy of the GNU General Public License along
>>> 43: //-   with this program; if not, write to the Free Software Foundation, Inc.,
>>> 44: //-   59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
>> 
>> Wait a second, what's this? Does this file borrow some external code?
>
> This comment is still not addressed.

It's not external code. 

The first version of LJV was created by John Hamer in 2003 (before Maven Central and GitHub) and released under GNU GPL. This comment is from the 2003 version of LJV (the code was heavily modified since then) .  I'm exchanging emails with John, he approves what we're doing. John signed the OCA and was added to contributors of this PR.

Is it OK if we remove GPL header (we have GPL header from Oracle) and leave `//-Author` and `//-Created` for historical reasons?

>> jol-core/src/main/java/org/openjdk/jol/ljv/pom.xml line 1:
>> 
>>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 
>> Weird to see this `pom.xml` in sources. Do you mean to merge parts of it into `jol-core/pom.xml`?
>
> This comment was not addressed.

Oops it's here by mistake, obviously

-------------

PR: https://git.openjdk.org/jol/pull/24