From shade at openjdk.org  Thu Oct  5 11:02:01 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 5 Oct 2023 11:02:01 GMT
Subject: RFR: CODETOOLS-7903569: JOL: Use human-readable class names
 consistently
Message-ID: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>

There are a couple of places, where we print out JVM names for classes. Notably, it happens during "footprint". We need to consistently use the human-readable class names everywhere.

-------------

Commit messages:
 - Fix

Changes: https://git.openjdk.org/jol/pull/51/files
 Webrev: https://webrevs.openjdk.org/?repo=jol&pr=51&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903569
  Stats: 14 lines in 4 files changed: 1 ins; 2 del; 11 mod
  Patch: https://git.openjdk.org/jol/pull/51.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/51/head:pull/51

PR: https://git.openjdk.org/jol/pull/51

From shade at openjdk.org  Thu Oct  5 11:22:54 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 5 Oct 2023 11:22:54 GMT
Subject: RFR: CODETOOLS-7903569: JOL: Use human-readable class names
 consistently [v2]
In-Reply-To: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
References: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
Message-ID: <Qc4CW04moEqwoJHDuUyblVnIPwT8S0tNmsV_uGAopxw=.743256f6-612d-42d7-ab36-ba84b764ef2b@github.com>

> There are a couple of places, where we print out JVM names for classes. Notably, it happens during "footprint". We need to consistently use the human-readable class names everywhere.

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  More conservative fix

-------------

Changes:
  - all: https://git.openjdk.org/jol/pull/51/files
  - new: https://git.openjdk.org/jol/pull/51/files/aa2bdc20..51679dda

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jol&pr=51&range=01
 - incr: https://webrevs.openjdk.org/?repo=jol&pr=51&range=00-01

  Stats: 9 lines in 2 files changed: 4 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jol/pull/51.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/51/head:pull/51

PR: https://git.openjdk.org/jol/pull/51

From shade at openjdk.org  Thu Oct  5 11:41:18 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 5 Oct 2023 11:41:18 GMT
Subject: RFR: CODETOOLS-7903569: JOL: Use human-readable class names
 consistently [v3]
In-Reply-To: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
References: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
Message-ID: <1PcaQg0d3IEY1tUajHf7y6KT0YtFTxI79loiWVYaFFo=.17fcd825-3b15-48f1-b2a0-a5eb7452bffd@github.com>

> There are a couple of places, where we print out JVM names for classes. Notably, it happens during "footprint". We need to consistently use the human-readable class names everywhere.

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Add tests

-------------

Changes:
  - all: https://git.openjdk.org/jol/pull/51/files
  - new: https://git.openjdk.org/jol/pull/51/files/51679dda..008c74fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jol&pr=51&range=02
 - incr: https://webrevs.openjdk.org/?repo=jol&pr=51&range=01-02

  Stats: 112 lines in 2 files changed: 112 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jol/pull/51.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/51/head:pull/51

PR: https://git.openjdk.org/jol/pull/51

From duke at openjdk.org  Thu Oct  5 12:21:36 2023
From: duke at openjdk.org (duke)
Date: Thu, 5 Oct 2023 12:21:36 GMT
Subject: git: openjdk/jol: CODETOOLS-7903569: JOL: Use human-readable class
 names consistently
Message-ID: <b7d1d4ef-d8a7-41c9-ae97-c49fe943a575@openjdk.org>

Changeset: 3c3aec2b
Author:    Aleksey Shipil?v <shade at openjdk.org>
Committer: GitHub <noreply at github.com>
Date:      2023-10-05 14:19:45 +0000
URL:       https://git.openjdk.org/jol/commit/3c3aec2b1aa5cbed7e83ee5bee4b456642dd5d9e

CODETOOLS-7903569: JOL: Use human-readable class names consistently


! jol-core/src/main/java/org/openjdk/jol/info/ClassData.java
! jol-core/src/main/java/org/openjdk/jol/info/FieldData.java
! jol-core/src/main/java/org/openjdk/jol/info/GraphLayout.java
! jol-core/src/main/java/org/openjdk/jol/util/ClassUtils.java
+ jol-core/src/test/java/org/openjdk/jol/info/ClassLayoutNamesTest.java
+ jol-core/src/test/java/org/openjdk/jol/info/GraphLayoutNamesTest.java


From shade at openjdk.org  Thu Oct  5 12:22:40 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 5 Oct 2023 12:22:40 GMT
Subject: Withdrawn: CODETOOLS-7903569: JOL: Use human-readable class names
 consistently
In-Reply-To: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
References: <o-Gi-WL6E_iQXgoKjoYTXKiG7qJrUcPhq4tdwNgBtYs=.10c27f43-16f2-4866-93c7-f79c5f0a073e@github.com>
Message-ID: <2ZrdjYd3KFOqZSRTaG5Z2cYS6QI6Wah-A5AwjwtDgdg=.2a26c22c-ff9b-46af-8e28-c84c337fe4a3@github.com>

On Thu, 5 Oct 2023 10:55:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> There are a couple of places, where we print out JVM names for classes. Notably, it happens during "footprint". We need to consistently use the human-readable class names everywhere.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jol/pull/51

From shade at openjdk.org  Fri Oct  6 14:17:59 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 6 Oct 2023 14:17:59 GMT
Subject: RFR: 7903570: JOL: Clean up CLI tools
Message-ID: <bRfIwdKz7YqndytU6Bb3rlBljs-l5FxFJ_xW540QqLQ=.7946ee8f-6968-41c7-ac42-4cbc436e23f3@github.com>

There are tools we do not maintain anymore, for example string-compress and object-shapes. Plus, the descriptions and names for current tools need to be cleaned up.

-------------

Commit messages:
 - Fix

Changes: https://git.openjdk.org/jol/pull/52/files
 Webrev: https://webrevs.openjdk.org/?repo=jol&pr=52&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903570
  Stats: 718 lines in 12 files changed: 178 ins; 521 del; 19 mod
  Patch: https://git.openjdk.org/jol/pull/52.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/52/head:pull/52

PR: https://git.openjdk.org/jol/pull/52

From duke at openjdk.org  Fri Oct  6 14:58:56 2023
From: duke at openjdk.org (duke)
Date: Fri, 6 Oct 2023 14:58:56 GMT
Subject: git: openjdk/jol: 7903570: JOL: Clean up CLI tools
Message-ID: <4846f94d-afc2-4b45-b5bc-4dbb7fe708f0@openjdk.org>

Changeset: 9d62009e
Author:    Aleksey Shipil?v <shade at openjdk.org>
Committer: GitHub <noreply at github.com>
Date:      2023-10-06 16:58:00 +0000
URL:       https://git.openjdk.org/jol/commit/9d62009e97a1756ae91a16ab9e72f294efce17a9

7903570: JOL: Clean up CLI tools


! jol-cli/src/main/java/org/openjdk/jol/Main.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ClasspathedOperation.java
! jol-cli/src/main/java/org/openjdk/jol/operations/HeapDumpEstimates.java
! jol-cli/src/main/java/org/openjdk/jol/operations/HeapDumpStats.java
- jol-cli/src/main/java/org/openjdk/jol/operations/ObjectEstimates.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectExternals.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectFootprint.java
! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectInternals.java
+ jol-cli/src/main/java/org/openjdk/jol/operations/ObjectInternalsEstimates.java
- jol-cli/src/main/java/org/openjdk/jol/operations/ObjectShapes.java
- jol-cli/src/main/java/org/openjdk/jol/operations/StringCompress.java
+ jol-core/src/main/java/org/openjdk/jol/util/Multimap.java


From shade at openjdk.org  Fri Oct  6 15:00:55 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 6 Oct 2023 15:00:55 GMT
Subject: Withdrawn: 7903570: JOL: Clean up CLI tools
In-Reply-To: <bRfIwdKz7YqndytU6Bb3rlBljs-l5FxFJ_xW540QqLQ=.7946ee8f-6968-41c7-ac42-4cbc436e23f3@github.com>
References: <bRfIwdKz7YqndytU6Bb3rlBljs-l5FxFJ_xW540QqLQ=.7946ee8f-6968-41c7-ac42-4cbc436e23f3@github.com>
Message-ID: <Qa4ll-oc0dRZcpZbfmE_svvALjvMmo4Epm3Her8juMc=.1f8d22c4-3bc3-47bb-849c-5b5f0cd17d1b@github.com>

On Fri, 6 Oct 2023 14:11:12 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> There are tools we do not maintain anymore, for example string-compress and object-shapes. Plus, the descriptions and names for current tools need to be cleaned up.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jol/pull/52